Re: [Maria-developers] A problem with implementing Group Commit with Binlog with MyRocks

2017-09-12 Thread andrei . elkin
Kristian, > andrei.el...@pp.inet.fi writes: > >>> 2. To make START TRANSACTION WITH CONSISTENT SNAPSHOT actually correctly >>> synchronise snapshots between multiple storage engines (MySQL does not have >>> this, I think). >> >> (Offtopic, but anyway what it is? Multi-engine transaction with this

Re: [Maria-developers] A problem with implementing Group Commit with Binlog with MyRocks

2017-09-11 Thread Kristian Nielsen
andrei.el...@pp.inet.fi writes: >> 2. To make START TRANSACTION WITH CONSISTENT SNAPSHOT actually correctly >> synchronise snapshots between multiple storage engines (MySQL does not have >> this, I think). > > (Offtopic, but anyway what it is? Multi-engine transaction with this > specific

Re: [Maria-developers] A problem with implementing Group Commit with Binlog with MyRocks

2017-09-11 Thread andrei . elkin
Kristian, Sergey, hello. While I'm still studying the Mariadb BGC (binlog group commit) let me jump in with few comments. > Sergey Petrunia writes: > >> == Some background == >> >> "group commit with binlog" feature needs to accomplish two goals: >> >> 1. Keep the binlog and

Re: [Maria-developers] A problem with implementing Group Commit with Binlog with MyRocks

2017-09-11 Thread Kristian Nielsen
Kristian Nielsen writes: > single thread. In MySQL, _both_ prepare and commits are so grouped from a > single thread (though I think one thread can do group prepare in parallel > with another doing group commit). Ehm, this is not true, of course. The prepare() calls

Re: [Maria-developers] A problem with implementing Group Commit with Binlog with MyRocks

2017-09-11 Thread Sergey Petrunia
Hi Kristian, On Mon, Sep 11, 2017 at 01:02:31PM +0200, Kristian Nielsen wrote: > Sergey Petrunia writes: > > > This is about https://jira.mariadb.org/browse/MDEV-11934. I've encountered > > an insteresting issue here, so I thought I would consult on both MyRocks and > >

Re: [Maria-developers] A problem with implementing Group Commit with Binlog with MyRocks

2017-09-11 Thread Kristian Nielsen
Sergey Petrunia writes: > == Some background == > > "group commit with binlog" feature needs to accomplish two goals: > > 1. Keep the binlog and the storage engine in sync. > storage_engine->prepare(sync=true); > binlog->write(sync=true); > storage_engine->commit(); > >

[Maria-developers] A problem with implementing Group Commit with Binlog with MyRocks

2017-09-08 Thread Sergey Petrunia
Hello, This is about https://jira.mariadb.org/browse/MDEV-11934. I've encountered an insteresting issue here, so I thought I would consult on both MyRocks and MariaDB lists. == Some background == "group commit with binlog" feature needs to accomplish two goals: 1. Keep the binlog and the