Hello!
I worked on the review and here is a report for the same.
CODE:
I fixed indentations and removed with_returning_list. Now I am using only
the select_result pointer to know whether returning_list is empty (except
in mysql_prepare_insert(). This function is using bool with_returning_list
wh
Hello!
Thanks for the review. It will indeed help me write better code and test
cases.
To begin with, I' ll first get familiar with git bisect. I'll keep you
updated about my progress.
Regards,
Rucha Deodhar
On Sun, Jul 7, 2019, 7:16 PM Vicențiu Ciorbaru wrote:
> Hi Rucha!
>
>
> Here is the p
Hi Rucha!
Here is the promised review. I have run the main test suite locally and
have noticedthat some tests fail if you run with a debug build. The
failure is an assertionfailure on the protocol level. This means you
forgot to call a my_ok or my_errorat an appropriate time. I suggest you
try and
3 matches
Mail list logo
