Re: [Maria-developers] MDEV-12803 Improve function parameter data type control

2017-05-26 Thread Alexander Barkov
Hello Alexey, Thanks for your feedback. Sending a new version, as discussed in this email and on IRC. Please find attached. - Removed Item_geometry_func_importer - Renamed Item_xxx_geometry_property to Item_xxx_args_geometry - Renamed Item_xxx_dyadic_operation to Item_xxx_args_geometry_geometry.

Re: [Maria-developers] MDEV-12803 Improve function parameter data type control

2017-05-24 Thread Alexander Barkov
Hi Alexey, Thank you very much for your review! Please see my comments below: On 05/23/2017 12:16 AM, Alexey Botchkov wrote: > Firstly I'd say i don't like the idea of the 'virtual check_arguments()' > function. > I belive it's more natural to have a member 'm_check_arguments_function' > that w

[Maria-developers] MDEV-12803 Improve function parameter data type control

2017-05-15 Thread Alexander Barkov
Hello Alexey, can you please review a patch for MDEV-12803? Thanks! diff --git a/mysql-test/r/func_gconcat.result b/mysql-test/r/func_gconcat.result index cbd0dfa..097e07a 100644 --- a/mysql-test/r/func_gconcat.result +++ b/mysql-test/r/func_gconcat.result @@ -1044,7 +1044,7 @@ DROP TABLE t1; CR