Re: [Maria-developers] MDEV-28152: Features for sequence

2023-03-21 Thread Yuchen Pei
Hi, Thanks for the comments. I have addressed them and updated the jira comment[1] with the urls to the new patch. https://jira.mariadb.org/browse/MDEV-28152?focusedCommentId=253836=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-253836 On Mon 2023-03-20 12:01:49 +0200,

Re: [Maria-developers] MDEV-28152: Features for sequence

2023-03-20 Thread Michael Widenius
Hi! I couple of small comments in addition to Sanjas review: > > +longlong sequence_definition::truncate_value(const Longlong_hybrid& > > original) > > +{ > > + if (is_unsigned) > > +return original.to_ulonglong(value_type_max()); > > + else if

Re: [Maria-developers] MDEV-28152: Features for sequence

2023-03-20 Thread Yuchen Pei
On Fri 2023-03-17 18:11:25 +1100, Yuchen Pei wrote: > Hi Oleksandr, > > Thanks for your comments. Please see below for my replies, with the urls > to the updated patch and the diff with the previous one at > >

Re: [Maria-developers] MDEV-28152: Features for sequence

2023-03-16 Thread Yuchen Pei
On Wed 2023-03-15 18:19:16 +1100, Yuchen Pei wrote: > P.S. While testing with the above, I found something buggy in the > existing sequence implementation which I may also need to fix: > > create sequence s maxvalue 500; > select next value for s; # 1 > alter sequence s cycle; > select next value

Re: [Maria-developers] MDEV-28152: Features for sequence

2023-03-15 Thread Yuchen Pei
Hi Oleksandr, Thanks for your comments. I am working through addressing them. I have done one pass and working through a list of about a dozen tasks as a result. While most of the tasks seem to be straightforward, there's one thing I would like to discuss, about a behaviour of sequences that