Re: [Maria-developers] MDEV-5450 Assertion ... mysql_type_to_time_type(cached_field_type) == ltime.time_type' fails ...

2014-02-03 Thread Alexander Barkov
On 02/03/2014 07:51 PM, Alexander Barkov wrote: Hi Sergei, On 02/03/2014 07:44 PM, Sergei Golubchik wrote: Hi, Alexander! Ah, so at the end you've decided to fix the type, not the assert. Fine. Ok to push. There were two problems actually: - the type - the assert I fixed both. Sorry,

Re: [Maria-developers] MDEV-5450 Assertion ... mysql_type_to_time_type(cached_field_type) == ltime.time_type' fails ...

2014-02-03 Thread Alexander Barkov
Hi Sergei, On 02/03/2014 07:44 PM, Sergei Golubchik wrote: Hi, Alexander! Ah, so at the end you've decided to fix the type, not the assert. Fine. Ok to push. There were two problems actually: - the type - the assert I fixed both. Thanks for review! Btw, the problem with type can be back

Re: [Maria-developers] MDEV-5450 Assertion ... mysql_type_to_time_type(cached_field_type) == ltime.time_type' fails ...

2014-02-03 Thread Sergei Golubchik
Hi, Alexander! Ah, so at the end you've decided to fix the type, not the assert. Fine. Ok to push. On Jan 31, Alexander Barkov wrote: > Hi Sergei, > > Please review a patch for mdev-5450. > > Thanks. > === modified file 'sql/item_timefunc.cc' > --- sql/item_timefunc.cc 2013-12-16 12:02:2

[Maria-developers] MDEV-5450 Assertion ... mysql_type_to_time_type(cached_field_type) == ltime.time_type' fails ...

2014-01-31 Thread Alexander Barkov
Hi Sergei, Please review a patch for mdev-5450. Thanks. === modified file 'mysql-test/r/func_time.result' --- mysql-test/r/func_time.result 2013-12-19 08:39:40 + +++ mysql-test/r/func_time.result 2014-01-31 12:58:42 + @@ -2382,3 +2382,60 @@ Catalog Database Table Table_alias Colum def