Re: [Maria-developers] Step#6: MDEV-7950 Item_func::type() takes 0.26% in OLTP RO

Hi Alexander, looks good, just a few minor suggestions inline. Some measures on my computer: add_key_fields 0.20% - out of radar Item_func_between::add_key_fields - 0.05% Item_equal::add_key_fields - 0.03% Item_equal::select_optimize 0.01%

[Maria-developers] Step#6: MDEV-7950 Item_func::type() takes 0.26% in OLTP RO

Hi Sergey, Please review the next iteration for MDEV-7950. This one splits the function add_key_fields() into a method in Item. This change removes about 3 virtual calls item-type(), as well as some virtual calls item_func-functype(), and adds one virtual call item-add_key_fields() instead.