Re: [Maria-developers] TRUE vs true (was: [Commits] ac05f41: postreview fix)

2015-04-23 Thread Sergey Vojtovich
Hi! According to MySQL coding guidelines: https://dev.mysql.com/doc/internals/en/additional-suggestions.html quot * In C code, use TRUE and FALSE rather than 1/0 * In C++ code, it is OK to use true and false (do not use 1/0). You can use C++ bool/true/false when calling C functions (values

[Maria-developers] TRUE vs true (was: [Commits] ac05f41: postreview fix)

2015-04-23 Thread Oleksandr Byelkin
Hi, Jan! On 23.04.15 08:38, Jan Lindström wrote: Sanja, Why you use TRUE/FALSE instead of true/false for bool ? Historical reasons. I was told to use TRUE/FALSE long time ago and nobody have told something else. We have no our code style doc so I use what I remember from old MySQL one.

Re: [Maria-developers] TRUE vs true (was: [Commits] ac05f41: postreview fix)

2015-04-23 Thread Sergei Golubchik
Hi, Sergey! Yup. I use TRUE/FALSE for my_bool in C and true/false for bool in C++. With the only expection of return values where 0 conventionally means success and non-zero means an error. As Mark Callaghan once commented bool somefunc() { ... /* got an error */ return

Re: [Maria-developers] TRUE vs true (was: [Commits] ac05f41: postreview fix)

2015-04-23 Thread Vicențiu Ciorbaru
Hi, I would like to point out that it would be a good idea to start writing our own coding style doc, so that we no longer have these sort of unknowns. It also helps the community provide patches that are easier for us to review. I can start working on it myself. Regards, Vicențiu On Thu, 23