Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-06-08 Thread Sergei Golubchik
Hi, Aleksey! Yes, I see your point. It's always a tradeoff. On May 27, Aleksey Midenkov wrote: > Hi, Sergei! > > That "double standard" is an obstacle for users to achieve maximum > potential of software. Advanced users must know how internals work and > because this is not documented it is

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-05-27 Thread Aleksey Midenkov
Hi, Sergei! That "double standard" is an obstacle for users to achieve maximum potential of software. Advanced users must know how internals work and because this is not documented it is frequently hard work. I'm just telling the downsides of the double concept. I know there are upsides of

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-05-27 Thread Sergei Golubchik
Hi, Aleksey! On Apr 27, Aleksey Midenkov wrote: > > On Apr 06, Aleksey Midenkov wrote: > > > To be able to specify them in INSERT command they must be at least > > > user-invisible. System-invisible fields are ignored. > > > > Sure, that's what @@system_versioning_insert_history would do. > >

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-05-27 Thread Sergei Golubchik
Hi, Aleksey! On Apr 27, Aleksey Midenkov wrote: > Sergei, > > sorry, I forgot to add that implementation with @@force_fields_visible > is cleaner and shorter. Also that helps to deprecate sysvers_show and > MDEV-16587 which I would greatly appreciate. "sysvers_show" is just a debugging hack. It

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-04-27 Thread Aleksey Midenkov
Sergei, sorry, I forgot to add that implementation with @@force_fields_visible is cleaner and shorter. Also that helps to deprecate sysvers_show and MDEV-16587 which I would greatly appreciate. On Tue, Apr 27, 2021 at 4:07 PM Aleksey Midenkov wrote: > > Hi Sergei! > > On Tue, Apr 6, 2021 at

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-04-27 Thread Aleksey Midenkov
Hi Sergei! On Tue, Apr 6, 2021 at 3:29 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On Apr 06, Aleksey Midenkov wrote: > > > > But, since we need to specify implicit system fields we cannot > > > > avoid adding one more session variable. In my current iteration I > > > > made

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-04-06 Thread Sergei Golubchik
Hi, Aleksey! On Apr 06, Aleksey Midenkov wrote: > > > But, since we need to specify implicit system fields we cannot > > > avoid adding one more session variable. In my current iteration I > > > made @@force_fields_visible which is more straightforward in what > > > it does: > > > > I'm sorry, I

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-04-06 Thread Aleksey Midenkov
Hi Sergei, On Mon, Apr 5, 2021 at 8:04 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On Feb 26, Aleksey Midenkov wrote: > > > > > > > > > > In other words, if one can create an arbitrary history by > > > > > manipulating @@timestamp variable, > > > > > @@system_versioning_insert_history allows

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-04-05 Thread Sergei Golubchik
Hi, Aleksey! On Feb 26, Aleksey Midenkov wrote: > > > > > > > > In other words, if one can create an arbitrary history by > > > > manipulating @@timestamp variable, > > > > @@system_versioning_insert_history allows to do it more > > > > conveniently. But if one cannot - he cannot. > > > > > >

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-02-26 Thread Aleksey Midenkov
Sergei, On Thu, Feb 25, 2021 at 11:09 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On Feb 25, Aleksey Midenkov wrote: > > > On Nov 24, Aleksey Midenkov wrote: > > > > 1. Add server variable system_versioning_insert_history which will > > > > allow INSERT history rows. > > > > 2. If

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-02-25 Thread Sergei Golubchik
Hi, Aleksey! On Feb 25, Aleksey Midenkov wrote: > > On Nov 24, Aleksey Midenkov wrote: > > > 1. Add server variable system_versioning_insert_history which will > > > allow INSERT history rows. > > > 2. If secure_timestamp is YES or REPLICATION, > > > system_versioning_insert_history does not have

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2021-02-25 Thread Aleksey Midenkov
Hi, Sergei! On Tue, Dec 1, 2020 at 7:54 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On Nov 24, Aleksey Midenkov wrote: > > > > And mysqldump should take care of setting system_versioning_insert_history > > sysvar. Right? Is everything else in the task description OK? > > Right. > > > 1. Add

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2020-12-01 Thread Sergei Golubchik
Hi, Aleksey! On Nov 24, Aleksey Midenkov wrote: > > And mysqldump should take care of setting system_versioning_insert_history > sysvar. Right? Is everything else in the task description OK? Right. > 1. Add server variable system_versioning_insert_history which will allow > INSERT history

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2020-11-24 Thread Aleksey Midenkov
Hi Sergei! On Tue, Sep 22, 2020 at 8:31 PM Sergei Golubchik wrote: > Hi, Aleksey! > > Wow, this comes so late, sorry! :( > > But it's fixVersion=10.6 and on the top my list, so here you are. > > On May 07, Aleksey Midenkov wrote: > > > > > > The conclusion, I believe, is that

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2020-09-22 Thread Sergei Golubchik
Hi, Aleksey! Wow, this comes so late, sorry! :( But it's fixVersion=10.6 and on the top my list, so here you are. On May 07, Aleksey Midenkov wrote: > > > > The conclusion, I believe, is that system_versioning_modify_history > > should allow INSERTs when secure_timestamp=NO, and it should allow

Re: [Maria-developers] ef2519fee4e: MDEV-16546 System versioning setting to allow history modification

2019-05-07 Thread Aleksey Midenkov
Hello, Sergei! On Fri, May 3, 2019 at 8:43 PM Sergei Golubchik wrote: > > Hi, Aleksey! > > On May 03, Aleksey Midenkov wrote: > > revision-id: ef2519fee4e (versioning-1.0.5-17-gef2519fee4e) > > parent(s): 56145be2951 > > author: Aleksey Midenkov > > committer: Aleksey Midenkov > > timestamp: