Hi, Kristian!
On Aug 05, Kristian Nielsen wrote:
>
> Sergei Golubchik writes:
>
> >> Other than that I think it is ok to push. I have a number of small remarks
> >> inline below, you can fix what you agree with and ignore the rest. There
> >> are
> >> also a couple of questions to check that m
Sergei Golubchik writes:
>> Other than that I think it is ok to push. I have a number of small remarks
>> inline below, you can fix what you agree with and ignore the rest. There are
>> also a couple of questions to check that my understanding is correct.
>
> Now, that you've seen the patch - sho
Hi, Kristian!
On Aug 04, Kristian Nielsen wrote:
> Sergei Golubchik writes:
>
> My main comment is that there should be some documentation of the My::Suite
> class, as I write in a comment below.
I'll add it, thanks.
> Other than that I think it is ok to push. I have a number of small remarks
Sergei Golubchik writes:
> Kristian, I've done the changes - would you mind to review the patch ?
> P.S. there are three patches attached - three bundles.
>
> the first one fixes ndb. as ndb is hacked in mtr and is all over the
> place, I could not change mtr without touching ndb related pieces,
Sergei Golubchik writes:
> Kristian, I've done the changes - would you mind to review the patch ?
Sure! I will review after finishing with XtraDB merge.
> the first one fixes ndb. as ndb is hacked in mtr and is all over the
> place, I could not change mtr without touching ndb related pieces,
>
5 matches
Mail list logo
