Re: [Maria-developers] [GSOC] Table functions (aka SQL functions returning tables)

2017-03-20 Thread Sergey Petrunia
Hi Pranjal, On Sun, Mar 19, 2017 at 09:53:08PM +0530, Pranjal Rai wrote: > My name is Pranjal and I am a 4th year student at IIIT Hyderabad. I am > interested in working on the project MDEV-8100 > "Table functions (aka SQL > functions returning tables)"

Re: [Maria-developers] Filtered transactions coming through mysql/mariadb replication to Galera cluster

2017-03-20 Thread Michael Widenius
Hi! > Hi, > > Galera cluster (https://github.com/codership/mysql-wsrep/commits/5.6) has new > feature : > > commit 14301279075dc2b420f3173cc9c2eb7912db63de > Author: sjaakola > Date: Fri Nov 18 12:45:42 2016 +0200 > > Refs: MW-319 > * replicating write set containing only GTID event of

Re: [Maria-developers] MDEV-12238 Add Type_handler::Item_func_{plus|minus|mul|div|mod}_fix_length_and_dec()

2017-03-20 Thread Alexander Barkov
Hello Alexey, Thanks for your review. Please find an updated version attached. On 03/19/2017 08:12 PM, Alexey Botchkov wrote: > Hi, Alexander. > > The patch is ok to push. > I only have two cosmetical recommendation. > 1. const Pair* find_pair() implementation belongs to sql_type.cc. A bit >

[Maria-developers] MDEV-12303 Add Type_handler::Item_xxx_fix_length_and_dec()

2017-03-20 Thread Alexander Barkov
Hello Alexey, Can you please review a patch for MDEV-12303? Thanks! diff --git a/mysql-test/r/gis.result b/mysql-test/r/gis.result index 484d2ba..f3e96f6 100644 --- a/mysql-test/r/gis.result +++ b/mysql-test/r/gis.result @@ -3778,5 +3778,64 @@ SELECT STDDEV(COALESCE(a)) FROM t1; ERROR HY000: Il

Re: [Maria-developers] b6f4d16: MDEV-10436 non-deterministic vcol does not force rbr

2017-03-20 Thread Sergei Golubchik
Hi, Sachin! On Mar 15, Sachin Setiya wrote: > Hi Serg! > > On Sun, Mar 12, 2017 at 11:50 PM, Sergei Golubchik wrote: > > Hi, Sachin! > > > > On Feb 10, Sachin Setiya wrote: > >> revision-id: b6f4d16a015fc778186ae4d2c1820a78cd9645d1 > >> (mariadb-10.2.3-157-gb6f4d16) > >> parent(s): 5285504857df

Re: [Maria-developers] 23959479689: MDEV-11419: Report all INSERT ID for bulk operation INSERT

2017-03-20 Thread Sergei Golubchik
Hi, Oleksandr! On Mar 15, Oleksandr Byelkin wrote: > >> diff --git a/include/mysql_com.h b/include/mysql_com.h > >> index c399520022d..9fac5edd1bc 100644 > >> --- a/include/mysql_com.h > >> +++ b/include/mysql_com.h > >> @@ -551,7 +551,8 @@ enum enum_cursor_type > >> CURSOR_TYPE_NO_CURSOR= 0,

Re: [Maria-developers] [GSOC] ColumnStore: Add full support for DECIMAL

2017-03-20 Thread Andrew Hutchings
Hi Daniil, Many thanks for your interest. We haven't fully specified it yet (I'll build a full specification later this week). But I suspect the following would be involved: * Implementation of methods to handle MariaDB's DECIMAL format * Support for a longer than 8-byte numeric column type (ther

Re: [Maria-developers] [GSOC] ColumnStore: Add full support for DECIMAL

2017-03-20 Thread Даниил Медведев
I looked at the code (for better understanding of problem), and now I have some questions: Do I understand correctly, that now it is stored as an int64 value with a scale and we want to extend it, and store maximum 65 digits as in documentation? https://github.com/mariadb-corporation/mariadb-column

Re: [Maria-developers] [GSOC] ColumnStore: Add full support for DECIMAL

2017-03-20 Thread Andrew Hutchings
Hi Daniil, Yes, it is currently stored as an int64. We want to extend it but also some of the internal functionality converts it to a double (see utils/funcexp/func_math.cpp for example). Every function would need to be fully tested to make sure that it uses DECIMAL end-to-end and handles overflow

[Maria-developers] Google Summer of Code

2017-03-20 Thread Daniel Black
I got referred to another GSoC documentation site: https://code.timvideos.us/summer-of-code/ I think its a pretty good model of what sort of documentation students should read as largely it applies to projects in general. ___ Mailing list: https://la

Re: [Maria-developers] 1ee6b0ff748: MDEV-11115 CHECK constraints are not shown in I_S.TABLE_CONSTRAINTS

2017-03-20 Thread Jacob Mathew
Hi Sergei, Both the changes for this bug and the changes for MDEV-10355 are in a stage tree named bb-10.2-. However, when I look at the automated testing on their respective branches, I see a few failures. As far as I can tell, none of the failures could have been caused by my changes To give m

Re: [Maria-developers] 1ee6b0ff748: MDEV-11115 CHECK constraints are not shown in I_S.TABLE_CONSTRAINTS

2017-03-20 Thread Marko Mäkelä
Hi Jacob, The branch bb-10.2-MDEV-5 appears to be based on an ancient version of 10.2: commit e1f0f0dd06d5e6f606c962b09ab0f6c0f1197955 Author: Sergei Golubchik Date: Mon Feb 13 18:37:06 2017 +0100 In my opinion, when you push something for BuildBot testing, the base should be reasonably n