[Maria-developers] commit_checkpoint_request() vs. thd_get_durability_property() (in relation to MDEV-11937)

2017-08-07 Thread Kristian Nielsen
Monty asked me to fix MDEV-11937. This particular one is a performance regression in InnoDB commit. But there is a wider problem that I thought I should explain, so it can be perhaps avoided in the future. MariaDB and MySQL use different mechanisms for storage engines to avoid having to fsync duri

Re: [Maria-developers] commit_checkpoint_request() vs. thd_get_durability_property() (in relation to MDEV-11937)

2017-08-07 Thread Jan Lindström
Hi, On Mon, Aug 7, 2017 at 2:09 PM, Kristian Nielsen wrote: > > The problem is that somehow the thd_get_durability_property() function was > introduced into MariaDB code, but it is completely non-functional. So now > there is code in InnoDB, TokuDB and RocksDB that calls this function and > does

Re: [Maria-developers] commit_checkpoint_request() vs. thd_get_durability_property() (in relation to MDEV-11937)

2017-08-07 Thread Marko Mäkelä
Kristian, Thank you for your analysis. I suggest that we remove the unused declarations and code as soon as possible. Would you do that already under MDEV-11937? I think that future code merges from MySQL should be based on individual commits rather than snapshots. For merging the changes from 5.