Re: [Maria-developers] 0608c273598: MDEV-15966: Behavior for TRUNCATE versioned table is not documented and not covered by tests

2019-02-28 Thread Nikita Malyavin
On Fri, Dec 28, 2018 at 9:18 AM Sergei Golubchik wrote: > Hi, Nikita! > > On Dec 28, Nikita Malyavin wrote: > > Hi, Sergei! > > > > In short, I am on the side of standard conformance. > > Our TRUNCATE is not exactly a standard TRUNCATE. it's defined as > DROP+REPLACE. But generally I agree,

Re: [Maria-developers] df203d1daa1: MDEV-15990: REPLACE on a precise-versioned table returns duplicate key error (ER_DUP_ENTRY)

2019-02-28 Thread Nikita Malyavin
Hi, Sergei! On Thu, Dec 27, 2018 at 10:19 PM Sergei Golubchik wrote: > Hi, Nikita! > > Sorry, I don't understand what are you fixing and why :( > Could you please elaborate? > > Have you already had a look at MDEV-16546 "System versioning setting to allow history modification", which I've also

Re: [Maria-developers] ce29dfac72e: MDEV-18601: Can't create table with ENCRYPTED=DEFAULT when innodb_default_encryption_key_id!=1

2019-02-28 Thread Sergei Golubchik
Hi, Marko! On Feb 27, Marko Mäkelä wrote: > Greetings from MariaDB Openworks in New York City. > > I just discussed this with Monty. His idea is that "don’t care" > attributes should be ignored, or at most a warning could be issued for > them. This allows ALTER TABLE from one storage engine to

Re: [Maria-developers] 0608c273598: MDEV-15966: Behavior for TRUNCATE versioned table is not documented and not covered by tests

2019-02-28 Thread Nikita Malyavin
On Fri, Mar 1, 2019 at 1:24 AM Sergei Golubchik wrote: > Hi, Nikita! > > On Feb 28, Nikita Malyavin wrote: > > On Fri, Dec 28, 2018 at 9:18 AM Sergei Golubchik > wrote: > > > On Dec 28, Nikita Malyavin wrote: > > > > Hi, Sergei! > > > > > > > > In short, I am on the side of standard

Re: [Maria-developers] 0608c273598: MDEV-15966: Behavior for TRUNCATE versioned table is not documented and not covered by tests

2019-02-28 Thread Sergei Golubchik
Hi, Nikita! On Feb 28, Nikita Malyavin wrote: > On Fri, Dec 28, 2018 at 9:18 AM Sergei Golubchik wrote: > > On Dec 28, Nikita Malyavin wrote: > > > Hi, Sergei! > > > > > > In short, I am on the side of standard conformance. > > > > Our TRUNCATE is not exactly a standard TRUNCATE. it's defined as

Re: [Maria-developers] ce29dfac72e: MDEV-18601: Can't create table with ENCRYPTED=DEFAULT when innodb_default_encryption_key_id!=1

2019-02-28 Thread Marko Mäkelä
Hi Sergei, On Thu, Feb 28, 2019 at 5:08 PM Sergei Golubchik wrote: > > Hi, Marko! > > On Feb 27, Marko Mäkelä wrote: > > Greetings from MariaDB Openworks in New York City. > > > > I just discussed this with Monty. His idea is that "don’t care" > > attributes should be ignored, or at most a

Re: [Maria-developers] bc7d600a27f: MDEV-15951 system versioning by trx id doesn't work with partitioning

2019-02-28 Thread Nikita Malyavin
Hi, Sergei! On Wed, Dec 26, 2018 at 7:42 AM Sergei Golubchik wrote: > Hi, Nikita! > > On Dec 21, Nikita Malyavin wrote: > > > > @@ -4938,6 +4938,7 @@ int ha_create_table(THD *thd, const char *path, > > > > !create_info->tmp_table(); > > > > > > > > share.frm_image=

Re: [Maria-developers] 773d24d457a: MDEV-15951 system versioning by trx id doesn't work with partitioning

2019-02-28 Thread Nikita Malyavin
On Wed, Dec 26, 2018 at 8:53 AM Sergei Golubchik wrote: > Hi, Nikita! > > On Dec 25, Nikita Malyavin wrote: > > revision-id: 773d24d457a (versioning-1.0.6-100-g773d24d457a) > > parent(s): b26736cdb11 > > author: Nikita Malyavin > > committer: Nikita Malyavin > > timestamp: 2018-12-21 03:13:47

Re: [Maria-developers] 773d24d457a: MDEV-15951 system versioning by trx id doesn't work with partitioning

2019-02-28 Thread Nikita Malyavin
> > +DBUG_RETURN(TRUE); >> > + } >> >num_fields++; >> > +} >> >} >> >if (unlikely(num_fields > MAX_REF_PARTS)) >> >{ >> > diff --git a/sql/table.cc b/sql/table.cc >> > index ce7a34a8fe2..0c2ff1eea5a 100644 >> > --- a/sql/table.cc >> > +++ b/sql/table.cc >> > @@