Re: [Maria-developers] facc973189a: Session_sysvars_tracker::vars_list cleanups

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! On Mar 25, Sergey Vojtovich wrote: > revision-id: facc973189a (mariadb-10.3.12-86-gfacc973189a) > parent(s): 4c0eb412ff5 > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-03-18 22:51:58 +0400 > message: > > Session_sysvars_tracker::vars_list cleanups > > -

Re: [Maria-developers] MDEV-18734 ASAN heap-use-after-free in my_strnxfrm_simple_internal upon update on versioned partitioned table

2019-03-25 Thread Aleksey Midenkov
Hi Sergei, On Thu, Mar 21, 2019 at 10:24 PM Sergei Golubchik wrote: > Hi, Aleksey! > > On Mar 20, Aleksey Midenkov wrote: > > Hi Sergei! > > > > It turned out that only vcol blobs are affected. They are allocated > > by update_virtual_fields(), so it was enough to just refresh their value > by >

[Maria-developers] Please review MDEV-18319 BIGINT UNSIGNED Performance issue

2019-03-25 Thread Alexander Barkov
Hi Sergei, Please review a patch for MDEV-18319 https://github.com/MariaDB/server/commit/8a990ad17746927c6d395ec755a262eda59191fb Thanks ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsub

Re: [Maria-developers] 68abb07298b: Cleanup session tracker redundnacy

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! ok to push On Mar 25, Sergey Vojtovich wrote: > revision-id: 68abb07298b (mariadb-10.3.12-87-g68abb07298b) > parent(s): facc973189a > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-03-18 22:51:58 +0400 > message: > > Cleanup session tracker redundnacy > >

Re: [Maria-developers] 4c0eb412ff5: A proper State_tracker::m_changed enacpsulation

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! ok to push On Mar 25, Sergey Vojtovich wrote: > revision-id: 4c0eb412ff5 (mariadb-10.3.12-85-g4c0eb412ff5) > parent(s): 69b33fca8cc > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-03-18 22:51:45 +0400 > message: > > A proper State_tracker::m_changed enacp

Re: [Maria-developers] 9dd4fcb3f7c: Get rid of not implemented SESSION_GTIDS_TRACKER

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! ok to push On Mar 25, Sergey Vojtovich wrote: > revision-id: 9dd4fcb3f7c (mariadb-10.3.12-89-g9dd4fcb3f7c) > parent(s): 72e4e57a52a > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-03-19 17:28:09 +0400 > message: > > Get rid of not implemented SESSION_GTID

Re: [Maria-developers] 61b9bffbedc: Allocate orig_list statically

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! ok to push On Mar 25, Sergey Vojtovich wrote: > revision-id: 61b9bffbedc (mariadb-10.3.12-90-g61b9bffbedc) > parent(s): 9dd4fcb3f7c > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-03-19 23:39:19 +0400 > message: > > Allocate orig_list statically > > tool

Re: [Maria-developers] 62d62228aa6: Static current schema and state change trackers

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! Why two trackers are static and the other two aren't? Please, explain it in a comment. On Mar 25, Sergey Vojtovich wrote: > revision-id: 62d62228aa6 (mariadb-10.3.12-91-g62d62228aa6) > parent(s): 61b9bffbedc > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-

Re: [Maria-developers] db9854b7d48: Allocate Transaction_state_tracker statically

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! ok to push On Mar 25, Sergey Vojtovich wrote: > revision-id: db9854b7d48 (mariadb-10.3.12-92-gdb9854b7d48) > parent(s): 62d62228aa6 > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-03-19 23:40:07 +0400 > message: > > Allocate Transaction_state_tracker stat

Re: [Maria-developers] 62d62228aa6: Static current schema and state change trackers

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! nevermind :) ok to push On Mar 25, Sergei Golubchik wrote: > Hi, Sergey! > > Why two trackers are static and the other two aren't? > Please, explain it in a comment. > > On Mar 25, Sergey Vojtovich wrote: > > revision-id: 62d62228aa6 (mariadb-10.3.12-91-g62d62228aa6) > > parent(s):

Re: [Maria-developers] 72e4e57a52a: Cleanup session tracker API

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! ok to push On Mar 25, Sergey Vojtovich wrote: > revision-id: 72e4e57a52a (mariadb-10.3.12-88-g72e4e57a52a) > parent(s): 68abb07298b > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-03-19 17:11:16 +0400 > message: > > Cleanup session tracker API > > - Sess

Re: [Maria-developers] 3c6f17a130b: Allocate Session_sysvars_tracker statically

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! Please, see few questions below On Mar 25, Sergey Vojtovich wrote: > revision-id: 3c6f17a130b (mariadb-10.3.12-93-g3c6f17a130b) > parent(s): db9854b7d48 > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-03-19 23:40:07 +0400 > message: > > Allocate Session_s

Re: [Maria-developers] a83d6ee812b: Safe session_track_system_variables snapshot

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! Just one question. Why do you need Session_sysvars_tracker::session_track_system_variables if you have THD::system_variables::session_track_system_variables ? On Mar 25, Sergey Vojtovich wrote: > revision-id: a83d6ee812b (mariadb-10.3.12-94-ga83d6ee812b) > parent(s): 3c6f17a130b > au

Re: [Maria-developers] 48af6851da2: Make connect speed great again

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! On Mar 25, Sergey Vojtovich wrote: > revision-id: 48af6851da2 (mariadb-10.3.12-95-g48af6851da2) > parent(s): a83d6ee812b > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-03-20 01:58:42 +0400 > message: > > Make connect speed great again > > Rather than par

Re: [Maria-developers] 6f14489ad31: Adieu find_sys_var_ex()

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! ok to push On Mar 25, Sergey Vojtovich wrote: > revision-id: 6f14489ad31 (mariadb-10.3.12-96-g6f14489ad31) > parent(s): 48af6851da2 > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-03-21 01:32:04 +0400 > message: > > Adieu find_sys_var_ex() > > Only take

Re: [Maria-developers] 0fa832dc426: Revert THD::THD(skip_global_sys_var_lock) argument

2019-03-25 Thread Sergei Golubchik
Hi, Sergey! ok to push On Mar 25, Sergey Vojtovich wrote: > revision-id: 0fa832dc426 (mariadb-10.3.12-97-g0fa832dc426) > parent(s): 6f14489ad31 > author: Sergey Vojtovich > committer: Sergey Vojtovich > timestamp: 2019-03-21 17:17:26 +0400 > message: > > Revert THD::THD(skip_global_sys_var_loc