Re: [Maria-developers] a4be420c920: MDEV-19235 MariaDB Server compiled for 128 Indexes crashes at startup

2019-05-09 Thread Vladislav Vaintroub
Hi Serg, Thanks for looking >> +public: >> uint32 buffer[(width+31)/32]; > Why is it public? No reason, an oversight. Leftover from previous testing, I fixed it. > + Bitmap():buffer() zero initialization of member variable ,here of the type array (s https://stackoverflow.com/a/23987926/5470

Re: [Maria-developers] a4be420c920: MDEV-19235 MariaDB Server compiled for 128 Indexes crashes at startup

2019-05-09 Thread Sergei Golubchik
Hi, Vladislav! On May 09, Vladislav Vaintroub wrote: > >> + void set_all() > >> + { > >> +set_prefix(width); > > > >may be better to optimize it? > > memset(buffer, 0xff, sizeof(buffer) - 1); > > ((uchar*)buffer)[sizeof(buffer)-1] = last_byte_mask(width); > > I’m not really convinced this w