[Maria-developers] review for MDEV-14564: Support FOR loop in stored aggregate functions

Hi Varun, I was recently assigned as a reviewer for this patch: http://lists.askmonty.org/pipermail/commits/2017-December/011777.html I have some suggestions. 1. The MDEV says the proposed syntax is: FOR GROUP ROWS DO and you implemented: FOR GROUP NEXT ROW DO I think the syntax on MDEV lo

Re: [Maria-developers] review for MDEV-14564: Support FOR loop in stored aggregate functions

Hi Varun, Forgot to mention two more things: - SHOW FUNCTION CODE is available in DBUG build only You'll have to split MTR tests in two parts. The part that performs SHOW FUNCTION CODE should be in a test file which includes this: -- source include/have_debug.inc - The new FOR loop sho