Re: [Maria-developers] d7b274fa257: MDEV-16932: ASAN heap-use-after-free in my_charlen_utf8 / my_well_formed_char_length_utf8 on 2nd execution of SP with ALTER trying to add bad CHECK

2019-07-16 Thread Oleksandr Byelkin
Am 15.07.19 um 19:21 schrieb Sergei Golubchik: Hi, Oleksandr! A couple of minor comments, see below On Jul 15, Oleksandr Byelkin wrote: revision-id: d7b274fa257 (mariadb-10.2.25-63-gd7b274fa257) parent(s): 64900e3d7c3 author: Oleksandr Byelkin committer: Oleksandr Byelkin timestamp: 2019-07-

[Maria-developers] MDEV-8306: more input

2019-07-16 Thread Sergey Petrunia
Hi Varun, Please find more input, I'm commenting on the second patch (the review is probably incomplete, I've made just one pass so might have missed something) > diff -urpN '--exclude=.*' 10.5-mdev8306-orig/sql/opt_subselect.cc > 10.5-mdev8306/sql/opt_subselect.cc > --- 10.5-mdev8306-orig/sql/o

Re: [Maria-developers] [Commits] fb619954867: MDEV-15010: Wrong Seconds_Behind_Master when only starting the SQL_Thread

2019-07-16 Thread andrei . elkin
Sujatha, howdy. Thanks for a good piece of work! The fact that it's actually an upstream contribution only pleases more :-), and to that regard we need a commit id to refer to (and to the people behind that work :-)). > revision-id: fb619954867232b3a733213a2703b2a425dff8e9 > (mariadb-5.5.64-19-g