Re: [Maria-developers] [Commits] d48294d15c4: MDEV-13694: Wrong result upon GROUP BY with orderby_uses_equalities=on

2019-10-09 Thread Sergey Petrunia
Hi Varun, This patch is a step in the right direction, but I think we're not quite there yet. The patch adds logic about semi-join materialization into the filesort code This makes things really messy. I think, some isolation would be beneficial. The first suggestion: In Sort_param (as this str

Re: [Maria-developers] 4ca016237f1: MDEV-20001 Potential dangerous regression: INSERT INTO >=100 rows fail for myisam table with HASH indexes

2019-10-09 Thread Sachin Setiya
Hi Serg! Thanks for review On Tue, Aug 20, 2019 at 6:08 PM Sergei Golubchik wrote: > Hi, Sachin! > > On Aug 20, Sachin Setiya wrote: > > revision-id: 4ca016237f1 (mariadb-10.4.5-152-g4ca016237f1) > > parent(s): 4a5cd407289 > > author: Sachin > > committer: Sachin > > timestamp: 2019-07-29 19: