Re: [Maria-developers] 6ac19d09c66: MDEV-16978 Application-time periods: WITHOUT OVERLAPS

2019-12-04 Thread Sergei Golubchik
Hi, Nikita! On Dec 04, Nikita Malyavin wrote: > > Another case: > suppose you have to rows in table with periods (a (a, c), > (c, d). > Let us update (c,d) --> (b,d). I call it "move left". > > ha_index_read_map with period_start < d will return (c,d). Again check > is_update, and call

Re: [Maria-developers] 6ac19d09c66: MDEV-16978 Application-time periods: WITHOUT OVERLAPS

2019-12-04 Thread Nikita Malyavin
On Wed, 4 Dec 2019 at 01:00, Nikita Malyavin wrote: > > > On Tue, 3 Dec 2019 at 23:59, Sergei Golubchik wrote: > >> > > > > But it can be done better. You search for the key with the same >> > > > > value and a period start <= than the period start of new row. >> > > > > And then you have to

Re: [Maria-developers] 6ac19d09c66: MDEV-16978 Application-time periods: WITHOUT OVERLAPS

2019-12-04 Thread Nikita Malyavin
Well, I've pushed that logic. Looks about 2 lines prettier ср, 4 дек. 2019 г., 19:19 Sergei Golubchik : > Hi, Nikita! > > On Dec 04, Nikita Malyavin wrote: > > > > Another case: > > suppose you have to rows in table with periods (a > (a, c), > > (c, d). > > Let us update (c,d) --> (b,d). I call

Re: [Maria-developers] 6ac19d09c66: MDEV-16978 Application-time periods: WITHOUT OVERLAPS

2019-12-04 Thread Nikita Malyavin
Heh, unfortunately comparing refs will not work in conjunction with KEYREAD: for innodb ref can be a primary key, if it has it, so index is not clustered. The index we're evaluating can be different from a primary key. In that case some values can be left unfetched with KEYREAD. All that is

Re: [Maria-developers] 6ac19d09c66: MDEV-16978 Application-time periods: WITHOUT OVERLAPS

2019-12-04 Thread Sergei Golubchik
Hi, Nikita! On Dec 05, Nikita Malyavin wrote: > Heh, unfortunately comparing refs will not work in conjunction with KEYREAD: > > for innodb ref can be a primary key, if it has it, so index is not > clustered. The index we're evaluating can be different from a primary key. > > In that case some

Re: [Maria-developers] 387839e44cc: Plugin for Hashicorp Vault Key Management System

2019-12-04 Thread Sergei Golubchik
Hi, Julius! Just a couple of comments, see below: On Dec 04, Julius Goryavsky wrote: > revision-id: 387839e44cc (mariadb-10.4.10-179-g387839e44cc) > parent(s): 8115a02283d > author: Julius Goryavsky > committer: Julius Goryavsky > timestamp: 2019-11-15 13:37:35 +0100 > message: > > Plugin for

Re: [Maria-developers] c91ec05e01b: MDEV-20865 Store foreign key info in TABLE_SHARE

2019-12-04 Thread Sergei Golubchik
Hi, Aleksey! Just a question for now (and a couple of style comments, I didn't look at the logic yet) On Dec 04, Aleksey Midenkov wrote: > revision-id: c91ec05e01b (mariadb-10.4.4-427-gc91ec05e01b) > parent(s): e6d653b448d > author: Aleksey Midenkov > committer: Aleksey Midenkov > timestamp: