Re: [Maria-developers] fb29c886701: Handle errors from external_unlock & mysql_unlock_tables

2020-04-16 Thread Michael Widenius
Hi! > > > > Handle errors from external_unlock & mysql_unlock_tables > > > > Other things: > > - Handler errors from ha_maria::implict_commit > > - Disable DBUG in safe_mutex_lock to get trace file easier to read > > > > diff --git a/mysys/thr_mutex.c b/mysys/thr_mutex.c > > index

Re: [Maria-developers] bf32018be96: Added support for VISIBLE attribute for indexes in CREATE TABLE

2020-04-16 Thread Michael Widenius
Hi! On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Apr 13, Michael Widenius wrote: > > revision-id: bf32018be96 (mariadb-10.5.2-126-gbf32018be96) > > parent(s): 62c2d0f3e1f > > author: Michael Widenius > > committer: Michael Widenius > > timestamp: 2020-04-09

Re: [Maria-developers] faf8de3aa98: Fixed some assert crashes related to keyread.

2020-04-16 Thread Michael Widenius
Hi! On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik wrote: > where's a test case for MDEV-22077? One can't use the test case in MDEV-22077 as it involves a table created by a 32 bit MariaDB version. Doing another test case it's very hard so I ignored it and just did run the test to verify

Re: [Maria-developers] 3cbe15bd78c: Fixed core dump in alter table if ADD PARTITION fails

2020-04-16 Thread Michael Widenius
Hi! On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Apr 13, Michael Widenius wrote: > > revision-id: 3cbe15bd78c (mariadb-10.5.2-120-g3cbe15bd78c) > > parent(s): d4d332d196d > > author: Michael Widenius > > committer: Michael Widenius > > timestamp: 2020-04-09

Re: [Maria-developers] 9243921c84b: Make all #sql temporary table names uniform

2020-04-16 Thread Michael Widenius
Hi! > > ALTER PARTITION shadow files: > > #sql-shadow-'original_table_name' > > Please, add a thread_id here at the end. normally MDL should ensure that > no two threads can have a shadow for the same table at the same time, > but we have enough bugs as it is to introduce another vector when

Re: [Maria-developers] bc5c062b1d1: Don't try to open temporary tables if there are no temporary tables

2020-04-16 Thread Michael Widenius
Hi! On Thu, Apr 16, 2020 at 1:17 PM Sergei Golubchik wrote: > > Hi, Michael! > > On Apr 13, Michael Widenius wrote: > > revision-id: bc5c062b1d1 (mariadb-10.5.2-124-gbc5c062b1d1) > > parent(s): fb29c886701 > > author: Michael Widenius > > committer: Michael Widenius > > timestamp: 2020-04-09