Re: [Maria-developers] GSoC:Regex Project

2013-04-18 Thread Alexander Barkov
Hi Tamás, On 04/17/2013 09:53 PM, Tamás Kövesdan wrote: Hello, I'm interested in this project. I have read the other thread about this. I've checked the available regex implementations and I've written a draft application. Is there any potential mentor who would review my application and help

Re: [Maria-developers] GSoC:Regex Project

2013-04-19 Thread Alexander Barkov
to integrate with MariaDB character sets and collations. 2013/4/18 Alexander Barkov b...@mariadb.org mailto:b...@mariadb.org Hi Tamás, On 04/17/2013 09:53 PM, Tamás Kövesdan wrote: Hello, I'm interested in this project. I have read the other thread about this. I've

Re: [Maria-developers] is this a bug?

2013-04-29 Thread Alexander Barkov
Hello, This is definitely a bug. 0x is a MySQL extension, and it's a hybrid thing. It can behave as a number and a string depending on context. Binary log could use the X'' notation instead: INSERT INTO t1 VALUES (a) VALUES (X'31'); which is an SQL standard, and which must always

Re: [Maria-developers] is this a bug?

2013-05-06 Thread Alexander Barkov
preserved the old behaviour in the class implementing 0x. Perhaps it should also be fixed somehow. What do you think? Thanks. On Apr 30, Alexander Barkov wrote: Hello, This is definitely a bug. 0x is a MySQL extension, and it's a hybrid thing. It can behave as a number and a string

Re: [Maria-developers] Review request: mdev-4634

2013-06-13 Thread Alexander Barkov
/MDEV-4653 https://mariadb.atlassian.net/browse/MDEV-4654 Here's a new one, found today: https://mariadb.atlassian.net/browse/MDEV-4651 On Jun 11, Alexander Barkov wrote: === modified file 'sql/item.cc' --- sql/item.cc 2013-03-17 06:41:22 + +++ sql/item.cc 2013-06-11 11:52:43 + @@ -252,7

[Maria-developers] Review request: mdev-4635

2013-06-13 Thread Alexander Barkov
Hi Serg, please review a fix for MDEV-4635 Thanks. === modified file 'mysql-test/r/func_time.result' --- mysql-test/r/func_time.result 2013-03-20 15:13:00 + +++ mysql-test/r/func_time.result 2013-06-13 08:39:15 + @@ -1910,3 +1910,13 @@ SELECT 1 FROM DUAL WHERE MINUTE(TIMEDIFF 1 SELECT

[Maria-developers] Review request: mdev-4651

2013-06-13 Thread Alexander Barkov
Hi Serg, Please review a patch for mdev-4651 Crash in my_decimal2decimal in a ORDER BY query. Thanks. === modified file 'mysql-test/r/ps_2myisam.result' --- mysql-test/r/ps_2myisam.result 2011-07-23 06:47:28 + +++ mysql-test/r/ps_2myisam.result 2013-06-13 13:59:20 + @@ -1793,7 +1793,7

Re: [Maria-developers] Review request: mdev-4635

2013-06-13 Thread Alexander Barkov
Hi, Serg, On 06/13/2013 08:16 PM, Sergei Golubchik wrote: Hi, Alexander! On Jun 13, Alexander Barkov wrote: please review a fix for MDEV-4635 Is it for 5.1 or 5.5? For 5.3. === modified file 'mysql-test/r/func_time.result' --- mysql-test/r/func_time.result 2013-03-20 15:13:00

Re: [Maria-developers] Review request: mdev-4635

2013-06-14 Thread Alexander Barkov
Hi Sergei, On 06/14/2013 04:30 PM, Sergei Golubchik wrote: Hi, Alexander! On Jun 13, Alexander Barkov wrote: On 06/13/2013 08:16 PM, Sergei Golubchik wrote: === modified file 'mysql-test/r/strict.result' --- mysql-test/r/strict.result 2011-06-05 02:56:06 + +++ mysql-test/r

Re: [Maria-developers] Review request: mdev-4634

2013-06-26 Thread Alexander Barkov
! On Jun 13, Alexander Barkov wrote: Hi, Alexander! This looks like a lot of changes for what you explained the reason of the bug was. There will be lots of whys below... The fix itself was quite small. However, an attempt to write a reasonable test case revealed a few other bugs. I just tried

[Maria-developers] MDEV-4667 DATE('string') incompability between mysql and mariadb

2013-07-03 Thread Alexander Barkov
Hi Serg, my review comments for http://bazaar.launchpad.net/~maria-captains/maria/5.3-serg/revision/3665 The patch looks ok. Just a couple of small comments: === modified file 'include/my_time.h' --- include/my_time.h 2011-12-11 09:34:44 + +++ include/my_time.h 2013-07-03 07:46:20

Re: [Maria-developers] merge for MySQL56 temporal literals

2013-07-03 Thread Alexander Barkov
Hello Wlad, On 07/03/2013 01:30 PM, Vladislav Vaintroub wrote: -Original Message- From: Maria-developers [mailto:maria-developers- bounces+wlad=montyprogram@lists.launchpad.net] On Behalf Of Alexander Barkov Sent: Mittwoch, 3. Juli 2013 10:18 To: Sergei Golubchik Cc: maria

[Maria-developers] Connect: compilation warnings

2013-07-08 Thread Alexander Barkov
Hi Oliver, I fixed almost all compilation warnings that happened in Connect on my Fedora 17 laptop with gcc-4.7.2. Most of them were variable is initialized but not used and no previous declaration. There were not serious, but very unpleasant for developers. (Note, we try to keep the tree in

Re: [Maria-developers] [Commits] Rev 3677: Fix bug MDEV-4895 Valgrind warnings (Conditional jump or move depends on uninitialised value) in Field_datetime::get_date on GREATEST(..) IS NULL in file:///

2013-08-20 Thread Alexander Barkov
Hi Timour, The patch looks Okey to push for me. Please find two small neat-peaking comments below though :) On 08/20/2013 04:36 PM, tim...@askmonty.org wrote: At file:///home/tsk/mprog/src/5.3/ revno: 3677 revision-id:

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-17 Thread Alexander Barkov
On 09/17/2013 08:52 PM, Alexander Barkov wrote: Hi Monty, On 09/17/2013 08:12 PM, Michael Widenius wrote: Hi! Alexander == Alexander Barkov b...@mariadb.org writes: Alexander Hi Monty, Alexander thanks for review. Alexander I have addressed most of your suggestions. See the new

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-17 Thread Alexander Barkov
to implement base32. thanks guys 2013/9/17 Alexander Barkov b...@mariadb.org mailto:b...@mariadb.org Hi Monty, thanks for review. I have addressed most of your suggestions. See the new version attached, and the detailed comments inline: On 09/12/2013 04:32 PM, Michael

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-17 Thread Alexander Barkov
Hi Monty, On 09/17/2013 08:12 PM, Michael Widenius wrote: Hi! Alexander == Alexander Barkov b...@mariadb.org writes: Alexander Hi Monty, Alexander thanks for review. Alexander I have addressed most of your suggestions. See the new version attached, Alexander and the detailed comments

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Alexander Barkov
will try to rewrite to base32 if possible :) and send at jira thanks! 2013/9/17 Alexander Barkov b...@mariadb.org mailto:b...@mariadb.org Hello Roberto, On 09/17/2013 06:38 PM, Roberto Spadim wrote: hi guys! one question, as a mariadb user... base64 will be exposed

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Alexander Barkov
Hi Monty, On 09/23/2013 07:16 PM, Michael Widenius wrote: Hi! Alexander == Alexander Barkov b...@mariadb.org writes: cut Should we allow not '=' padding in our decoder too? (I think it's best to always pad on encoding). cut Alexander Just checked PostgreSQL. They also pad on encode

Re: [Maria-developers] Review of base64.diff and german2.diff

2013-09-23 Thread Alexander Barkov
On 09/23/2013 09:25 PM, Roberto Spadim wrote: Sorry if i'm posting too much, it's my last post for this ... int base64_decode_max_arg_length() { #if (SIZEOF_INT == 8) return 0x7FFFLL; #else return 0x7FFF; #endif } Oops. Some remainders after moving from size_t to int

Re: [Maria-developers] regexp review

2013-09-30 Thread Alexander Barkov
Hi Sanja, Thanks for review. On 09/30/2013 11:00 AM, Oleksandr Byelkin wrote: Hi! Hi! Everything is OK. But there are some small issues: --- mysql-test/include/ctype_utf8mb4.inc 2010-03-05 08:17:19 + +++ mysql-test/include/ctype_utf8mb4.inc2013-09-26 14:02:17 + @@

Re: [Maria-developers] Thoughts on a variable to control high resolution temporal type format and rounding behavior?

2013-11-12 Thread Alexander Barkov
Hi Jeremy, On 11/12/2013 07:09 AM, Jeremy Cole wrote: Sergei, In the process of working through the bugs I've reported re. time formats and InnoDB storage formats we noted that there isn't currently any way to cause MariaDB to create a *new* Oracle MySQL 5.6-format TIMESTAMP/TIME/DATETIME

Re: [Maria-developers] Why local modifications to PCRE library?

2013-11-16 Thread Alexander Barkov
Hello Pavel, On 11/16/2013 11:11 AM, Pavel Ivanov wrote: Alexander, I see you've included the full source of PCRE library into MariaDB tree and even made some local modifications which are not included into PCRE upstream. Could you please explain why did you do that? Why not allow to build

Re: [Maria-developers] Why local modifications to PCRE library?

2013-11-16 Thread Alexander Barkov
On 11/16/2013 09:11 PM, Pavel Ivanov wrote: On Sat, Nov 16, 2013 at 2:39 AM, Alexander Barkov b...@mariadb.org wrote: I see you've included the full source of PCRE library into MariaDB tree and even made some local modifications which are not included into PCRE upstream. Could you please

Re: [Maria-developers] Why local modifications to PCRE library?

2013-11-16 Thread Alexander Barkov
Reindl, On 11/16/2013 10:46 PM, Reindl Harald wrote: Am 16.11.2013 19:39, schrieb Alexander Barkov: I'm not sure why bundling PCRE with some our fixes should be confusing. We bundle many libraries with our own fixes. Before the 10.0.5 release we've bundled the Henry Spenser's regex library

Re: [Maria-developers] Why local modifications to PCRE library?

2013-11-16 Thread Alexander Barkov
Reindl, On 11/16/2013 10:46 PM, Reindl Harald wrote: Am 16.11.2013 19:39, schrieb Alexander Barkov: I'm not sure why bundling PCRE with some our fixes should be confusing. We bundle many libraries with our own fixes. Before the 10.0.5 release we've bundled the Henry Spenser's regex library

Re: [Maria-developers] get is now a reserved word in mariadb 10 ?

2013-11-21 Thread Alexander Barkov
Hi Sergei, On 11/21/2013 03:51 PM, Sergei Golubchik wrote: Hi, Jocelyn! On Nov 21, Jocelyn Fournier wrote: Hi, I have a query with a column named get. i.e. SELECT get FROM my_table... It works perfectly in 5.5, but in 10.0.6 it fails : ERROR 1064 (42000): You have an error in your SQL

Re: [Maria-developers] Malformed XML in mysql-test/std_data/Index.xml added in revision 3873

2013-11-25 Thread Alexander Barkov
Jeremy, On 11/26/2013 01:50 AM, Jeremy Cole wrote: Bar, Regarding your change: http://bazaar.launchpad.net/~maria-captains/maria/10.0/revision/3873/mysql-test/std_data/Index.xml I was wondering if it's intentional that mysql-test/std_data/Index.xml now contains malformed XML. It wasn't

Re: [Maria-developers] Review request for a fix for MDEV-5506

2014-01-27 Thread Alexander Barkov
Hi Sergei, On 01/26/2014 11:23 PM, Sergei Golubchik wrote: Hi, Alexander! Few questions, see below. === modified file 'mysql-test/t/timezone2.test' --- mysql-test/t/timezone2.test 2013-08-08 08:58:28 + +++ mysql-test/t/timezone2.test 2014-01-23 10:34:46 + @@ -298,5 +298,11 @@

Re: [Maria-developers] Review request for a fix for MDEV-5506

2014-01-27 Thread Alexander Barkov
Hi Sergei, On 01/27/2014 05:52 PM, Sergei Golubchik wrote: Hi, Alexander! On Jan 27, Alexander Barkov wrote: On 01/26/2014 11:23 PM, Sergei Golubchik wrote: Okay, I understand what you did. But I don't understand why. What was the problem? Why there was a crash? - Item_func_make_set

[Maria-developers] FreeBSD compilation problems and a fix

2014-01-29 Thread Alexander Barkov
Hi guys, I just tried to compile 10.0 on FreeBSD-9.1 RELEASE and noticed two problems: 1. It printed this warning for every source file: /usr/include/sys/timeb.h:42:2: warning: #warning this file includes sys/timeb.h which is deprecated This diff fixes the problem: -#ifdef

[Maria-developers] buildbot for non ~maria-captains branches on launchpad

2014-01-29 Thread Alexander Barkov
Hello Daniel, Would it be possible to have buildbot watch branches which are on Launchpad, but which are outside of the /~maria-captains/ directory? For example: bzr+ssh://bazaar.launchpad.net/~mroonga/maria/mroonga/ ? Thanks. ___ Mailing list:

Re: [Maria-developers] FreeBSD compilation problems and a fix

2014-01-31 Thread Alexander Barkov
Hi Sergei, On 01/29/2014 06:22 PM, Sergei Golubchik wrote: Hi, Alexander! On Jan 29, Alexander Barkov wrote: I just tried to compile 10.0 on FreeBSD-9.1 RELEASE and noticed two problems: 1. It printed this warning for every source file: /usr/include/sys/timeb.h:42:2: warning: #warning

Re: [Maria-developers] buildbot for non ~maria-captains branches on launchpad

2014-01-31 Thread Alexander Barkov
Hi Daniel, On 01/31/2014 12:07 AM, Daniel Bartholomew wrote: On Wed, Jan 29, 2014 at 4:01 AM, Alexander Barkov b...@mariadb.org wrote: Would it be possible to have buildbot watch branches which are on Launchpad, but which are outside of the /~maria-captains/ directory? For example: bzr+ssh

Re: [Maria-developers] buildbot for non ~maria-captains branches on launchpad

2014-01-31 Thread Alexander Barkov
Hi Kristian, On 01/31/2014 11:18 AM, Kristian Nielsen wrote: Daniel Bartholomew db...@mariadb.com writes: On Wed, Jan 29, 2014 at 4:01 AM, Alexander Barkov b...@mariadb.org wrote: Would it be possible to have buildbot watch branches which are on Launchpad, but which are outside

[Maria-developers] Buildbot trees for spider and mroonga

2014-01-31 Thread Alexander Barkov
Hi Kentoku, Currently you use your own trees for Mroonga and Spider development, e.g. bzr+ssh://bazaar.launchpad.net/~mroonga/maria/mroonga/ Would you mind to move development into trees under ~maria-captains location, for example:

[Maria-developers] MDEV-5450 Assertion ... mysql_type_to_time_type(cached_field_type) == ltime.time_type' fails ...

2014-01-31 Thread Alexander Barkov
Hi Sergei, Please review a patch for mdev-5450. Thanks. === modified file 'mysql-test/r/func_time.result' --- mysql-test/r/func_time.result 2013-12-19 08:39:40 + +++ mysql-test/r/func_time.result 2014-01-31 12:58:42 + @@ -2382,3 +2382,60 @@ Catalog Database Table Table_alias Colum def

Re: [Maria-developers] MDEV-5450 Assertion ... mysql_type_to_time_type(cached_field_type) == ltime.time_type' fails ...

2014-02-03 Thread Alexander Barkov
be back ported to 5.5 or 5.3. On Jan 31, Alexander Barkov wrote: Hi Sergei, Please review a patch for mdev-5450. Thanks. === modified file 'sql/item_timefunc.cc' --- sql/item_timefunc.cc2013-12-16 12:02:21 + +++ sql/item_timefunc.cc2014-01-31 12:35:17 + @@ -1480,12

Re: [Maria-developers] MDEV-5450 Assertion ... mysql_type_to_time_type(cached_field_type) == ltime.time_type' fails ...

2014-02-03 Thread Alexander Barkov
On 02/03/2014 07:51 PM, Alexander Barkov wrote: Hi Sergei, On 02/03/2014 07:44 PM, Sergei Golubchik wrote: Hi, Alexander! Ah, so at the end you've decided to fix the type, not the assert. Fine. Ok to push. There were two problems actually: - the type - the assert I fixed both. Sorry

Re: [Maria-developers] Buildbot trees for spider and mroonga

2014-02-10 Thread Alexander Barkov
just made lp:~maria-captains/maria/10.0-mroonga. lp:~maria-captains/maria/10.0-spider is already made by Sergey. May I use this? Yes, please use these trees. Thanks. Thanks, Kentoku 2014/1/31 Alexander Barkov b...@mariadb.org: Hi Kentoku, Currently you use your own trees for Mroonga

[Maria-developers] Buildbot: 10.0-mroonga and 10.0-spider

2014-02-10 Thread Alexander Barkov
Hello Daniel, Kristian, Sergei, Can you please add 10.0-mroonga and 10.0-spider into BuildBot? Thanks. ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe :

Re: [Maria-developers] Buildbot: 10.0-mroonga and 10.0-spider

2014-02-18 Thread Alexander Barkov
Hello, On 02/10/2014 12:53 PM, Alexander Barkov wrote: Hello Daniel, Kristian, Sergei, Can you please add 10.0-mroonga and 10.0-spider into BuildBot? Did anyone have a chance to do this? Thanks. Thanks. ___ Mailing list: https

[Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-02-20 Thread Alexander Barkov
Hi Sergei, please review a fix for MDEV-5689. It also fixes MDEV-5709 ExtractValue() with XPath variable references returns wrong result. Description: 1. The main problem was that that nodeset_func-fix_fields() was called in Item_func_xml_extractvalue::val_str() and

[Maria-developers] Standard way for time-datetime cast

2014-03-04 Thread Alexander Barkov
Hi Sergei, (my mailer failed during the previous attempt. writing again, sorry if you get this twice) Please review the patch implementing the standard (and MySQL-5.6) compatible way of time to datetime conversion. Thanks. === modified file 'include/my_time.h' --- include/my_time.h 2014-02-19

Re: [Maria-developers] [JIRA] (MDEV-5497) Test suite test connect.fix fails

2014-03-05 Thread Alexander Barkov
Hello Olivier, You changed status to fixed, but I cannot see any fixes in 10.0-connect. Are you going to push a fix soon? Thanks. On 03/05/2014 03:36 PM, Olivier Bertrand (JIRA) wrote: [

Re: [Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-03-19 Thread Alexander Barkov
Hi Sergei, Thanks for review. Please see my comments inline: On 03/19/2014 12:03 AM, Sergei Golubchik wrote: Hi, Alexander! On Feb 20, Alexander Barkov wrote: please review a fix for MDEV-5689. It also fixes MDEV-5709 ExtractValue() with XPath variable references returns wrong result

[Maria-developers] valgrind failures in ConnectSE

2014-03-23 Thread Alexander Barkov
Hi Olivier, Valgrind complains about uninitialized memory read: http://buildbot.askmonty.org/buildbot/builders/work-amd64-valgrind/builds/5283/steps/test/logs/stdio It seems the problem was introduced by this change:

[Maria-developers] connect.alter fails

2014-03-23 Thread Alexander Barkov
Hello Olivier, connect.alter fails when built without XML support complaining about unsupported table type XML. I guess it should be skipped. connect.alter also fails with libxml2 with these symptoms: ---

Re: [Maria-developers] A fix for MDEV-5689 ExtractValue(xml, 'substring(/x, /y)') crashes

2014-03-23 Thread Alexander Barkov
Hi Sergei, On 03/20/2014 12:04 PM, Sergei Golubchik wrote: Hi, Alexander! On Mar 20, Alexander Barkov wrote: On 03/19/2014 12:03 AM, Sergei Golubchik wrote: On Feb 20, Alexander Barkov wrote: please review a fix for MDEV-5689. It also fixes MDEV-5709 ExtractValue() with XPath variable

[Maria-developers] A joint patch for MDEV-5969 and MDEV-5971

2014-03-28 Thread Alexander Barkov
Hello, please review a joint patch fixing a crashing bug MDEV-5969, together with a non-crashing bug MDEV-5971. Thanks. === modified file 'mysql-test/r/temporal_literal.result' --- mysql-test/r/temporal_literal.result 2014-03-06 20:21:25 + +++ mysql-test/r/temporal_literal.result 2014-03-28

[Maria-developers] TIME/DATETIME/TIMESTAMP data types with fractional precision

2014-04-01 Thread Alexander Barkov
Hello, I propose to switch to MySQL-5.6 TIME/DATETIME/TIMESTAMP formats by default and deprecate MariaDB native temporal data types, together with pre-5.6 non-fractional types. The problem is that MariaDB native data types (and MySQL-5.5 non-fractional data types) do not work with row based

[Maria-developers] mdev6027 RLIKE: . no longer matching new line (default_regex_flags)

2014-04-17 Thread Alexander Barkov
Hello Serg, Please review a patch implementing a new system variable default_regex_flags, to address the remaining incompatibilities between PCRE and the old regex library. Greetings. === modified file 'mysql-test/r/func_regexp_pcre.result' --- mysql-test/r/func_regexp_pcre.result 2013-10-08

Re: [Maria-developers] mdev6027 RLIKE: . no longer matching new line (default_regex_flags)

2014-04-23 Thread Alexander Barkov
Hi Jan, Sergei, On 04/23/2014 11:25 AM, Sergei Golubchik wrote: Hi, Alexander! On Apr 22, Sergei Golubchik wrote: On Apr 17, Alexander Barkov wrote: Hello Serg, Please review a patch implementing a new system variable default_regex_flags, to address the remaining incompatibilities between

Re: [Maria-developers] mdev6027 RLIKE: . no longer matching new line (default_regex_flags)

2014-04-23 Thread Alexander Barkov
On 04/23/2014 11:44 AM, Ian Gilfillan wrote: On 23/04/2014 09:28, Alexander Barkov wrote: Jan, can you please update the manual? Sure, will do. Thanks for the detailed writeup. Which release is this variable scheduled to be included in? It's Ian, not Jan btw, although all comes from one

[Maria-developers] SELECT ... LIMIT 0 is now deterministic

2014-04-28 Thread Alexander Barkov
Hello Ian, A fix for MDEV-6170 fixed another problem as a side effect: SELECT ... LIMIT 0 is now deterministic for statement based binary log. Queries with LIMIT 0 do not return ER_BINLOG_UNSAFE_STATEMENT any more. Can you please mention this in the manual? Some discussion is here:

[Maria-developers] Barkov: report for the week starting Apr 29, 2014

2014-05-05 Thread Alexander Barkov
Apr 28 - May 04 === Apr 28 Apr 29 Apr 30 May 01 Holiday May 02 Holiday May 03 Weekend May 04 Weekend Vacation days taken: 10/35 - MDEV-5702 Incorrect results are returned with NULLIF() Pushed into 5.5 - MDEV-5459 Illegal mix of collations for datetime Pushed into 5.5 -

Re: [Maria-developers] Please review a patch fixing a few MDEV-6001 blockers

2014-05-05 Thread Alexander Barkov
Hi Sergei, Thanks for review. Please find my comments inline: On 04/30/2014 10:49 PM, Sergei Golubchik wrote: Hi, Alexander! On Apr 15, Alexander Barkov wrote: Hi Sergei, can you please review my patch fixing a few bugs that are blockers for MDEV-6001? - MDEV-4858 Wrong results for a huge

[Maria-developers] BuildBot for 10.0-connect [Was: connect.alter fails]

2014-05-06 Thread Alexander Barkov
Hello Daniel, There are problems with the 10.0-connect tree. Please fix. On 05/05/2014 08:03 PM, Olivier Bertrand wrote: Le 23/03/2014 08:53, Alexander Barkov a écrit : Hello Olivier, connect.alter fails when built without XML support complaining about unsupported table type XML. I guess

Re: [Maria-developers] BuildBot for 10.0-connect [Was: connect.alter fails]

2014-05-07 Thread Alexander Barkov
Thanks Daniel! On 05/07/2014 05:53 PM, Daniel Bartholomew wrote: On Wed, May 7, 2014 at 1:16 AM, Alexander Barkov b...@mariadb.org wrote: There are problems with the 10.0-connect tree. Same issue that we seem to be running into whenever a branch gets a big merge or push (Updating branch

Re: [Maria-developers] Regarding debugging MariaDB

2014-05-17 Thread Alexander Barkov
Hi Sriram, On 05/17/2014 10:00 AM, sriram patil wrote: Hi Alexander, I wanted to run mysqld in debug mode to check the trace file and get to know workflow of SQL commands. I tried following command mysqld --user=username --debug Then, after connecting I executed some commands. But, the

[Maria-developers] FOR JSON

2014-05-17 Thread Alexander Barkov
Hello Monty, We discussed extracting data in JSON format today, to make it possible to return data as a single JSON value (as a result set consisting of a single row and a single column): SELECT id,name,address FROM users FOR JSON; Note, in some cases the result of a such query can obviously

Re: [Maria-developers] CREATE OR REPLACE DATABASE algorithm

2014-05-23 Thread Alexander Barkov
Hi Sriram, On 05/22/2014 09:00 AM, sriram patil wrote: Hi Alexander and all, Following are the steps that I am following for implementing CREATE OR REPLACE for DATABASE ... signifies, there exists one or more lines of code in that block of the function. mysql_create_db(...) ... ...

Re: [Maria-developers] Getting started with the coding.

2014-05-23 Thread Alexander Barkov
Hello Sriram, On 05/21/2014 07:47 AM, sriram patil wrote: Hi Alexander, I have started working on CREATE OR REPLACE DATABASE implementation. I thought this one has the least complexity among all the other commands. I am getting my hand-on debugging the source code too. I have made the

Re: [Maria-developers] FOR JSON

2014-05-26 Thread Alexander Barkov
Hello Sergei, On 05/25/2014 08:10 PM, Sergei Golubchik wrote: Hi, Alexander! On May 17, Alexander Barkov wrote: Hello Monty, We discussed extracting data in JSON format today, to make it possible to return data as a single JSON value (as a result set consisting of a single row and a single

Re: [Maria-developers] FOR JSON

2014-05-26 Thread Alexander Barkov
Hi Sergei, On 05/26/2014 04:48 PM, Sergei Golubchik wrote: skip Yes, it's a detail. My point was that we shouldn't have two implementations for the same feature (arbitrary transformation of the query result). So either we reuse the code for procedures, or we do a new implementation and move

[Maria-developers] CREATE OR REPLACE OBJECT

2014-05-27 Thread Alexander Barkov
Hi Sriram, I just updated https://mariadb.atlassian.net/browse/MDEV-5359; with details on how various CREATE OR REPLACE... should work. The important part is to make them atomic (all or nothing). Please have a look. Thanks. ___ Mailing list:

Re: [Maria-developers] Please review a patch fixing a few MDEV-6001 blockers

2014-05-29 Thread Alexander Barkov
Hello Sergei, Thanks for review. Please see my replies below: On 05/28/2014 09:17 PM, Sergei Golubchik wrote: Hi, Alexander! On May 05, Alexander Barkov wrote: === modified file 'mysql-test/r/cast.result' --- mysql-test/r/cast.result2014-03-26 21:25:38 + +++ mysql-test/r/cast.result

[Maria-developers] MDEV-4051 INET6_ATON() and INET6_NTOA()

2014-05-30 Thread Alexander Barkov
Hello Ian, I have merged these functions from MySQL-5.6 into 10.0: INET6_ATON() INET6_NTOA() IS_IPV4() IS_IPV4_COMPAT() IS_IPV4_MAPPED() IS_IPV6() Can you please document them? The corresponding article in the MySQL manual is here:

Re: [Maria-developers] MDEV-4051 INET6_ATON() and INET6_NTOA()

2014-06-01 Thread Alexander Barkov
this. I've changed the version to 10.0.12. thanks, ian On 30/05/2014 14:28, Alexander Barkov wrote: Hello Ian, I have merged these functions from MySQL-5.6 into 10.0: INET6_ATON() INET6_NTOA() IS_IPV4() IS_IPV4_COMPAT() IS_IPV4_MAPPED() IS_IPV6() Can you please

Re: [Maria-developers] Please review a patch fixing a few MDEV-6001 blockers

2014-06-02 Thread Alexander Barkov
Hi Sergei, On 06/02/2014 06:01 PM, Sergei Golubchik wrote: Hi, Alexander! On Jun 02, Alexander Barkov wrote: Hello Sergei, Please find a new version of the patch that addresses your review suggestions. Also, see comments inline. Thanks. It looks like you've mistakenly attached the first

[Maria-developers] Review request[major 5.3/5.5 bug]: MDEV-4511 Assertion `scale = precision' fails on GROUP BY TIMEDIFF with incorrect types, , Agile Board, , Export

2014-06-03 Thread Alexander Barkov
Hello Sergei, A few weeks ago we fixed this bug for 10.0 by changing temporal items not to have decimals=NOT_FIXED_DEC (more MySQL-5.6 compatibility), and agreed to have a separate patch for the pre-10.0 branches. This patch is for 5.3 and 5.5 only. It back-ports the mdev-4511 tests from

Re: [Maria-developers] Please review a patch fixing a few MDEV-6001 blockers

2014-06-03 Thread Alexander Barkov
Hi Sergei, On 06/02/2014 07:10 PM, Sergei Golubchik wrote: Hi, Alexander! Looks ok to push, thanks! Thanks for review! One minor comment below. an answer to your comment below: On Jun 02, Alexander Barkov wrote: === modified file 'sql/field.h' --- sql/field.h 2014-03-26 21:25:38

[Maria-developers] MDEV-4511 Assertion `scale = precision' fails on GROUP BY TIMEDIFF with incorrect types

2014-06-09 Thread Alexander Barkov
Hello Sergei, Please review a new version of the patch for MDEV-4511, it also fixes more crashing problems found, as well as non-crashing problems reported in MDEV-6302 I removed find_num_type() and fix_num_length_and_dec() which were hard to track, and for some Items these methods were

Re: [Maria-developers] [GSoC] Week Four!

2014-06-18 Thread Alexander Barkov
Hi Sriram, On 06/18/2014 10:21 AM, sriram patil wrote: Hi All, Sorry for a little delay in posting the blog link this week. Following is the blog link about my fourth week into GSoC. http://goo.gl/W54cvE Suggestions and/or reviews are welcome! Thanks! Keep up the good work! Thanks,

Re: [Maria-developers] [GSoC] Week Six!

2014-06-30 Thread Alexander Barkov
Hi Sriram, On 06/30/2014 08:27 AM, sriram patil wrote: Hi all, Following is the blog link about my sixth week into GSoC. http://goo.gl/1dzgHe Suggestions and/or reviews are welcome! As a mentor I'm very happy about your performance and self-motivation! Keep on doing the great job!

[Maria-developers] please review mdev-5745 analyze MySQL fix for bug#12368495

2014-07-23 Thread Alexander Barkov
Hi Serg, please review a patch for mdev-5745. Thanks. === modified file 'mysql-test/r/ctype_ucs.result' --- mysql-test/r/ctype_ucs.result 2014-04-28 11:56:31 + +++ mysql-test/r/ctype_ucs.result 2014-07-23 15:08:56 + @@ -4277,5 +4277,38 @@ COALESCE(c1) DROP TABLE t1; # +# MDEV-5745

Re: [Maria-developers] MDEV-4511 Assertion `scale = precision' fails on GROUP BY TIMEDIFF with incorrect types

2014-07-23 Thread Alexander Barkov
Hello Sergei, On 07/23/2014 08:50 PM, Sergei Golubchik wrote: Hi, Alexander! I removed find_num_type() and fix_num_length_and_dec() which were hard to track, and for some Items these methods were erroneously called twice. fix_num_length_and_dec() now only exists as a non-virtual method in

[Maria-developers] merge 10.0-connect - 10.0

2014-07-29 Thread Alexander Barkov
Hello Olivier, I tried to merge 10.0-connect into the main 10.0, but two mtr tests failed in the merged tree. Note, they don't fail in 10.0-connect, so I guess something have changed in the main tree which makes your latest changes in 10.0-connect incompatible. Please find the log attached. I

[Maria-developers] Performance: question about strings created in sql_lex.cc

2014-07-29 Thread Alexander Barkov
Hello, When parsing an SQL query, the function get_text() in sql_lex.cc always makes a copy of the string, allocating new memory using lip-m_thd-alloc() and copying the original string from the SQL query fragment to this new memory. Note, this happens even if the string does not have any

Re: [Maria-developers] [GSoC] Week Twelve!

2014-08-13 Thread Alexander Barkov
Hello Sriram, On 08/11/2014 09:13 AM, sriram patil wrote: Hi All, Following is the link to my twelfth weeks blog post. http://goo.gl/Zkr86e Suggestions and/or reviews are welcome! Very nice replication tests. Also, it's very good that you reduced some duplicate code by introducing a

Re: [Maria-developers] [GSoC] Pencils down

2014-08-20 Thread Alexander Barkov
Hi Sriram, On 08/20/2014 09:14 AM, sriram patil wrote: Hi All, Following is the link to my pencils down blog post. You can go through it even if you have not followed my blog posts before. http://goo.gl/DqBgDe Thanks a lot for all your feedback and suggestions. Thank you very much that

[Maria-developers] Please review: 10% performance improvement for INSERT INTO t1 (blob) VALUES ('long value')

2014-08-26 Thread Alexander Barkov
Hi, I think I found and fixed a bottleneck in how string literals are processed. The attached patch improves INSERT performance for strings, and especially for long blob and text values. Insertion time for 10MByte blob 1024 times (10GByte of data total) reduced on my laptop from 300 seconds

Re: [Maria-developers] Please review: MDEV-5528 Command line variable to choose MariaDB-5.3 vs MySQL-5.6 temporal data formats

2014-08-29 Thread Alexander Barkov
Hi, Forgot to mention: I have some doubts about the changed order of records in mysql-test/r/distinct.result. Please suggest if it's fine. Thanks. On 08/29/2014 02:53 PM, Alexander Barkov wrote: Hi, Please review my patch for MDEV-5528. It also fixes a bug: MDEV-6649 Different

Re: [Maria-developers] INET6, data type plugins

2014-10-09 Thread Alexander Barkov
Hi Sergei, Thanks for review. Sorry for delay with this. I've been busy with the other tasks. I won't reply to every your comment in this letter. I skip all comments that I agree with, and those that I need some time to think. Only some critical and unclear follow below: On 08/10/2014

[Maria-developers] Fwd: [JIRA] (MDEV-6566) Different INSERT behaviour on bad bytes with and without character set conversion

2014-10-10 Thread Alexander Barkov
Issue Type: Bug Affects Versions: 5.3.12, 5.5.39, 10.0.13 Reporter: Alexander Barkov Assignee: Alexander Barkov Fix For: 10.0.15, 5.5.41 If I run this SQL script in a utf8 client: {noformat} SET NAMES utf8; DROP TABLE IF EXISTS t1; CREATE TABLE t1

Re: [Maria-developers] Please review: MDEV-5528 Command line variable to choose MariaDB-5.3 vs MySQL-5.6 temporal data formats

2014-10-20 Thread Alexander Barkov
Hi Sergei, Thanks for review. My comments go inline: On 10/17/2014 07:29 PM, Sergei Golubchik wrote: Hi, Alexander! Thanks! The patch is pretty much ok. There are only few comments/questions, see below. On Aug 29, Alexander Barkov wrote: Hi, Please review my patch for MDEV-5528

Re: [Maria-developers] Please review: MDEV-5528 Command line variable to choose MariaDB-5.3 vs MySQL-5.6 temporal data formats

2014-10-22 Thread Alexander Barkov
Hi Sergei, This is the update about MDEV-5528. On 10/20/2014 12:54 PM, Sergei Golubchik wrote: skip === modified file 'mysql-test/suite/innodb/r/data_types.result' --- mysql-test/suite/innodb/r/data_types.result 2013-11-13 21:58:19 + +++ mysql-test/suite/innodb/r/data_types.result

Re: [Maria-developers] Please review: MDEV-5528 Command line variable to choose MariaDB-5.3 vs MySQL-5.6 temporal data formats

2014-10-23 Thread Alexander Barkov
Hi Sergei, On 10/23/2014 02:48 PM, Sergei Golubchik wrote: Hi, Alexander! On Oct 22, Alexander Barkov wrote: Also, while experimenting, I noticed that InnoDB complains to stderr about unexpected format for innodb_table_stats.last_update. I had to add these lines into scripts

[Maria-developers] DATE and GROUP_MIN_MAX optimization

2014-10-28 Thread Alexander Barkov
Hello Sergey, I'm working on pluggable data types and moving some pieces of the code into new classes for data type handlers. I noticed that GROUP_MIN_MAX optimization works fine with a TIME column with temporal and string literals but does not work for an integer literal: # This script

[Maria-developers] PLEASE REVIEWA: pre-requisite patch for the data type plugins, also fixing a number of optimizer bugs

2014-11-03 Thread Alexander Barkov
Hello, While working on pluggable data types, I noticed a few problems related to optimizer: MDEV-6950 Bad results with joins comparing DATE/DATETIME and INT/DECIMAL/DOUBLE/ENUM/VARCHAR columns MDEV-6971 Bad results with joins comparing TIME and DOUBLE/DECIMAL columns MDEV-6978 Bad results

[Maria-developers] nginx sources in mroonga

2014-11-03 Thread Alexander Barkov
Hi Kentoku, Sergei Golubchik is asking why we have complete nginx sources inside mroonga? Can you remove them please? Thanks. ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe :

Re: [Maria-developers] nginx sources in mroonga

2014-11-03 Thread Alexander Barkov
+09:00 Alexander Barkov b...@mnogosearch.org: Hi Kentoku, Sergei Golubchik is asking why we have complete nginx sources inside mroonga? Can you remove them please? Thanks. ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria

[Maria-developers] MDEV-5528 Command line variable to choose MariaDB-5.3 vs MySQL-5.6 temporal data formats

2014-11-03 Thread Alexander Barkov
Hello Ian, I've pushed MDEV-5528 into 10.1. I guess it will need some documenting. Can you please have a look? Thanks. ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe :

[Maria-developers] Please review: sql_yacc.yy and HA_CREATE_INFO refactoring (pre-requisite for MDEV-5359 CREATE OR REPLACE, CREATE IF NOT EXISTS, DROP IF EXISTS)

2014-11-10 Thread Alexander Barkov
Hi Sergei, The patch is attached. Thanks. diff --git a/sql/handler.h b/sql/handler.h index 0044556..7b6a5f4 100644 --- a/sql/handler.h +++ b/sql/handler.h @@ -376,10 +376,7 @@ enum enum_alter_inplace_result { #define HA_KEY_BLOB_LENGTH 2 #define HA_LEX_CREATE_TMP_TABLE 1 -#define

Re: [Maria-developers] PLEASE REVIEWA: pre-requisite patch for the data type plugins, also fixing a number of optimizer bugs

2014-11-12 Thread Alexander Barkov
Hello Sergei, On 11/12/2014 01:28 PM, Sergei Golubchik wrote: Hi, Alexander! On Nov 03, Alexander Barkov wrote: Hello, While working on pluggable data types, I noticed a few problems related to optimizer: MDEV-6950 Bad results with joins comparing DATE/DATETIME and INT/DECIMAL/DOUBLE

[Maria-developers] Mroonga: wrapper.version_56_or_later_performance_schema is failing on BuildBot

2014-11-12 Thread Alexander Barkov
Hello Kentoku, This test is failing in the latest builds on BB: mroonga/wrapper.version_56_or_later_performance_schema http://buildbot.askmonty.org/buildbot/builders/bld-dan-release/builds/1793/steps/test/logs/stdio Can you please check it? Thanks.

Re: [Maria-developers] [JIRA] (MDEV-7076) Build fails around libgroonga on some platforms in buildbot

2014-11-12 Thread Alexander Barkov
Hello Kentoku, Mroonga fails to compile on some platforms. Can you please have a look? Thanks. On 11/12/2014 04:39 PM, Alexander Barkov (JIRA) wrote: [ https://mariadb.atlassian.net/browse/MDEV-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander

[Maria-developers] Review: [MDEV-7062] parser refactoring: don't store field properties in LEX

2014-11-13 Thread Alexander Barkov
Hi Sergei, Sergei Golubchik edited comment on MDEV-7062 at 11/10/14 11:40 AM: --- http://lists.askmonty.org/pipermail/commits/2014-November/006908.html {noformat} From: s...@mariadb.org To: comm...@mariadb.org Subject:

Re: [Maria-developers] Please review: sql_yacc.yy and HA_CREATE_INFO refactoring (pre-requisite for MDEV-5359 CREATE OR REPLACE, CREATE IF NOT EXISTS, DROP IF EXISTS)

2014-11-13 Thread Alexander Barkov
Hi Sergei, I created a standalone JIRA task for this: MDEV-7112 Split HA_CREATE_INFO and assigned it to you, for review. Thanks. On 11/10/2014 02:27 PM, Alexander Barkov wrote: Hi Sergei, The patch is attached. Thanks. ___ Mailing list

Re: [Maria-developers] Review: [MDEV-7062] parser refactoring: don't store field properties in LEX

2014-11-15 Thread Alexander Barkov
Hi Sergei, On 11/16/2014 02:30 AM, Sergei Golubchik wrote: Hi, Alexander! On Nov 13, Alexander Barkov wrote: [Commits] 2c904b9: parser cleanup: don't store field properties in LEX, use Create_field directly serg at mariadb.org serg at mariadb.org Mon Nov 10 11:26:48 EET 2014 Previous

  1   2   3   4   5   6   >