Hi Varun,
On Tue, Dec 6, 2016 at 9:34 AM, Varun wrote:
> revision-id: f79d9d454bc3fa6fecb34fec850752a688c0ccc7
> (mariadb-10.0.28-17-gf79d9d4)
> parent(s): e0c631905cd923257331ef124a2bc9276e0d
> author: Varun
> committer: Varun
> timestamp: 2016-12-06 19:48:58 +0530
> message:
>
> [MDEV]-111
Hi Sachin,
I see that you have added a lot of warnings to the suite-level suppression
list.
Does *all* the new warnings show up for all the tests?
I'd only add ones that make sense for the entire suite, and add the
individuals
to the specific test by calling mtr.add_suppression("").
Ping me on s
Hi Bar,
The patch is ok to push.
Perhaps a similar virtual method to
disintegrate Item_type_holder::get_real_type()?
Best,
Nirbhay
On Tue, Dec 13, 2016 at 8:03 AM, Alexander Barkov wrote:
> Hello Nirbhay,
>
> Can you please review a patch for MDEV-11558?
>
> Thanks!
>
_
Hi Bar,
On Tue, Jan 10, 2017 at 2:41 AM, Alexander Barkov wrote:
> Hello Nirbhay,
>
> On 01/09/2017 09:48 PM, Nirbhay Choubey wrote:
> > Hi Bar,
> >
> > On Mon, Jan 9, 2017 at 1:00 AM, Alexander Barkov > <mailto:b...@mariadb.org>> wrote:
> >
>
Hi Sachin,
The overall patch looks ok. I, however, have a few minor comments inline.
On Thu, Jan 19, 2017 at 1:21 AM, SachinSetiya
wrote:
> revision-id: 98b2a9c967a5eaa1f99bb3ef229ff2af62018ffe
> (mariadb-10.0.28-34-g98b2a9c)
> parent(s): 9bf92706d19761722b46d66a671734466cb6e98e
> author: Sach
Hi Sachin,
On Fri, Jan 20, 2017 at 3:04 AM, Sachin Setiya
wrote:
> Hi Nirbhay!
>
> On Fri, Jan 20, 2017 at 7:09 AM, Nirbhay Choubey
> wrote:
>
>> Hi Sachin,
>>
>> The overall patch looks ok. I, however, have a few minor comments inline.
>>
>>
>
Hi Sachin,
My comments below.
On Sun, Jan 22, 2017 at 7:18 AM, SachinSetiya
wrote:
> revision-id: d1124c98cbede6366e4b4d27a23dcf5b9d207cf0
> (mariadb-10.1.21-2-gd1124c9)
> parent(s): a14638581b4c8ef175e68dccff07967d819b3b7e
> author: Sachin Setiya
> committer: Sachin Setiya
> timestamp: 2017-01
Hi Sachin!
On Fri, Jan 27, 2017 at 12:53 AM, SachinSetiya
wrote:
> revision-id: d44c14e1e0dea312779ba0a8633583ee94284295
> (mariadb-10.1.21-2-gd44c14e)
> parent(s): a14638581b4c8ef175e68dccff07967d819b3b7e
> author: Sachin Setiya
> committer: Sachin Setiya
> timestamp: 2017-01-27 11:23:17 +0530
Hi Sachin,
On Wed, Jan 25, 2017 at 1:17 AM, Sachin Setiya
wrote:
> Hi Nirbhay!
>
> On Tue, Jan 24, 2017 at 8:02 AM, Nirbhay Choubey
> wrote:
> >
> > revision-id: 5190ebde3aa142219e1c703df6ea1a78f171182c
> (mariadb-10.1.21-7-g5190ebd)
> > parent(s): 15f46d5
Hi Sachin,
On Mon, Jan 30, 2017 at 12:10 AM, Sachin Setiya
wrote:
> HI Nirbhay!
>
> On Sun, Jan 29, 2017 at 11:42 PM, Nirbhay Choubey
> wrote:
> > Hi Sachin!
> >
> > On Fri, Jan 27, 2017 at 12:53 AM, SachinSetiya <
> sachin.set...@mariadb.c
Hi!
On Mon, Sep 15, 2014 at 10:09 AM, Kristian Nielsen wrote:
> Kristian Nielsen writes:
>
> > 4. Also see detailed comments for some possible problems with the
> > implementation. The most serious is probably to ensure that events are
> not
> > skipped after the end of the group, we need a cou
Hi Kristian!
Thank you for the review remarks. I have committed a patch addressing your
comments.
http://lists.askmonty.org/pipermail/commits/2014-October/006775.html
See inline for my response on specific comments.
On Mon, Sep 15, 2014 at 9:25 AM, Kristian Nielsen
wrote:
> Nirbhay Chou
Hi Kristian,
On Fri, Oct 17, 2014 at 5:53 AM, Kristian Nielsen
wrote:
> Nirbhay Choubey writes:
>
> > message:
> > Fix for test failures on 64-bit platform.
> > === modified file 'sql/rpl_mi.cc'
> > --- a/sql/rpl_mi.cc 2014-10-10 23:06:40 +
>
Hi!
On Mon, Oct 27, 2014 at 9:12 AM, Kristian Nielsen
wrote:
> Nirbhay Choubey writes:
>
> > [NC] You are right, setting both DO_ and IGNORE_ at the same time would
> not
> > make any sense.
> > But I actually followed the pattern of the existing replication, where
&
Hi!
On Fri, Nov 14, 2014 at 3:58 AM, Kristian Nielsen
wrote:
> Nirbhay Choubey writes:
>
> >> > # Case 7: Stop slave into the middle of a transaction being
> filtered
> >> and
> >> > # start it back with filtering disabled.
> >
Hi Serg,
On Sat, Nov 29, 2014 at 1:54 PM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On Nov 28, nirb...@mariadb.com wrote:
> > revision-id: 7a5559421f4f3dda44d04bf946e79661d09b4dc2
> > parent(s): 7b55b67de5fdfe91283357fe6c7ccc3f9e355925
> > committer: Nirbhay Cho
Hi Kristian,
On Mon, Feb 2, 2015 at 5:06 AM, Kristian Nielsen
wrote:
> nirb...@mariadb.com writes:
>
> > revision-id: 101d7eb963816514362da8a98fc7db7135181910
> > committer: Nirbhay Choubey
> > timestamp: 2015-01-31 21:48:14 -0500
> > message:
> >
> >
Hi Andy!
On Thu, Mar 5, 2015 at 2:27 PM, Andrew W Elble wrote:
>
> Environment:
> MariaDB-10.0.16
> Galera-3-25.3.9
>
> This statement does nasty things to a MariaDB+Galera cluster:
>
> CREATE TABLE u91rw_zoo_version (`version` varchar(255) NOT NULL)
>ENGINE=innoD
On Sun, Mar 15, 2015 at 7:48 AM, Richa Sehgal
wrote:
> Dear Sergei and Maria community,
>
> Finally I have settled on one project: Indexing over virtual columns.
>
> I spent the entire day today trying to compile MariaDB in Ubuntu and
> reading the code. On reading code side, I spent some time in
Hi Serg,
On Thu, Mar 19, 2015 at 8:02 AM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On Mar 17, Nirbhay Choubey wrote:
> > revision-id: 1cda762d3f1132e6696e1c451435746db0a1420a
> > parent(s): b0542b78c866fb32383f759914b10f060d0e14cd
> > committer: Nirbhay Chou
stem_mysql_db_fix50117 test.
Best,
Nirbhay
>
>
> -- Peter
>
> On Thu, Mar 19, 2015 at 1:35 PM, Nirbhay Choubey
> wrote:
>
>> Hi Serg,
>>
>> On Thu, Mar 19, 2015 at 8:02 AM, Sergei Golubchik
>> wrote:
>>
>>> Hi, Nirbhay!
>>>
Hi Andrew!
On Wed, Apr 15, 2015 at 11:45 AM, Andrew W Elble wrote:
>
> Nirbhay,
>
>We've been poking at this some more. Seems like we're retracing some
>steps as documented here:
>
>https://bugs.launchpad.net/codership-mysql/+bug/1052002
>
>My patch will need to be reverted and r
Hi Andy!
On Fri, Apr 24, 2015 at 3:27 PM, Andrew W Elble wrote:
>
> Nirbhay,
>
> I'm going to have a number of patches/suggestions from chasing
> this. Hopefully I'll have them in a consumable fashion soon.
> Is it preferred to send them all to the list?
>
Great! Will it be possible for you
Hi Serg,
On Thu, May 7, 2015 at 4:27 AM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On Apr 08, Nirbhay Choubey wrote:
> > revision-id: 845edb6259559bed39eb7365860aa5d588990775
> > parent(s): 3674c363a7e77e534c3e0d28659dc614c53fbcbc
> > committer: Nirbhay Choubey
Hi Serg,
On Thu, May 28, 2015 at 5:56 PM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On May 09, Nirbhay Choubey wrote:
> > revision-id: 8928497acbe3e17a105897f405d5e5138d57a249
> > parent(s): 3674c363a7e77e534c3e0d28659dc614c53fbcbc
> > committer: Nirbhay Choubey
Hi Serg,
On Mon, Jun 8, 2015 at 11:07 AM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On Jun 02, Nirbhay Choubey wrote:
> > revision-id: 1ed46831ed3a1c842b45f7819edd48a233080ce4
> > parent(s): 6d5b723bdc3e04978619b9673fca266e0426916f
> > committer: Nirbhay Ch
Hi Serg!
On Tue, Jun 9, 2015 at 1:24 AM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On Jun 08, Nirbhay Choubey wrote:
> > revision-id: 7948cc32b6c12c9696e8b497ae90f123cafcd234
> > parent(s): 6d5b723bdc3e04978619b9673fca266e0426916f
> > committer: Nirbhay Ch
Hi!
On Wed, Jun 10, 2015 at 5:40 AM, Sylvain Raybaud <
sylvain.rayb...@green-communications.fr> wrote:
>
> I built mariadb galera cluster 10.0.17 from source. Starting it with
> mysql_safe fails with: Can't find messagefile
> '/usr/share/mysql/errmsg.sys'
>
Did you try setting --basedir= ?
> T
it to reflect any change
related to this.
Thanks!
-- Nirbhay
>
>
> - On 18 Jun, 2015, at 11:59 PM, Nirbhay Choubey nirb...@mariadb.com
> wrote:
>
> > revision-id: 6050ab658696925f2a031b901eb398fff65fa92a
> > parent(s): 9eff9ed5c58e782abf383a52a7e691a55b4798a2
&
Hi Serg,
On Wed, Jun 24, 2015 at 2:59 PM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On Jun 24, Nirbhay Choubey wrote:
> > revision-id: aff560696cac5e081d19f4460ccd9c906ddc9d84
> > parent(s): 70714d3597ec9ffa742cc9e173d4ad32f294cc51
> > committer: Nirbhay Ch
Hi Serg, Svoj!
I am looking into an issue where accessing oqgraph/connect engines from
galera server
leads to errors like "Unknown option ''" and segfaults. The
issue being the
differences in handlerton structure in galera and non-galera server codes.
Since the connect/oqgraph packages are built
Hi Serg,
Thanks for the review. My comments inline.
On Sat, Sep 12, 2015 at 7:12 AM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On Aug 19, Nirbhay Choubey wrote:
> > revision-id: 8bf23efc914f18c687067e9314cadf4f36a85eec
> > parent(s): 71d1f35847a575239deff856590bf6f13
Hi Kristian!
On Mon, Sep 21, 2015 at 4:42 AM, Kristian Nielsen
wrote:
> nirb...@mariadb.com (Nirbhay Choubey) writes:
>
> > revision-id: 5f461a94a5aa2e1a20fa559ca612d96b53201e4e
> > parent(s): 29ac245dd04c5416d57a90b0ab3c4d08cbc4d723
> > committer: Nirbhay Chou
Hi Jan,
Could you please review the attached patch?
Thanks,
Nirbhay
From f9bf5f50593a181effb0cde9d18c1f0fd5c662ff Mon Sep 17 00:00:00 2001
From: Nirbhay Choubey
Date: Wed, 30 Sep 2015 21:56:50 -0400
Subject: [PATCH] MDEV-8831 : enforce_storage_engine doesn't block table
creation on other
Hi!
On Thu, Oct 1, 2015 at 12:46 PM, indiavaibhav vaibhavindia <
vaibhav.sanskr...@gmail.com> wrote:
> Hello everyone,
> My name is Vaibhav.I am new to programming for open source.
> I am facing problems in trying to compile Maria-Db.As instructed on the
> website, I cloned the maria db source an
ke run), all you
need is to run "make".. that's it.
I really appreciate your help.
>
You are welcome.
All the best.
-- Nirbhay
>
> Thanks,
> Vaibhav Choudhary
>
> On Thu, Oct 1, 2015 at 10:29 PM, Nirbhay Choubey
> wrote:
>
>> Hi!
>>
2.
what's the purpose of having this configured for all systemd platforms?
>
It should be ok for other platforms.
Best,
Nirbhay
>
> Regards,
> Sergey
>
> On Tue, Nov 03, 2015 at 05:38:12PM -0500, Nirbhay Choubey wrote:
> > revision-id: 4685c903bc
Hi Kristian,
Can you please review this patch?
- Nirbhay
On Fri, Nov 13, 2015 at 5:23 PM, Nirbhay Choubey
wrote:
> revision-id: 096fd8f57664d0b3061f0e781a31bfa3cc6bf6cd
> parent(s): a574407444fc3ea93ca88afa93dc18154251bf74
> committer: Nirbhay Choubey
> branch nick: 10.1.b9033
Hi Jean,
On Wed, Mar 16, 2016 at 4:48 PM, Jean Weisbuch wrote:
> I forgot to create the PR for upstream as i did for Otto's repo :
> https://github.com/ottok/mariadb-10.0/pull/26 and
> https://github.com/ottok/mariadb-10.0/pull/27
> These changes are already in Debian testing packages, should i
Hi Serg,
On Wed, Mar 16, 2016 at 3:02 PM, Sergei Golubchik wrote:
.. cut..
> diff --git a/debian/mariadb-server-10.1.mysql.init
> b/debian/mariadb-server-10.1.mysql.init
> > index 9e098b4..005d0e8 100644
> > --- a/debian/mariadb-server-10.1.mysql.init
> > +++ b/debian/mariadb-server-10.1.mysql.i
Hi Kristian!
Ok to push. (see a suggestion inline)
Best,
Nirbhay
On Thu, Apr 7, 2016 at 8:55 AM, Kristian Nielsen
wrote:
> Hi Nirbhay,
>
> Do you want to review this patch for MDEV-9383?
> It concerns your code added for do_domain_ids=(...).
>
> - Kristian.
>
> Kristian Nielsen writes:
>
>
Hello Serg,
On Fri, Apr 29, 2016 at 8:20 AM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On Mar 31, Nirbhay Choubey wrote:
> > revision-id: f9f290b6828eeb57cba611d006d2a9301dc52244
> (mariadb-10.1.13-3-gf9f290b)
> > parent(s): f4d5fe277599da4549c97c660f324c88cf9a2542
>
.askmonty.org/pipermail/commits/2016-May/009343.html
See my comments inline.
>
> On Tue, May 3, 2016 at 1:26 AM, Nirbhay Choubey
> wrote:
>
>> revision-id: a6fb98fd74ab6f14fab0c1ef4630b010ff28880f
>> (mariadb-10.1.13-6-ga6fb98f)
>> parent(s): f8cdb9e7e8fb69
Hi Serg,
On Tue, May 17, 2016 at 10:26 AM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
>
> .. cut ..
>
> > > > diff --git a/mysql-test/r/temp_table.result
> > > b/mysql-test/r/temp_table.result
> > > > index ee0b3ab..94b02a6 100644
> > > > --- a/mysql-test/r/temp_table.result
> > > > +++ b/mysql-
rting
the server, the entire recovery process requires a server restart.
1.0 : mysqld --wsrep-recover
2.0 - 3.2 : mysqld [all-other-options] --wsrep-start-position=xxx
> Some minor comments inline.
>
> On Fri, May 20, 2016 at 11:04:24PM -0400, Nirbhay Choubey wrote:
> > revision-i
Hi Svoj,
On Fri, May 27, 2016 at 3:27 AM, Sergey Vojtovich wrote:
> Hi Nirbhay,
>
> Looks good to push.
>
> On Thu, May 26, 2016 at 11:52:04PM -0400, Nirbhay Choubey wrote:
> > revision-id: 53696a63a2a517e04bf27382184162da50994ecb
> (mariadb-10.1.14-
Hi Shubham,
On Sun, Jun 5, 2016 at 9:25 AM, Sergei Golubchik wrote:
> Hi, Shubham!
>
> Here's a first review.
>
> Summary: looks good so far, main comments:
>
> 1. Coding style. Use the same coding style as everywhere else in the
>file you're editing. It's the same in sql/ and in myisam/ dir
Hi Serg!
On Fri, Jun 3, 2016 at 7:20 AM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On May 26, Nirbhay Choubey wrote:
>
> > > > +/*
> > > > + Create a temporary table, open it and return the TABLE handle.
> > > > +
> > > > + @param h
Hi Kristian!
On Fri, Jun 3, 2016 at 7:53 AM, Kristian Nielsen
wrote:
> Sergei Golubchik writes:
>
> > On May 26, Nirbhay Choubey wrote:
>
> >> > > + if (wait_for_prior_commit())
>
> Please call this method tmptable_wait_for_prior_commit() or something like
n a patch, so
> you may want to spend more time testing or analyzing that code.
>
Yes, I did add some related rpl test cases.
>
> Ok to push, when you're ready! Thanks!
>
> On May 26, Nirbhay Choubey wrote:
> > revision-id: 56a2835872c4ac7296ec0ae2ff6
vote to remove this call. But please check with some
> Aria
> expert.
> Your fix is mostly alright, but I guess we shouldn't reset last_version in
> case
> of HA_EXTRA_PREPARE_FOR_DROP.
>
Monty ^^ ?
Best,
Nirbhay
>
> Regards,
> Sergey
>
Hi Monty,
On Tue, Jun 21, 2016 at 9:30 AM, Michael Widenius wrote:
>
> Hi!
>
> >>>>> "Nirbhay" == Nirbhay Choubey writes:
>
>
>
> Nirbhay> ALTER TABLE implementation takes a shortcut for operations not
> affecting
> Nirbhay> .frm
Hi Kristian!
On Mon, May 2, 2016 at 2:10 PM, Kristian Nielsen
wrote:
> Nirbhay Choubey writes:
>
> [Cc: maria-developers@, please always keep these discussions on the
> mailing list]
>
> > In Galera cluster, the state transfer scripts perform FTWRL and
> > copy data
Hi Kristian,
On Thu, Jun 23, 2016 at 3:39 AM, Kristian Nielsen
wrote:
> Nirbhay Choubey writes:
>
> > While copying the last 2 binlog files would have solved this, I have
> worked
> > out
> > a solution where the donor node waits for binlog checkpoint event for
&g
Hi Kristian,
On Sat, Jun 25, 2016 at 3:57 AM, Kristian Nielsen
wrote:
> Nirbhay Choubey writes:
>
> >> Also, it seems reasonable that FTWRL in general could wait for
> checkpoint
> >> events so that other backup mechanisms similarly could avoid binlog
> files
&g
Hi Serg,
On Mon, Jun 27, 2016 at 7:38 AM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On Jun 08, Nirbhay Choubey wrote:
> > revision-id: 075233312cc5bc6c242f4629f8293d4c67937f02
> (mariadb-10.1.14-10-g0752333)
> > parent(s): c9f05974e618a869563f2360ef1ca910974a4f1c
>
Hi Serg,
On Tue, Jun 28, 2016 at 5:02 PM, Sergei Golubchik wrote:
> Hi, Nirbhay!
>
> On Jun 27, Nirbhay Choubey wrote:
> > >
> > > That seems quite ugly, why not call it from the SST code, after it
> > > has called reload_acl_and_cache()? You're
Hi Kristian,
On Wed, Jun 29, 2016 at 4:31 AM, Kristian Nielsen
wrote:
> Nirbhay Choubey writes:
>
> > It wouldn't prevent the user from doing REFRESH_BINARY_LOG, but with
> > wait_for_last_checkpoint_event() added to reload_acl_and_cache(), it
> would
> >
On Wed, Jun 29, 2016 at 9:31 AM, Kristian Nielsen
wrote:
> Nirbhay Choubey writes:
>
> > Since there is no wait in reload_acl_and_cache() anymore, user's FLUSH
> LOGS
> > will
> > create a new binary log file with binlog checkpoint event for the
> > penulti
Hi Svoj,
On Thu, Jun 23, 2016 at 7:35 AM, Sergey Vojtovich wrote:
> Hi Nirbhay,
>
> This solution looks better than MyISAM/Aria based one. Still a few doubts
> inline.
> I still suggest someone should do second review.
>
> On Tue, Jun 21, 2016 at 01:47:15PM -0400,
Hi Monty!
Can you please 2nd review this patch?
http://lists.askmonty.org/pipermail/commits/2016-July/009523.html
Best,
Nirbhay
On Tue, Jul 5, 2016 at 4:51 AM, Sergey Vojtovich wrote:
> Hi Nirbhay,
>
> Looks good, thanks!
>
> On Fri, Jul 01, 2016 at 02:47:29PM -0400, Nirbha
Hi Svoj!
Thanks for the review.
On Fri, Sep 2, 2016 at 1:41 AM, Sergey Vojtovich wrote:
> Hi Nirbhay,
>
> Ok to push, one question below.
>
> On Thu, Sep 01, 2016 at 12:46:58PM -0400, Nirbhay Choubey wrote:
> > revision-id: 97d212a34ff4e0558126bc393bbef97036611d83
> (ma
Hi Svoj,
On Fri, Sep 2, 2016 at 9:10 AM, Sergey Vojtovich wrote:
> Hi Nirbhay,
>
> On Fri, Sep 02, 2016 at 09:00:27AM -0400, Nirbhay Choubey wrote:
> > > > diff --git a/sql/log_event.cc b/sql/log_event.cc
> > > > index afa58af..66e7c60 100644
> > >
PLUGIN_IS_UNINITIALIZED |
PLUGIN_IS_DELETED))
Also, with this commit plugin_thdvar_init() is free from wsrep related
changes.
Best,
Nirbhay
> On Sep 27, Nirbhay Choubey wrote:
> > revision-id: a8162d4a8737cff67889390fad0153acc175391d
> (mariadb-10.1.17-22-ga8162d4)
> > parent(s): 6a6b253a6
Hi Jan!
On Wed, Sep 28, 2016 at 12:48 PM, Jan Lindström
wrote:
> Hi Nirbhay,
>
> This looks ok but one question (no need to change now):
>
> On Wed, Sep 28, 2016 at 7:36 PM, Nirbhay Choubey
> wrote:
>
>>
>> +Since some wsrep threads (THDs) are create befor
Hi Jan!
On Wed, Oct 12, 2016 at 7:31 AM, Jan Lindström
wrote:
> revision-id: a3d469b991732dddfafe966011e996166cd98671
> (mariadb-10.2.2-39-ga3d469b)
> parent(s): 6e46de4a674c55858ec5b2528dcebb69010b34d6
> author: Jan Lindström
> committer: Jan Lindström
> timestamp: 2016-10-12 14:29:36 +0300
> m
Hi Bar,
On Tue, Nov 22, 2016 at 12:33 PM, Alexander Barkov wrote:
> Hello Nirbhay,
>
> Can you please review a patch for 10.3:
> MDEV-11337 Split Item::save_in_field() into virtual methods in Type_handler
>
>
> It also automatically fixed two problems:
>
> MDEV-11331 Wrong result for INSERT IN
Hi Sachin,
On Mon, Nov 28, 2016 at 4:49 AM, Sachin Setiya
wrote:
> Hi Nirbhay,
>
>if (IF_WSREP(thd->wsrep_applier,1))
>
> {
>
> plugin_thdvar_init(thd);
>
> }
>
> This code in commit , breaks log writing on other nodes(In galera) , It
> sets
> the thd->variables to global syste
68 matches
Mail list logo
