[Maria-developers] GSoC'19 proposal

2019-04-05 Thread Rucha Deodhar
Hello. My name is Rucha Deodhar. I would like to contribute to mariaDB during GSoC 2019. More information can be found in my draft of proposal on the attached google doc. Any feedback would be appreciated. Thanks Proposal for “ADD RETURNING TO INSERT” for GSoC’19 <https://docs.google.

[Maria-developers] GSoC Introduction

2019-05-26 Thread Rucha Deodhar
Hello, I am Rucha Deodhar. I am a GSoC student and will implement INSERT...RETURNING. In the first week I plan to extend the parser. Approximately the next 2 months, I plan to make changes the in the codes in insert.cc and other files related to the project, and remaining time for testing

[Maria-developers] Weekly Report

2019-06-02 Thread Rucha Deodhar
Report for week 1: Hello! I made test cases and extended the parser for: INSERT...RETURNING * and INSERT...RETURNING It is working fine for INSERT...ON DUPLICATE KEY UPDATE, INSERT...IGNORE, INSERT...SET, and simple insert statements. As I have never coded parser before, it was throwing errors

[Maria-developers] Weekly Report

2019-06-16 Thread Rucha Deodhar
mit/218d81b86d941a874cfac9123d7aeb141e01f110 Regards, Rucha Deodhar ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

[Maria-developers] Weekly Report

2019-06-09 Thread Rucha Deodhar
Report for week 2: Hello! This week I ran the test case for parser written in last week and made changes in the parser according to the suggestions given, tried making insert...select..returning work. I analysed how RETURNING in delete is implemented, how insert is implemented, and how the data

[Maria-developers] Weekly Report

2019-06-23 Thread Rucha Deodhar
how select_insert class uses lex->field_list and do the same for returning_list. Here is the link to code which returns the listed fields for select table: https://github.com/rucha174/server/commit/6b18dd3cfc76d41871357c5b2006e04d1d508c1d Regards, Rucha D

Re: [Maria-developers] INSERT ... RETURNING Initial code review

2019-07-07 Thread Rucha Deodhar
Hello! Thanks for the review. It will indeed help me write better code and test cases. To begin with, I' ll first get familiar with git bisect. I'll keep you updated about my progress. Regards, Rucha Deodhar On Sun, Jul 7, 2019, 7:16 PM Vicențiu Ciorbaru wrote: > Hi Rucha! > &g

[Maria-developers] Weekly Report

2019-07-07 Thread Rucha Deodhar
, Rucha Deodhar <https://www.avast.com/en-in/recommend?utm_medium=email_source=link_campaign=sig-email_content=webmail_term=default3=ad9cce02-ddec-4842-be2f-33f375f8223d> I’m protected online with Avast Free Antivirus. Get it here — it’s free forever. <https://www.avast.com/en-in/recommend?u

[Maria-developers] Weekly Report

2019-07-14 Thread Rucha Deodhar
nsert_update opt_select_expressions { something like if ($3) Lex->returning_list= $3; Lex->pop_select(); //main select if (Lex->check_main_unit_semantics()) MYSQL_YYABORT; } ; Regards, Rucha Deodhar <

[Maria-developers] Weekly Report

2019-06-30 Thread Rucha Deodhar
this is too big a change for the grammar and I am trying to find alternate solution. I also changed the variable names and made them more descriptive. Regards, Rucha Deodhar ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria

[Maria-developers] Weekly Report

2019-08-11 Thread Rucha Deodhar
is up to date with the latest changes. Here is the link for the same: https://github.com/rucha174/server/commit/0d7eb4198cc0aadba42acb4960c17570270423f5 Regards, Rucha Deodhar ___ Mailing list: https://launchpad.net/~maria-developers Post to : ma

[Maria-developers] Weekly Report

2019-08-18 Thread Rucha Deodhar
they were still showing as binary files, which was probably because of the diffs. So I removed the existing files from my repo and pushed new files then cleaned up the commits again and fixed the 80 character per line rule for new tests. My github repo is up to date with latest changes. Regards, Rucha

[Maria-developers] Weekly Report

2019-08-04 Thread Rucha Deodhar
for insert_returning. I also fixed line endings for tests and added more comments to make our implementation more understandable. I github repo is up to date with the latest changes. Regards, Rucha Deodhar. ___ Mailing list: https://launchpad.net/~maria

Re: [Maria-developers] Coding Style Review INSERT RETURNING

2019-08-07 Thread Rucha Deodhar
Hello! Thanks for the review. I'll start working on it and keep you updated with my progress. Regards, Rucha On Wed, Aug 7, 2019 at 7:51 PM Vicențiu Ciorbaru wrote: > Hi Rucha! > > This is going to be a very thorough review looking at coding style. I'll > nitpick on every line of code where I

[Maria-developers] Weekly Report

2019-07-28 Thread Rucha Deodhar
be used, I wanted to check if these functions can be used) I have made related changes in the documentation and my github repo is up to date with latest changes. Regards, Rucha Deodhar ___ Mailing list: https://launchpad.net/~maria-developers Post

Re: [Maria-developers] INSERT ... RETURNING intermediate review

2019-07-20 Thread Rucha Deodhar
Hello! The review is indeed very helpful. I'll start working on the review today and keep you updated about the progress. Regards, Rucha Deodhar On Sun, Jul 21, 2019, 12:05 AM Vicențiu Ciorbaru wrote: > Hi Rucha! > > I've spent quite a bit of time looking at the imple

Re: [Maria-developers] INSERT ... RETURNING intermediate review

2019-07-21 Thread Rucha Deodhar
according to the diff file and also fixed REPLACE...RETURNING and have pushed the latest changes on my repo. I also ran the tests related to INSERT...RETURNING. They are passing. Also, I am willing to work on fixing some of the hacks once GSoC project implementation is perfect. Regards, Rucha

[Maria-developers] Weekly Report

2019-07-21 Thread Rucha Deodhar
ING a list was declared inside the scope of "if" and using it outside the scope was illegal. So I moved it to the scope outside of if and made the grammar return: if select_lex::item_list is not empty else NULL. My github repo is up to date with latest changes. Re

Re: [Maria-developers] INSERT ... RETURNING Initial code review

2019-07-10 Thread Rucha Deodhar
SELECT id1 FROM t1 where id1=1); Because it was returning only one row and column. Regards, Rucha Deodhar On Sun, Jul 7, 2019 at 7:16 PM Vicențiu Ciorbaru wrote: > Hi Rucha! > > > Here is the promised review. I have run the main test suite locally and have > noticed > > that