Hi, Vadim!
On May 27, Vadim Tkachenko wrote:
Monty,
I made merge proposal:
https://code.launchpad.net/~maria-captains/maria/slow-extended-patch/+merge/6840
You can find patch there.
Eh, I certainly hope it won't be merged in its current form.
I didn't look too far, but even the very
. (this is similar to the WL#4906, that I've recently created)
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun
really visible.
What was wrong with http://lists.mysql.com/commits/66972 ?
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
...
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
Hi, Michael!
On Aug 16, Michael Widenius wrote:
Hi!
Sergei == Sergei Golubchik ser...@pisem.net writes:
cut
We can't do this with the plugins, as we don't know for an old
installation what plugins the user wanted to install.
All of them, of course.
If all plugins
@@global.example_enum_var = 'e2';
eh, I'm sorry, but do you check your .result files before committing ?
:)
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server
Hi, MARK!
On Oct 19, MARK CALLAGHAN wrote:
On Mon, Oct 19, 2009 at 5:52 AM, Sergei Golubchik ser...@pisem.net wrote:
On Oct 19, Michael Widenius wrote:
I just finished applying / modifying / rewriting the userstats
patch to MariaDB 5.2 and will commit this in a moment.
I wonder
won't
need to track manually what he can load where.
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems
assigned to.
Regards / Mit vielen GrÐÑen,
Sergei
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB MÐnchen 161028
no longer the case, you need to remove the whole ifdef block,
not only the assert.
PBXT XA can be disabled by setting pbxt_support_xa=0, it is enabled by
default.
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
, Sergei Golubchik wrote:
On Dec 01, Paul McCullagh wrote:
This patch changes MariaDB code in one case:
File handler.cc, Line 1591
DBUG_ASSERT(total_ha_2pc == (ulong) opt_bin_log+1); // only InnoDB and
binlog
This line has been commented out, because the assertions fails now
that PBXT supports
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
___/ Sonnenallee 1, 85551 Kirchheim
Hi, knielsen!
Oh, I sincerely hope you don't think of pushing *that*.
The whole damn boost inside mariadb bzr tree ?
What's the next step, libc ?
On Dec 13, kniel...@knielsen-hq.org wrote:
#At lp:maria
2785 kniel...@knielsen-hq.org2009-12-13 [merge]
Merge OQGraph into latest
as an external dependency should
be fine. At least until there will be an indication that it's not.
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server
about anyway :)
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
/_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028
Grüßen,
Sergei
P.S. Disclaimer: besides the last statement everything else is just my
speculation about how innodb hot backup works.
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect
Hi, MARK!
On Dec 29, MARK CALLAGHAN wrote:
On Mon, Dec 28, 2009 at 9:20 AM, Sergei Golubchik ser...@pisem.net wrote:
trn1 start transaction; insert t1 select * from t2;
trn1 commit;
trn1 ... xa_prepare() ...
trn2 start transaction; insert t2 values (1); commit;
trn2 xa_prepare
privileges.
+# We use killall -9, which can cause severe side effects!
You can use
killall -u `whoami`
not perfect, but still much safer.
Regards / Mit vielen Grüßen,
Sergei
--
__ ___ ___ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com
Hi, MARK!
On Dec 29, MARK CALLAGHAN wrote:
On Tue, Dec 29, 2009 at 11:23 AM, Sergei Golubchik ser...@pisem.net wrote:
Is this a potential problem?
* order of transactions in binlog don't commit record order for InnoDB
in transaction log
* binlog rotation occurs
* last binlog has XIDs 1, 3
Hi, Kristian!
On Jan 16, Kristian Nielsen wrote:
Hi,
Alex Budovski has done some work to debug why some tests (binlog tests in
particular) are failing on Windows, and found that this is because
mysql-test-run.pl set the TZ variable. This interacts poorly with the Windows
Operating System.
Hi, Alex!
On Jan 22, Alex Yurchenko wrote:
So when refactoring replication code and API we suggest to think of
replication as of redundancy service and establish a general API for
such service that can be utilized by different implementations with
different qualities of service. In other
Hi,
Paul, I was backporting libservices to MariaDB, and with a related
test case found a bug in MariaDB - mutexes were locked in the wrong
order. I've fixed that some time ago in mysql-next, so I took the fix
from there - the fix was to not lock LOCK_plugin over the plugin
initialization code.
Hi.
That's a rough list of enhancement ideas for worklog.
Some of them I'm going to do (but not all).
Feel free to suggest more or get rid of WL, use X instead,
just don't forget the because of part.
report: easy to do tasks
make it to provide a list of low-handing fruits, tasks that
Hi, MARK!
On Mar 25, MARK CALLAGHAN wrote:
On Wed, Mar 24, 2010 at 5:28 PM, Arjen Lentz ar...@openquery.com wrote:
This test is as important as the above crash, because multi-engine
transactions are something people will be using and thus relying on
correctly working
I won't use this.
Hi, Monty!
See the answers below:
(no reply means ok, changed)
On Mar 25, Michael Widenius wrote:
=== modified file 'client/mysql.cc'
+ /**
+ An example of mysql_authentication_dialog_ask callback.
+
+ The C function with the name mysql_authentication_dialog_ask, if
exists,
+
Hi, Monty!
On Mar 26, Sergei Golubchik wrote:
Hi, Monty!
See the answers below:
(no reply means ok, changed)
On Mar 25, Michael Widenius wrote:
And here's a patch that implements your review comments.
Regards,
Sergei
=== modified file 'client/mysql.cc'
*** client/mysql.cc 2010-03
Hi, Michael!
On Mar 28, Michael Widenius wrote:
#At lp:maria based on revid:ser...@pisem.net-20100324221239-7bj3zf8yv6bgclx1
2834 Michael Widenius2010-03-28
Fixed compiler warnings and sporadic failures in test cases
Hey, Monty,
may I ask what warnings did you get with gcc
Hi, Oleksandr!
On Mar 29, Oleksandr Byelkin wrote:
[skip]
+ #ifdef _WIN32
In the rest of my_global.h we use __WIN__
Wouldn't it be better to use the same constant everywhere?
Yes, it would. And this constant should be _WIN32, __WIN__ was
historically used, but it's incorrect - as was
Hi, Oleksandr!
On Mar 29, Oleksandr Byelkin wrote:
+#define PLUGIN_MATURITY_TEST 1
+#define PLUGIN_MATURITY_ALPHA 2
+#define PLUGIN_MATURITY_BETA 3
+#define PLUGIN_MATURITY_GAMMA 4
+#define PLUGIN_MATURITY_RELEASE 5
release ? or production or stable ?
there can be an alpha release, or
Hi, Paul!
On Mar 31, Paul McCullagh wrote:
On Mar 25, 2010, at 10:24 PM, Sergei Golubchik wrote:
Hi, MARK!
On Mar 25, MARK CALLAGHAN wrote:
On Wed, Mar 24, 2010 at 5:28 PM, Arjen Lentz ar...@openquery.com wrote:
This test is as important as the above crash, because multi-engine
Hi, Arjen!
On Mar 31, Arjen Lentz wrote:
Hi Kristian
On 31/03/2010, at 11:22 PM, Kristian Nielsen wrote:
So my preference would be to make it a built-in/regular as it will
make adopton and subsequent use much easier.
Understand, unfortunately I am out of cycles to look into changing this
Hi, sanja!
On Mar 30, sa...@askmonty.org wrote:
revno: 2761
revision-id: sa...@askmonty.org-20100330203255-1pyz892qsqg1liov
parent: sa...@askmonty.org-20100330123515-4p8q03xccl3d6k59
committer: sa...@askmonty.org
branch nick:
Hi, Igor!
First, just to make it clear - you asked me to review the post-review
fixes patch, so that's what I did, I looked at how you implemented
Monty comments, I did not review the partitioned key caches feature - it
would need much more time - and I don't understand all of it.
See below, I
Hi, all!
Thank you for participating, the minutes and presentations are now
online: http://askmonty.org/wiki/Storage_Engine_Summit_2010
Regards,
Sergei
On Mar 29, Sergei Golubchik wrote:
Hi, all!
We are happy to announce the *Storage Engine Summit* 2010.
This traditional one-day
Hi, Henrik!
On Apr 27, Henrik Ingo wrote:
Serg
At the storage engine meeting, we decided to host a wiki page where
all engines can document their CREATE TABLE options, so that semantics
of options can remain consistent.
Does this wiki page exist yet?
No, it does not
Regards,
Sergei
Hi, Bo!
On May 10, Bo Thorsen wrote:
Hi everyone,
I have been looking at getting our binary windows distribution back on
track. One of the options would be to create the zip file like we did
earlier.
Another way would be to create a proper windows installer. For this, there
are several
Hi, Henrik!
On May 05, Henrik Ingo wrote:
I think we very nearly made the same mistake with 5.2. We had a
feature list, and while some of them were rolling, we also had
features that were decided in advance that they _must_ be pushed at
a certain date. I strongly believe this is wrong.
Hi,
we've talked about engine attributes in the CREATE TABLE,
and that one should be able to specify them per partition as well.
Now, thinking about it, I'm not quite sure what the semantics shuld be.
What is your use case ? How do you want them to work ?
I see different possibilities. Say,
Hi, Henrik!
On May 11, Henrik Ingo wrote:
On Tue, May 11, 2010 at 12:05 PM, Sergei Golubchik ser...@pisem.net wrote:
we've talked about engine attributes in the CREATE TABLE, and that
one should be able to specify them per partition as well.
Now, thinking about it, I'm not quite sure
Hi, Stewart!
On May 14, Stewart Smith wrote:
On Thu, 13 May 2010 16:36:41 +0200, Sergei Golubchik s...@askmonty.org
wrote:
* not everything can be replicated at every level, for example table
creation cannot be replicated row-based, InnoDB changes cannot be
replicated
Hi, Timour!
On Jun 02, Timour Katchaounov wrote:
Hi,
I was looking today at some optimizer code, and bumped again
into sql_select.cc:find_best(). We have been using the greedy
optimizer for years, and this function has been dead code for
a while, isn't it time to remove it?
The less
Hi, Timour!
On Jun 02, Timour Katchaounov wrote:
Sergei,
Hi, Timour!
On Jun 02, Timour Katchaounov wrote:
Hi,
I was looking today at some optimizer code, and bumped again
into sql_select.cc:find_best(). We have been using the greedy
optimizer for years, and this function has been dead
Hi, Monty!
Thanks for the review!
See my replies below.
On Jun 03, Michael Widenius wrote:
At http://bazaar.launchpad.net/~maria-captains/maria/5.2/
revno: 2802
few small MySQL bugs/issues that impact the engines, as
Hi, Michael!
On Jun 04, Michael Widenius wrote:
hi!
Sergei == Sergei ser...@pisem.net writes:
Sergei ** Changed in: maria
SergeiImportance: Undecided = Low
Sergei --
Sergei update is not changing internal auto increment value
Sergei https://bugs.launchpad.net/bugs/314570
Hi, Bo!
On Jun 09, Bo Thorsen wrote:
Hi everyone,
Recently, we found out that xtradb and federatedx were compiled as plugins
on Windows. This is not correct because they are core storage engines and
should be linked statically instead.
Heh, that's funny.
Because yesterday on the call we
Hi, Mateusz!
If you want a reliable answer you need to contact a lawyer, not the
mailing list.
But with a usual disclaimer (I'm not a lawyer) I suppose that if you
want to keep your engine closed source you have to contact Oracle (not
MariaDB) and buy a license.
On Jun 09, Mateusz Matan wrote:
parent: kniel...@knielsen-hq.org-20100531084334-81f5z74nxx6v9zww
committer: Sergei Golubchik ser...@pisem.net
branch nick: 5.1
timestamp: Wed 2010-06-09 13:53:51 +0200
message:
fix questionable UNIV_EXPECT's in the xtradb that confused old gcc.
I assume you have cc: the XtraDB
Hi.
A quick summary of recent changes in WorkLog:
* there are no archived tasks anymore. All cancelled and closed tasks
are inactive, others are active
* guest users shouldn't be able to update WL tasks now.
* private field dissapeared, you won't see Private: yes anymore.
* major rework of the
Hi, Kristian!
API, eliminating lots of class definitions and accessor functions.
Though arguably it wouldn't really simplify the API, as the
complexity would just be in understanding the THD class.
For now, the API is proposed without exposing the THD class.
(Similar encapsulation
Hi, Zardosht!
On Jul 06, Zardosht Kasheff wrote:
Oops, it turns out the function signature is different from MySQL.
This tripped us up.
Hm, this is arguably a bug. We should not have changed an API.
I'll fix it.
Regards,
Sergei
-Zardosht
On Tue, Jul 6, 2010 at 3:15 PM, Zardosht
Hi, Kristian!
On Aug 04, Kristian Nielsen wrote:
Sergei Golubchik ser...@pisem.net writes:
My main comment is that there should be some documentation of the My::Suite
class, as I write in a comment below.
I'll add it, thanks.
Other than that I think it is ok to push. I have a number
Hi, Kristian!
On Aug 05, Kristian Nielsen wrote:
Sergei Golubchik s...@askmonty.org writes:
Other than that I think it is ok to push. I have a number of small remarks
inline below, you can fix what you agree with and ignore the rest. There
are
also a couple of questions to check
Hi, Kristian!
On Aug 06, Kristian Nielsen wrote:
s...@askmonty.org writes:
=== added file 'mysql-test/suite/sphinx/sphinx.test'
--- a/mysql-test/suite/sphinx/sphinx.test 1970-01-01 00:00:00 +
+++ b/mysql-test/suite/sphinx/sphinx.test 2010-08-06 13:11:37 +
@@ -0,0 +1,30 @@
Hi,
I'v renamed everything user-visible (error messages, variables,
command-line utilites, etc).
Do you want me to rename just *everything* ? file names, function names,
etc ? I mean, all internal stuff. It wouldn't add much value, and would
complicate the merges. On the other hand, it'd be
Hi, Kristian!
On Aug 11, Kristian Nielsen wrote:
+
+ if (! defined($option) and $ENV{$option_name}) {
This will prevent an option to be set from an environment variable
with the value 0. (Just a remark, I'm not sure if that is a problem
or not though.)
Fixed, thanks.
It's a nice
Hi, Bo!
It looks ok to me, but see below.
On Aug 18, Bo Thorsen wrote:
=== modified file 'libmysqld/CMakeLists.txt'
--- libmysqld/CMakeLists.txt 2010-07-01 14:35:50 +
+++ libmysqld/CMakeLists.txt 2010-07-08 14:34:03 +
@@ -95,6 +95,11 @@
FOREACH(rpath
Hi, Kristian!
On Sep 06, Kristian Nielsen wrote:
However, as I revisited the algorithm, it occured to me that it is in
any case better to wake up threads individually as soon as
commit_ordered() has finished. This way, the first threads in the
queue are free to continue doing useful work
Hi, Kristian!
On Sep 07, Kristian Nielsen wrote:
Sergei Golubchik s...@askmonty.org writes:
Now, WL#132 - Transaction coordinator plugin
Wouldn't it be simpler to create only group_log_xid() interface, no
log_and_order() or log_xid() ? The tc plugin gets the list in
group_log_xid
Hi.
So, Phone Home or MySQL feedback daemon or better name wanted
feature.
It is something that can be installed together with MariaDB, it will
gather different statistic about how MariaDB is used and will send this
information anonymously to mariadb.org.
Not unlike the Uptimes Project or Debian
Hi, Adam!
On Sep 09, Adam M. Dutko wrote:
So, Phone Home or MySQL feedback daemon or better name wanted
feature.
Maybe call it Butler ??? Just a thought...
:)
Why?
Not unlike the Uptimes Project or Debian Popularity Contest.
Opt-in only with an easy disable option after opting
Hi.
For a while, I had a small personal gripe that it is not easy to see
what plugins are configured to be built and how. That is, I know where
to look (configure prints all that when working, but not
alphabetically, so a particular plugin name isn't easy to spot) but I
had to explain this to
Hi, Kristian!
On Sep 30, Kristian Nielsen wrote:
Sergei Golubchik s...@askmonty.org writes:
Thanks for review!
What I would now like to do is to discuss how to proceeed (where to
push this basically).
On the one hand, the patch got rather more intrusive than I first
wanted. The main
Hi, Kristian!
On Oct 06, Kristian Nielsen wrote:
Would it make sense to have transactional behaviour for status
variables, and/or information_schema tables? Or does this break the
code and/or user expectations too much?
The motivation is to follow up on MWL#116, group commit, which
Hi, Sergey!
On Oct 10, Sergey Petrunya wrote:
I was asked about this performance problem: consider a query
(so was I, so was Igor, and may be others :)
select * from tbl where tbl.key like '%foo%'
Table records are big, much larger than the length of the key. LIKE condition
is very
Hi, Oli!
On Oct 18, Oli Sennhauser wrote:
shell diff mysqld.cc.orig mysqld.cc
7503a7504
{Key_blocks_warm, (char*) offsetof(KEY_CACHE, warm_blocks),
SHOW_KEY_CACHE_LONG},
Thanks. I'll add it to mariadb-5.1.
Regards,
Sergei
P.S.: Next time, please, use diff -up, not just diff.
Hi, Sergey!
On Oct 17, Sergey Petrunya wrote:
Hello,
I've noticed that centos5-amd64-minimal builds innodb plugin for
MariaDB 5.2 and 5.3 (didn't check 5.1)
Right.
Which shows we're building the plugin. Do we really need this?
Yes :)
We have users for it, and we'd better check that
Hi, Zardosht!
First: please send questions like this to the list, not only to me.
I wanted to discuss this with Sergey Petrunia and had to paste this on
irc.
Anyway,
On Oct 22, Zardosht Kasheff wrote:
Hello Sergei,
One of the problems we at Tokutek have run into with the optimizer
many
Hi, Kristian!
On Oct 26, Kristian Nielsen wrote:
Currently, when an InnoDB/XtraDB transaction is committed with the
binlog enabled, we do three fsync()'s:
1. Inside prepare() in InnoDB
2. When writing to the binlog
3. Inside commit() in InnoDB
...
why do we need the fsync() in commit()?
Hi, Zardosht!
On Oct 24, Zardosht Kasheff wrote:
Thanks Sergei,
I will CC maria-developers from now on.
I understand why this cannot go into 5.1. I was more interested in
knowing if this is logically correct, which it seems to be. I hope in
the long term (MariaDB 5.3 and beyond) that the
Hi, Michael!
On Oct 27, Michael Widenius wrote:
Sergei == Sergei Golubchik s...@askmonty.org writes:
+++ b/plugin/feedback/sender_thread.cc 2010-09-30 14:24:31 +
...
+ if (thd) // for nicer SHOW PROCESSLIST
+thd-set_query(const_castchar*(url-url()), url-url_length
Hi,
Just noticed that gcc has a warning option -Wframe-larger-than=LEN
that makes gcc to warn about functions with stack frames larger
than LEN.
Considering a recent issue when we had a 130K structure on the stack
(which did overflow the stack in some cases), it may be a good idea to
enable this
Hi, Daniel!
On Nov 10, Daniel Bartholomew wrote:
All,
I've created the download, release notes, and changelog pages for
MariaDB 5.2.3:
http://askmonty.org/wiki/MariaDB:Download:MariaDB_5.2.3
http://kb.askmonty.org/v/mariadb-523-release-notes
Hi, knielsen!
On Nov 20, kniel...@knielsen-hq.org wrote:
At http://bazaar.launchpad.net/~maria-captains/maria/5.1
revno: 89
revision-id: kniel...@knielsen-hq.org-20101120084531-x0hbb64q9x0yj376
parent:
Hi, 0x00F6!
First: please send questions like this to maria-developers@lists.launchpad.net
it's a public mailing list dedicated to MySQL and MariaDB internals, source
code, and related things. I am subscribed, so I'll see you mail there, and you
may be sure I will, because it won't be
Hi, Zardosht!
On Dec 08, Zardosht Kasheff wrote:
We always thought that stats.records was meant to be an estimate, and
that an estimate of 0 was ok even if the table was non-empty. We were
reporting that stats.records was 0 even though the table was
non-empty. Is this assumption wrong?
Hi, Arjen!
[moving to the public list]
On Dec 14, Arjen Lentz wrote:
Hi all
Can we adopt/implement http://forge.mysql.com/worklog/task.php?id=4925 in
MariaDB?
The benchmark info is in the item, and looks quite interesting.
The author tested it using a separate tool to preallocate the
Hi, sanja!
On Oct 22, sa...@askmonty.org wrote:
At file:///home/bell/maria/bzr/work-maria-5.1-CREATE/
revno: 2959
revision-id: sa...@askmonty.org-20101021220232-eqso4ey46985wfzf
parent:
Hi, Oli!
On Dec 11, Oli Sennhauser wrote:
Hi all,
As suggested by Sergei we should discuss this here.
Copying the login trigger stuff to a place in the code where I thought
it makes sense I have created a logout trigger. This gives the
capability to track a session from its beginning to
Hi, knielsen!
On Jan 03, kniel...@knielsen-hq.org wrote:
At http://bazaar.launchpad.net/~maria-captains/maria/5.1
Hm.
Why do you prefer to add a dummy include file to every long test,
instead of using a separate file, like disabled.def ?
I think it'd be easier to maintain in a separate file,
Hi, Lichao!
On Jan 24, Lichao Xie wrote:
Hi, Sergei!
I'm sorry, my English is not so good!
There is no a API to get the exact records in a range, but the API can
help to improve performance for the case: select count(*) from t where
id 10 and id 100;
I want to know why there is no
Hi, MARK!
On Feb 10, MARK CALLAGHAN wrote:
When will there be a MariaDB branch based on MySQL 5.5? I want to use
that as the basis for the 5.5 version of the Facebook patch.
Give me a month.
I started the merge, but then had to switch to an urgent project, I have
the merge about, say, 80%
Hi, sanja!
On Jan 13, sa...@askmonty.org wrote:
revno: 3014
revision-id: sa...@askmonty.org-20110113180607-e5hc8zuugxxjtn6k
parent: pser...@askmonty.org-20110112083018-90rw058f00uslvoz
committer: sa...@askmonty.org
branch nick:
Hi, Kristian!
A fourth option could be to take MySQL's version and add
--binlog-annotate-rows-events and --replicate-annotate-rows-events
options, and make a slave read MWL#47 annotation event as a
rows_query_log_event. This option is basically the opposite of yours
third option.
In both cases
Hi, Haidong!
On Mar 18, Haidong Ji wrote:
All,
I've created my trunk on launchpad for MariaDB, and am ready to make
some updates to the sample my.cnf file(s) packaged with MariaDB. I
have a few questions regarding how to proceed:
1. I've seen work log creation and assignment in MariaDB
Hi, Kristian!
On Apr 06, Kristian Nielsen wrote:
As promised, here is a summary of the changes to the storage engine
API that I made as part of group commit.
Two new handlerton methods are added:
void (*prepare_ordered)(handlerton *hton, THD *thd, bool all);
void
Hi, Kristian!
On Apr 18, Kristian Nielsen wrote:
For merging MySQL into MariaDB, we need to work out what to do about
error code.
I think we have these options:
1. Cooperate with MySQL@Oracle, so that whenever we add an error code
in MariaDB, the corresponding code is also reserved in
Hi, Igor!
On Apr 24, Igor Babaev wrote:
When debugging I discovered the following bad code in sql_select.cc of
the current 5.3 tree:
tmp= table-file-read_time(key, 1,
min(tmp,s-worst_seeks)-1); = !
?
tmp*=
Hi, Igor!
On Apr 24, Igor Babaev wrote:
On 04/24/2011 01:51 AM, Sergei Golubchik wrote:
In 5.3, record_count* is moved to a separate line, so it should just
be
tmp= min(tmp,s-worst_seeks);
But it uses table-file-read_time(). Which is defined as
virtual double read_time
Hi, Kurt!
On May 11, Kurt von Finck wrote:
IMO, the Knowledgbase entry for the virtual columns
http://kb.askmonty.org/v/virtual-columns
is among the best and most useful entries we have. It describes the
feature, suggests use cases and demonstrates functionality in a
straightforward
Hi, Oleksandr!
On May 13, Oleksandr Byelkin wrote:
revno: 2988
revision-id: sa...@askmonty.org-20110513150858-ba2sowmbv1l39xxm
parent: sa...@askmonty.org-20110512150136-5yzagaev1ssohykp
committer: Oleksandr Byelkin sa...@askmonty.org
branch nick: work-maria-5.3-machandlersocket
timestamp:
Hi, Zardosht!
On May 18, Zardosht Kasheff wrote:
Hello Monty,
Thank you for your feedback on the four diffs and for approving them.
This makes getting TokuDB to work with MariaDB much simpler.
I could not tell from the original email, but is the change Sergei
made in
Hi, Michael!
On May 18, Michael Widenius wrote:
=== modified file 'sql/handler.h'
--- a/sql/handler.h 2011-05-16 11:05:45 +
+++ b/sql/handler.h 2011-05-18 16:26:30 +
@@ -161,8 +161,11 @@
*/
#define HA_KEY_SCAN_NOT_ROR 128
#define HA_DO_INDEX_COND_PUSHDOWN 256 /*
Hi, Michael!
On Apr 05, Michael Widenius wrote:
Here is finally a review of the microsecond patch.
Thanks!
=== modified file 'client/mysqltest.cc'
--- client/mysqltest.cc 2010-11-22 09:21:10 +
+++ client/mysqltest.cc 2011-02-23 17:26:02 +
@@ -7342,7 +7342,8 @@ int
Hi, Michael!
On May 19, Michael Widenius wrote:
+++ b/sql/sql_select.cc2011-05-18 16:26:30 +
@@ -16525,9 +16527,9 @@ test_if_skip_sort_order(JOIN_TAB *tab,OR
*/
DBUG_ASSERT (ref_key != (int) nr);
-bool is_covering= table-covering_keys.is_set(nr) ||
-
Hi, Michael!
On May 19, Michael Widenius wrote:
I don't remember any tests where you tested prepare stmt and
microseconds. Did you add such a test somewhere else?
I've run everything with --ps-protocol
-void Field_timestamp::set_time()
+int Field_timestamp::set_time()
{
THD
Hi, Michael!
There are more MariaDB-only error messages, I think you need to move all
of them.
On May 21, Michael Widenius wrote:
=== modified file 'sql/share/errmsg.txt'
--- a/sql/share/errmsg.txt2011-05-18 13:27:19 +
+++ b/sql/share/errmsg.txt2011-05-20 21:46:18 +
@@
Hi, MARK!
On May 26, MARK CALLAGHAN wrote:
I want to count errors by database user for IS.user_statistics. I have code
that does it in my_message_sql but hfisk thinks the counts might be
inflated. I don't understand the error reporting framework in MySQL so it is
possible that the counts are
Hi, erkan!
On May 30, erkan yanar wrote:
Moin,
I did some tmp-table tests. As it is told MariaDB is faster on
tmp-tables because of the Aria-Engine.
I've tried that, but without mysqlslap. Your table structure, few times more
rows,
mysql-5.1, mariadb-5.2 with aria tmp tables, mariadb-5.2
Hi, Sergey!
It looks safe.
If it's urgent, can you fix it please? (wrap in UNINIT_VAR)
If not - I'll do when I merge a set of bugfixes from 5.1.
On Jun 02, Sergey Petrunya wrote:
Current 5.3 fails as follows:
Hi, Vladislav!
On Jun 01, Vladislav Vaintroub wrote:
WL#77 - INSTALL PLUGIN *
new statements INSTALL PLUGIN * SONAME 'xxx'
and UNINSTALL PLUGIN * SONAME 'xxx'
Serg, while simplifying install plugin, do you think it could be
even better to get rid of PLUGIN * SONAME
1 - 100 of 2205 matches
Mail list logo
