Re: [Maria-developers] microslow-innodb ported to 5.1

2009-05-28 Thread Sergei Golubchik
Hi, Vadim! On May 27, Vadim Tkachenko wrote: Monty, I made merge proposal: https://code.launchpad.net/~maria-captains/maria/slow-extended-patch/+merge/6840 You can find patch there. Eh, I certainly hope it won't be merged in its current form. I didn't look too far, but even the very

Re: [Maria-developers] microslow-innodb ported to 5.1

2009-05-31 Thread Sergei Golubchik
. (this is similar to the WL#4906, that I've recently created) Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect /_/ /_/\_, /___/\___\_\___/ Sun

Re: [Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (sanja:2712) Bug#41098

2009-06-20 Thread Sergei Golubchik
really visible. What was wrong with http://lists.mysql.com/commits/66972 ? Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect

Re: [Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (knielsen:2703)

2009-06-22 Thread Sergei Golubchik
-- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect /_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028 ___/ Sonnenallee 1, 85551 Kirchheim-Heimstetten Geschäftsführer: Thomas Schroeder

Re: [Maria-developers] Storage Engine API changes

2009-07-08 Thread Sergei Golubchik
, and will probably be released together with foreign keys (but could go out earlier too). Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect

Re: [Maria-developers] Sphinx Storage engine for MariaDB

2009-08-06 Thread Sergei Golubchik
Hi, Arjen! On Aug 06, Arjen Lentz wrote: On 06/08/2009, at 4:48 PM, Sergei Golubchik wrote: On Jul 30, Michael Widenius wrote: I think we should compile all the plugin in (but not enable all by default), at least for now, to make MariaDB as easy to use as possible. On the opposite, I think

Re: [Maria-developers] Buildbot and compiler warnings

2009-08-11 Thread Sergei Golubchik
... Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect /_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028

Re: [Maria-developers] Buildbot and compiler warnings

2009-08-11 Thread Sergei Golubchik
not against fixing warnings :) I just don't like absolute rules. Joins are slow, no mutexes in the code, zero warnings when all -W* are enabled, and so on. Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com

Re: [Maria-developers] Sphinx Storage engine for MariaDB

2009-08-16 Thread Sergei Golubchik
Hi, Michael! On Aug 16, Michael Widenius wrote: Hi! Sergei == Sergei Golubchik ser...@pisem.net writes: cut We can't do this with the plugins, as we don't know for an old installation what plugins the user wanted to install. All of them, of course. If all plugins

Re: [Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (knielsen:2720)

2009-08-27 Thread Sergei Golubchik
@@global.example_enum_var = 'e2'; eh, I'm sorry, but do you check your .result files before committing ? :) Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server

Re: [Maria-developers] Userstats patch applied to MariaDB 5.2

2009-10-19 Thread Sergei Golubchik
per statement (or more). Without benchmark results one can only speculate whether it will affect users or not. Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer

Re: [Maria-developers] Userstats patch applied to MariaDB 5.2

2009-10-19 Thread Sergei Golubchik
Hi, MARK! On Oct 19, MARK CALLAGHAN wrote: On Mon, Oct 19, 2009 at 5:52 AM, Sergei Golubchik ser...@pisem.net wrote: On Oct 19, Michael Widenius wrote: I just finished applying / modifying / rewriting the userstats patch to MariaDB 5.2 and will commit this in a moment. I wonder

Re: [Maria-developers] New (by Bothorsen): Provide key cache statistics (58)

2009-10-22 Thread Sergei Golubchik
, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect /_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028 ___/ Sonnenallee 1, 85551

Re: [Maria-developers] Additional info about engines

2009-11-03 Thread Sergei Golubchik
won't need to track manually what he can load where. Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect /_/ /_/\_, /___/\___\_\___/ Sun Microsystems

Re: [Maria-developers] User-defined variables set that call UDFs (64)

2009-11-15 Thread Sergei Golubchik
assigned to. Regards / Mit vielen GrЭъen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect /_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB MЭnchen 161028

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-01 Thread Sergei Golubchik
no longer the case, you need to remove the whole ifdef block, not only the assert. PBXT XA can be disabled by setting pbxt_support_xa=0, it is enabled by default. Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-01 Thread Sergei Golubchik
, Sergei Golubchik wrote: On Dec 01, Paul McCullagh wrote: This patch changes MariaDB code in one case: File handler.cc, Line 1591 DBUG_ASSERT(total_ha_2pc == (ulong) opt_bin_log+1); // only InnoDB and binlog This line has been commented out, because the assertions fails now that PBXT supports

Re: [Maria-developers] [Merge] lp:~paul-mccullagh/maria/maria-pbxt-rc3 into lp:maria

2009-12-02 Thread Sergei Golubchik
-- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect /_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028 ___/ Sonnenallee 1, 85551 Kirchheim

Re: [Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (knielsen:2785)

2009-12-13 Thread Sergei Golubchik
Hi, knielsen! Oh, I sincerely hope you don't think of pushing *that*. The whole damn boost inside mariadb bzr tree ? What's the next step, libc ? On Dec 13, kniel...@knielsen-hq.org wrote: #At lp:maria 2785 kniel...@knielsen-hq.org2009-12-13 [merge] Merge OQGraph into latest

Re: [Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (knielsen:2785)

2009-12-13 Thread Sergei Golubchik
as an external dependency should be fine. At least until there will be an indication that it's not. Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server

Re: [Maria-developers] commit performance when the binlog is enabled

2009-12-28 Thread Sergei Golubchik
about anyway :) Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect /_/ /_/\_, /___/\___\_\___/ Sun Microsystems GmbH, HRB München 161028

Re: [Maria-developers] commit performance when the binlog is enabled

2009-12-29 Thread Sergei Golubchik
Grüßen, Sergei P.S. Disclaimer: besides the last statement everything else is just my speculation about how innodb hot backup works. -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com / /|_/ / // /\ \/ /_/ / /__ Principal Software Engineer/Server Architect

Re: [Maria-developers] commit performance when the binlog is enabled

2009-12-29 Thread Sergei Golubchik
Hi, MARK! On Dec 29, MARK CALLAGHAN wrote: On Mon, Dec 28, 2009 at 9:20 AM, Sergei Golubchik ser...@pisem.net wrote: trn1 start transaction; insert t1 select * from t2; trn1 commit; trn1 ... xa_prepare() ... trn2 start transaction; insert t2 values (1); commit; trn2 xa_prepare

Re: [Maria-developers] Rev 4: Added wrapper scripts for automated runs of sql-bench

2009-12-29 Thread Sergei Golubchik
privileges. +# We use killall -9, which can cause severe side effects! You can use killall -u `whoami` not perfect, but still much safer. Regards / Mit vielen Grüßen, Sergei -- __ ___ ___ __ / |/ /_ __/ __/ __ \/ / Sergei Golubchik s...@sun.com

Re: [Maria-developers] commit performance when the binlog is enabled

2009-12-30 Thread Sergei Golubchik
Hi, MARK! On Dec 29, MARK CALLAGHAN wrote: On Tue, Dec 29, 2009 at 11:23 AM, Sergei Golubchik ser...@pisem.net wrote: Is this a potential problem? * order of transactions in binlog don't commit record order for InnoDB in transaction log * binlog rotation occurs * last binlog has XIDs 1, 3

Re: [Maria-developers] Patch for Windows problem with setting TZ

2010-01-16 Thread Sergei Golubchik
Hi, Kristian! On Jan 16, Kristian Nielsen wrote: Hi, Alex Budovski has done some work to debug why some tests (binlog tests in particular) are failing on Windows, and found that this is because mysql-test-run.pl set the TZ variable. This interacts poorly with the Windows Operating System.

Re: [Maria-developers] Ideas for improving MariaDB/MySQL replication

2010-01-22 Thread Sergei Golubchik
Hi, Alex! On Jan 22, Alex Yurchenko wrote: So when refactoring replication code and API we suggest to think of replication as of redundancy service and establish a general API for such service that can be utilized by different implementations with different qualities of service. In other

[Maria-developers] LOCK_plugin in pbxt_init()

2010-02-28 Thread Sergei Golubchik
Hi, Paul, I was backporting libservices to MariaDB, and with a related test case found a bug in MariaDB - mutexes were locked in the wrong order. I've fixed that some time ago in mysql-next, so I took the fix from there - the fix was to not lock LOCK_plugin over the plugin initialization code.

[Maria-developers] WL enhancements

2010-03-03 Thread Sergei Golubchik
Hi. That's a rough list of enhancement ideas for worklog. Some of them I'm going to do (but not all). Feel free to suggest more or get rid of WL, use X instead, just don't forget the because of part. report: easy to do tasks make it to provide a list of low-handing fruits, tasks that

Re: [Maria-developers] [Bug 544173] [NEW] Server crash for multi-engine transaction with binlog disabled

2010-03-26 Thread Sergei Golubchik
Hi, MARK! On Mar 25, MARK CALLAGHAN wrote: On Wed, Mar 24, 2010 at 5:28 PM, Arjen Lentz ar...@openquery.com wrote: This test is as important as the above crash, because multi-engine transactions are something people will be using and thus relying on correctly working I won't use this.

Re: [Maria-developers] Review of 5.2 pluggable-auth tree

2010-03-26 Thread Sergei Golubchik
Hi, Monty! See the answers below: (no reply means ok, changed) On Mar 25, Michael Widenius wrote: === modified file 'client/mysql.cc' + /** + An example of mysql_authentication_dialog_ask callback. + + The C function with the name mysql_authentication_dialog_ask, if exists, +

Re: [Maria-developers] Review of 5.2 pluggable-auth tree

2010-03-27 Thread Sergei Golubchik
Hi, Monty! On Mar 26, Sergei Golubchik wrote: Hi, Monty! See the answers below: (no reply means ok, changed) On Mar 25, Michael Widenius wrote: And here's a patch that implements your review comments. Regards, Sergei === modified file 'client/mysql.cc' *** client/mysql.cc 2010-03

Re: [Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2834)

2010-03-28 Thread Sergei Golubchik
Hi, Michael! On Mar 28, Michael Widenius wrote: #At lp:maria based on revid:ser...@pisem.net-20100324221239-7bj3zf8yv6bgclx1 2834 Michael Widenius2010-03-28 Fixed compiler warnings and sporadic failures in test cases Hey, Monty, may I ask what warnings did you get with gcc

Re: [Maria-developers] Review of 5.2 pluggable-auth tree

2010-03-29 Thread Sergei Golubchik
Hi, Oleksandr! On Mar 29, Oleksandr Byelkin wrote: [skip] + #ifdef _WIN32 In the rest of my_global.h we use __WIN__ Wouldn't it be better to use the same constant everywhere? Yes, it would. And this constant should be _WIN32, __WIN__ was historically used, but it's incorrect - as was

Re: [Maria-developers] Rev 2734: Maria WL#61

2010-03-30 Thread Sergei Golubchik
Hi, Oleksandr! On Mar 29, Oleksandr Byelkin wrote: +#define PLUGIN_MATURITY_TEST 1 +#define PLUGIN_MATURITY_ALPHA 2 +#define PLUGIN_MATURITY_BETA 3 +#define PLUGIN_MATURITY_GAMMA 4 +#define PLUGIN_MATURITY_RELEASE 5 release ? or production or stable ? there can be an alpha release, or

Re: [Maria-developers] [Bug 544173] [NEW] Server crash for multi-engine transaction with binlog disabled

2010-03-31 Thread Sergei Golubchik
Hi, Paul! On Mar 31, Paul McCullagh wrote: On Mar 25, 2010, at 10:24 PM, Sergei Golubchik wrote: Hi, MARK! On Mar 25, MARK CALLAGHAN wrote: On Wed, Mar 24, 2010 at 5:28 PM, Arjen Lentz ar...@openquery.com wrote: This test is as important as the above crash, because multi-engine

Re: [Maria-developers] oqgraph in mariadb - integration work

2010-03-31 Thread Sergei Golubchik
Hi, Arjen! On Mar 31, Arjen Lentz wrote: Hi Kristian On 31/03/2010, at 11:22 PM, Kristian Nielsen wrote: So my preference would be to make it a built-in/regular as it will make adopton and subsequent use much easier. Understand, unfortunately I am out of cycles to look into changing this

Re: [Maria-developers] Rev 2761: Maria WL#61 in file:///Users/bell/maria/bzr/work-maria-5.2-engine-backup/

2010-04-01 Thread Sergei Golubchik
Hi, sanja! On Mar 30, sa...@askmonty.org wrote: revno: 2761 revision-id: sa...@askmonty.org-20100330203255-1pyz892qsqg1liov parent: sa...@askmonty.org-20100330123515-4p8q03xccl3d6k59 committer: sa...@askmonty.org branch nick:

Re: [Maria-developers] bzr commit into Mariadb 5.2 (igor:2742) WL#85

2010-04-04 Thread Sergei Golubchik
Hi, Igor! First, just to make it clear - you asked me to review the post-review fixes patch, so that's what I did, I looked at how you implemented Monty comments, I did not review the partitioned key caches feature - it would need much more time - and I don't understand all of it. See below, I

Re: [Maria-developers] Storage Engine Summit 2010

2010-04-25 Thread Sergei Golubchik
Hi, all! Thank you for participating, the minutes and presentations are now online: http://askmonty.org/wiki/Storage_Engine_Summit_2010 Regards, Sergei On Mar 29, Sergei Golubchik wrote: Hi, all! We are happy to announce the *Storage Engine Summit* 2010. This traditional one-day

Re: [Maria-developers] Where is the wiki page for coordinating semantics of CREATE TABLE options?

2010-04-28 Thread Sergei Golubchik
Hi, Henrik! On Apr 27, Henrik Ingo wrote: Serg At the storage engine meeting, we decided to host a wiki page where all engines can document their CREATE TABLE options, so that semantics of options can remain consistent. Does this wiki page exist yet? No, it does not Regards, Sergei

Re: [Maria-developers] Windows installer

2010-05-10 Thread Sergei Golubchik
Hi, Bo! On May 10, Bo Thorsen wrote: Hi everyone, I have been looking at getting our binary windows distribution back on track. One of the options would be to create the zip file like we did earlier. Another way would be to create a proper windows installer. For this, there are several

Re: [Maria-developers] Summary of discussion about MariaDB future and release plans

2010-05-10 Thread Sergei Golubchik
Hi, Henrik! On May 05, Henrik Ingo wrote: I think we very nearly made the same mistake with 5.2. We had a feature list, and while some of them were rolling, we also had features that were decided in advance that they _must_ be pushed at a certain date. I strongly believe this is wrong.

[Maria-developers] per-partition attributes in the CREATE TABLE

2010-05-11 Thread Sergei Golubchik
Hi, we've talked about engine attributes in the CREATE TABLE, and that one should be able to specify them per partition as well. Now, thinking about it, I'm not quite sure what the semantics shuld be. What is your use case ? How do you want them to work ? I see different possibilities. Say,

Re: [Maria-developers] per-partition attributes in the CREATE TABLE

2010-05-11 Thread Sergei Golubchik
Hi, Henrik! On May 11, Henrik Ingo wrote: On Tue, May 11, 2010 at 12:05 PM, Sergei Golubchik ser...@pisem.net wrote: we've talked about engine attributes in the CREATE TABLE, and that one should be able to specify them per partition as well. Now, thinking about it, I'm not quite sure

Re: [Maria-developers] Ideas for improving MariaDB/MySQL replication

2010-05-14 Thread Sergei Golubchik
Hi, Stewart! On May 14, Stewart Smith wrote: On Thu, 13 May 2010 16:36:41 +0200, Sergei Golubchik s...@askmonty.org wrote: * not everything can be replicated at every level, for example table creation cannot be replicated row-based, InnoDB changes cannot be replicated

Re: [Maria-developers] Time to remove sql_select.cc:find_best() ?

2010-06-02 Thread Sergei Golubchik
Hi, Timour! On Jun 02, Timour Katchaounov wrote: Hi, I was looking today at some optimizer code, and bumped again into sql_select.cc:find_best(). We have been using the greedy optimizer for years, and this function has been dead code for a while, isn't it time to remove it? The less

Re: [Maria-developers] Time to remove sql_select.cc:find_best() ?

2010-06-02 Thread Sergei Golubchik
Hi, Timour! On Jun 02, Timour Katchaounov wrote: Sergei, Hi, Timour! On Jun 02, Timour Katchaounov wrote: Hi, I was looking today at some optimizer code, and bumped again into sql_select.cc:find_best(). We have been using the greedy optimizer for years, and this function has been dead

Re: [Maria-developers] [Commits] Rev 2802: few small MySQL bugs/issues that impact the engines, as discussed in the SE summit in http://bazaar.launchpad.net/~maria-captains/maria/5.2/

2010-06-03 Thread Sergei Golubchik
Hi, Monty! Thanks for the review! See my replies below. On Jun 03, Michael Widenius wrote: At http://bazaar.launchpad.net/~maria-captains/maria/5.2/ revno: 2802 few small MySQL bugs/issues that impact the engines, as

Re: [Maria-developers] [Bug 314570] Re: update is not changing internal auto increment value

2010-06-04 Thread Sergei Golubchik
Hi, Michael! On Jun 04, Michael Widenius wrote: hi! Sergei == Sergei ser...@pisem.net writes: Sergei ** Changed in: maria SergeiImportance: Undecided = Low Sergei -- Sergei update is not changing internal auto increment value Sergei https://bugs.launchpad.net/bugs/314570

Re: [Maria-developers] Patch to build xtradb and federatedx statically on Windows

2010-06-09 Thread Sergei Golubchik
Hi, Bo! On Jun 09, Bo Thorsen wrote: Hi everyone, Recently, we found out that xtradb and federatedx were compiled as plugins on Windows. This is not correct because they are core storage engines and should be linked statically instead. Heh, that's funny. Because yesterday on the call we

Re: [Maria-developers] Question about License...

2010-06-09 Thread Sergei Golubchik
Hi, Mateusz! If you want a reliable answer you need to contact a lawyer, not the mailing list. But with a usual disclaimer (I'm not a lawyer) I suppose that if you want to keep your engine closed source you have to contact Oracle (not MariaDB) and buy a license. On Jun 09, Mateusz Matan wrote:

Re: [Maria-developers] [Commits] Rev 2861: fix questionable UNIV_EXPECT's in the xtradb that confused old gcc. in http://bazaar.launchpad.net/~maria-captains/maria/5.1/

2010-06-16 Thread Sergei Golubchik
parent: kniel...@knielsen-hq.org-20100531084334-81f5z74nxx6v9zww committer: Sergei Golubchik ser...@pisem.net branch nick: 5.1 timestamp: Wed 2010-06-09 13:53:51 +0200 message: fix questionable UNIV_EXPECT's in the xtradb that confused old gcc. I assume you have cc: the XtraDB

[Maria-developers] worklog update

2010-06-28 Thread Sergei Golubchik
Hi. A quick summary of recent changes in WorkLog: * there are no archived tasks anymore. All cancelled and closed tasks are inactive, others are active * guest users shouldn't be able to update WL tasks now. * private field dissapeared, you won't see Private: yes anymore. * major rework of the

Re: [Maria-developers] Ideas for improving MariaDB/MySQL replication

2010-07-05 Thread Sergei Golubchik
Hi, Kristian! API, eliminating lots of class definitions and accessor functions. Though arguably it wouldn't really simplify the API, as the complexity would just be in understanding the THD class. For now, the API is proposed without exposing the THD class. (Similar encapsulation

Re: [Maria-developers] question on MariaDB and end_bulk_insert

2010-07-22 Thread Sergei Golubchik
Hi, Zardosht! On Jul 06, Zardosht Kasheff wrote: Oops, it turns out the function signature is different from MySQL. This tripped us up. Hm, this is arguably a bug. We should not have changed an API. I'll fix it. Regards, Sergei -Zardosht On Tue, Jul 6, 2010 at 3:15 PM, Zardosht

Re: [Maria-developers] wl#127 - changes to mtr for sphinx

2010-08-05 Thread Sergei Golubchik
Hi, Kristian! On Aug 04, Kristian Nielsen wrote: Sergei Golubchik ser...@pisem.net writes: My main comment is that there should be some documentation of the My::Suite class, as I write in a comment below. I'll add it, thanks. Other than that I think it is ok to push. I have a number

Re: [Maria-developers] wl#127 - changes to mtr for sphinx

2010-08-05 Thread Sergei Golubchik
Hi, Kristian! On Aug 05, Kristian Nielsen wrote: Sergei Golubchik s...@askmonty.org writes: Other than that I think it is ok to push. I have a number of small remarks inline below, you can fix what you agree with and ignore the rest. There are also a couple of questions to check

Re: [Maria-developers] [Commits] Rev 2835: added a sphinxse test suite in http://bazaar.launchpad.net/~maria-captains/maria/5.2/

2010-08-06 Thread Sergei Golubchik
Hi, Kristian! On Aug 06, Kristian Nielsen wrote: s...@askmonty.org writes: === added file 'mysql-test/suite/sphinx/sphinx.test' --- a/mysql-test/suite/sphinx/sphinx.test 1970-01-01 00:00:00 + +++ b/mysql-test/suite/sphinx/sphinx.test 2010-08-06 13:11:37 + @@ -0,0 +1,30 @@

[Maria-developers] rename maria to aria in 5.2

2010-08-07 Thread Sergei Golubchik
Hi, I'v renamed everything user-visible (error messages, variables, command-line utilites, etc). Do you want me to rename just *everything* ? file names, function names, etc ? I mean, all internal stuff. It wouldn't add much value, and would complicate the merges. On the other hand, it'd be

Re: [Maria-developers] [Commits] Rev 2898: generalization of mtr to support suite.pm extensions

2010-08-11 Thread Sergei Golubchik
Hi, Kristian Would you like to look once again at the mtr patch ? I've moved it to 5.1 and added one more feature (SUITENAME_COMBINATIONS, see below) to be able to incorporate Monty's changes for the innodb_plugin in a sane way. I've removed auto-creation of my.cnf options by mere mentioning,

Re: [Maria-developers] [Commits] Rev 2898: generalization of mtr to support suite.pm extensions: in http://bazaar.launchpad.net/~maria-captains/maria/5.1/

2010-08-12 Thread Sergei Golubchik
Hi, Kristian! On Aug 11, Kristian Nielsen wrote: + + if (! defined($option) and $ENV{$option_name}) { This will prevent an option to be set from an environment variable with the value 0. (Just a remark, I'm not sure if that is a problem or not though.) Fixed, thanks. It's a nice

Re: [Maria-developers] Get rid of all 32 bit Visual Studio compiler warnings

2010-08-23 Thread Sergei Golubchik
Hi, Bo! It looks ok to me, but see below. On Aug 18, Bo Thorsen wrote: === modified file 'libmysqld/CMakeLists.txt' --- libmysqld/CMakeLists.txt 2010-07-01 14:35:50 + +++ libmysqld/CMakeLists.txt 2010-07-08 14:34:03 + @@ -95,6 +95,11 @@ FOREACH(rpath

Re: [Maria-developers] Architecture review of MWL#116 Efficient group commit for binary log

2010-09-07 Thread Sergei Golubchik
Hi, Kristian! On Sep 06, Kristian Nielsen wrote: However, as I revisited the algorithm, it occured to me that it is in any case better to wake up threads individually as soon as commit_ordered() has finished. This way, the first threads in the queue are free to continue doing useful work

Re: [Maria-developers] Architecture review of MWL#132 Transaction coordinator plugin

2010-09-08 Thread Sergei Golubchik
Hi, Kristian! On Sep 07, Kristian Nielsen wrote: Sergei Golubchik s...@askmonty.org writes: Now, WL#132 - Transaction coordinator plugin Wouldn't it be simpler to create only group_log_xid() interface, no log_and_order() or log_xid() ? The tc plugin gets the list in group_log_xid

[Maria-developers] Phone home

2010-09-09 Thread Sergei Golubchik
Hi. So, Phone Home or MySQL feedback daemon or better name wanted feature. It is something that can be installed together with MariaDB, it will gather different statistic about how MariaDB is used and will send this information anonymously to mariadb.org. Not unlike the Uptimes Project or Debian

Re: [Maria-developers] Phone home

2010-09-10 Thread Sergei Golubchik
Hi, Adam! On Sep 09, Adam M. Dutko wrote: So, Phone Home or MySQL feedback daemon or better name wanted feature. Maybe call it Butler ??? Just a thought... :) Why? Not unlike the Uptimes Project or Debian Popularity Contest. Opt-in only with an easy disable option after opting

[Maria-developers] ./configure report

2010-09-15 Thread Sergei Golubchik
Hi. For a while, I had a small personal gripe that it is not easy to see what plugins are configured to be built and how. That is, I know where to look (configure prints all that when working, but not alphabetically, so a particular plugin name isn't easy to spot) but I had to explain this to

Re: [Maria-developers] Latest libmysqld.so patch

2010-10-05 Thread Sergei Golubchik
Hi, Kristian! On Sep 30, Kristian Nielsen wrote: Sergei Golubchik s...@askmonty.org writes: Thanks for review! What I would now like to do is to discuss how to proceeed (where to push this basically). On the one hand, the patch got rather more intrusive than I first wanted. The main

Re: [Maria-developers] Transactional INFORMATION_SCHEMA / status variables?

2010-10-06 Thread Sergei Golubchik
Hi, Kristian! On Oct 06, Kristian Nielsen wrote: Would it make sense to have transactional behaviour for status variables, and/or information_schema tables? Or does this break the code and/or user expectations too much? The motivation is to follow up on MWL#116, group commit, which

Re: [Maria-developers] Performance problem: need index-based access when have only non-sargable conditions

2010-10-13 Thread Sergei Golubchik
Hi, Sergey! On Oct 10, Sergey Petrunya wrote: I was asked about this performance problem: consider a query (so was I, so was Igor, and may be others :) select * from tbl where tbl.key like '%foo%' Table records are big, much larger than the length of the key. LIKE condition is very

Re: [Maria-developers] expose key_blocks_warm to show status/I_S

2010-10-19 Thread Sergei Golubchik
Hi, Oli! On Oct 18, Oli Sennhauser wrote: shell diff mysqld.cc.orig mysqld.cc 7503a7504 {Key_blocks_warm, (char*) offsetof(KEY_CACHE, warm_blocks), SHOW_KEY_CACHE_LONG}, Thanks. I'll add it to mariadb-5.1. Regards, Sergei P.S.: Next time, please, use diff -up, not just diff.

Re: [Maria-developers] Buildbot builds/tests innodb_plugin.so, is that intentional?

2010-10-19 Thread Sergei Golubchik
Hi, Sergey! On Oct 17, Sergey Petrunya wrote: Hello, I've noticed that centos5-amd64-minimal builds innodb plugin for MariaDB 5.2 and 5.3 (didn't check 5.1) Right. Which shows we're building the plugin. Do we really need this? Yes :) We have users for it, and we'd better check that

Re: [Maria-developers] [Commits] Rev 2958: better fix for MySQL bugs in http://bazaar.launchpad.net/~maria-captains/maria/5.1/

2010-10-24 Thread Sergei Golubchik
Hi, Zardosht! First: please send questions like this to the list, not only to me. I wanted to discuss this with Sergey Petrunia and had to paste this on irc. Anyway, On Oct 22, Zardosht Kasheff wrote: Hello Sergei, One of the problems we at Tokutek have run into with the optimizer many

Re: [Maria-developers] Why do we need fsync() in commit() in internal two-phase commit?

2010-10-26 Thread Sergei Golubchik
Hi, Kristian! On Oct 26, Kristian Nielsen wrote: Currently, when an InnoDB/XtraDB transaction is committed with the binlog enabled, we do three fsync()'s: 1. Inside prepare() in InnoDB 2. When writing to the binlog 3. Inside commit() in InnoDB ... why do we need the fsync() in commit()?

Re: [Maria-developers] [Commits] Rev 2958: better fix for MySQL bugs in http://bazaar.launchpad.net/~maria-captains/maria/5.1/

2010-10-26 Thread Sergei Golubchik
Hi, Zardosht! On Oct 24, Zardosht Kasheff wrote: Thanks Sergei, I will CC maria-developers from now on. I understand why this cannot go into 5.1. I was more interested in knowing if this is logically correct, which it seems to be. I hope in the long term (MariaDB 5.3 and beyond) that the

Re: [Maria-developers] [Commits] Rev 2951: WL#12 - MariaDB User Feedback (a.k.a. Phone Home) plugin

2010-10-28 Thread Sergei Golubchik
Hi, Michael! On Oct 27, Michael Widenius wrote: Sergei == Sergei Golubchik s...@askmonty.org writes: +++ b/plugin/feedback/sender_thread.cc 2010-09-30 14:24:31 + ... + if (thd) // for nicer SHOW PROCESSLIST +thd-set_query(const_castchar*(url-url()), url-url_length

[Maria-developers] gcc -Wframe-larger-than

2010-10-30 Thread Sergei Golubchik
Hi, Just noticed that gcc has a warning option -Wframe-larger-than=LEN that makes gcc to warn about functions with stack frames larger than LEN. Considering a recent issue when we had a 130K structure on the stack (which did overflow the stack in some cases), it may be a good idea to enable this

Re: [Maria-developers] MariaDB 5.2.3

2010-11-11 Thread Sergei Golubchik
Hi, Daniel! On Nov 10, Daniel Bartholomew wrote: All, I've created the download, release notes, and changelog pages for MariaDB 5.2.3: http://askmonty.org/wiki/MariaDB:Download:MariaDB_5.2.3 http://kb.askmonty.org/v/mariadb-523-release-notes

Re: [Maria-developers] [Commits] Rev 89: MBug#674413: better fix following review: clear sql_mode rather than add every column explicitly. in http://bazaar.launchpad.net/~maria-captains/maria/5.1

2010-11-20 Thread Sergei Golubchik
Hi, knielsen! On Nov 20, kniel...@knielsen-hq.org wrote: At http://bazaar.launchpad.net/~maria-captains/maria/5.1 revno: 89 revision-id: kniel...@knielsen-hq.org-20101120084531-x0hbb64q9x0yj376 parent:

Re: [Maria-developers] MySQL: THDVAR in full-text parser

2010-11-26 Thread Sergei Golubchik
Hi, 0x00F6! First: please send questions like this to maria-developers@lists.launchpad.net it's a public mailing list dedicated to MySQL and MariaDB internals, source code, and related things. I am subscribed, so I'll see you mail there, and you may be sure I will, because it won't be

Re: [Maria-developers] problem with partitioning and our storage engine in 5.2

2010-12-09 Thread Sergei Golubchik
Hi, Zardosht! On Dec 08, Zardosht Kasheff wrote: We always thought that stats.records was meant to be an estimate, and that an estimate of 0 was ok even if the table was non-empty. We were reporting that stats.records was 0 even though the table was non-empty. Is this assumption wrong?

Re: [Maria-developers] pre-allocating binlog to speed up sync_binlog=1

2010-12-13 Thread Sergei Golubchik
Hi, Arjen! [moving to the public list] On Dec 14, Arjen Lentz wrote: Hi all Can we adopt/implement http://forge.mysql.com/worklog/task.php?id=4925 in MariaDB? The benchmark info is in the item, and looks quite interesting. The author tested it using a separate tool to preallocate the

Re: [Maria-developers] [Commits] Rev 2959: New table creation/renaming block added if old encoded table present. in file:///home/bell/maria/bzr/work-maria-5.1-CREATE/

2010-12-20 Thread Sergei Golubchik
Hi, sanja! On Oct 22, sa...@askmonty.org wrote: At file:///home/bell/maria/bzr/work-maria-5.1-CREATE/ revno: 2959 revision-id: sa...@askmonty.org-20101021220232-eqso4ey46985wfzf parent:

Re: [Maria-developers] Logoff trigger for MariaDB

2010-12-27 Thread Sergei Golubchik
Hi, Oli! On Dec 11, Oli Sennhauser wrote: Hi all, As suggested by Sergei we should discuss this here. Copying the login trigger stuff to a place in the code where I thought it makes sense I have created a logout trigger. This gives the capability to track a session from its beginning to

Re: [Maria-developers] [Commits] Rev 2999: Speed up `mtr --parallel=lots` by scheduling some slow tests earlier. in http://bazaar.launchpad.net/~maria-captains/maria/5.1

2011-01-03 Thread Sergei Golubchik
Hi, knielsen! On Jan 03, kniel...@knielsen-hq.org wrote: At http://bazaar.launchpad.net/~maria-captains/maria/5.1 Hm. Why do you prefer to add a dummy include file to every long test, instead of using a separate file, like disabled.def ? I think it'd be easier to maintain in a separate file,

Re: [Maria-developers] Optimization about count(*) of mysql 5.1.38

2011-01-24 Thread Sergei Golubchik
Hi, Lichao! On Jan 24, Lichao Xie wrote: Hi, Sergei! I'm sorry, my English is not so good! There is no a API to get the exact records in a range, but the API can help to improve performance for the case: select count(*) from t where id 10 and id 100; I want to know why there is no

Re: [Maria-developers] MariaDB and MySQL 5.5

2011-02-11 Thread Sergei Golubchik
Hi, MARK! On Feb 10, MARK CALLAGHAN wrote: When will there be a MariaDB branch based on MySQL 5.5? I want to use that as the basis for the 5.5 version of the Facebook patch. Give me a month. I started the merge, but then had to switch to an urgent project, I have the merge about, say, 80%

Re: [Maria-developers] [Commits] Rev 3014: New table creation/renaming block added if old encoded table present. in file:///home/bell/maria/bzr/work-maria-5.1-CREATE/

2011-03-02 Thread Sergei Golubchik
Hi, sanja! On Jan 13, sa...@askmonty.org wrote: revno: 3014 revision-id: sa...@askmonty.org-20110113180607-e5hc8zuugxxjtn6k parent: pser...@askmonty.org-20110112083018-90rw058f00uslvoz committer: sa...@askmonty.org branch nick:

Re: [Maria-developers] Merge Percona patch MWL#47 into mariadb 5.2-percona.

2011-03-02 Thread Sergei Golubchik
Hi, Kristian! A fourth option could be to take MySQL's version and add --binlog-annotate-rows-events and --replicate-annotate-rows-events options, and make a slave read MWL#47 annotation event as a rows_query_log_event. This option is basically the opposite of yours third option. In both cases

Re: [Maria-developers] Pushing/merging sample my.cnf

2011-03-24 Thread Sergei Golubchik
Hi, Haidong! On Mar 18, Haidong Ji wrote: All, I've created my trunk on launchpad for MariaDB, and am ready to make some updates to the sample my.cnf file(s) packaged with MariaDB. I have a few questions regarding how to proceed: 1. I've seen work log creation and assignment in MariaDB

Re: [Maria-developers] Summary of the storage engine API changes for group commit

2011-04-06 Thread Sergei Golubchik
Hi, Kristian! On Apr 06, Kristian Nielsen wrote: As promised, here is a summary of the changes to the storage engine API that I made as part of group commit. Two new handlerton methods are added: void (*prepare_ordered)(handlerton *hton, THD *thd, bool all); void

Re: [Maria-developers] MariaDB/MySQL error code issue

2011-04-19 Thread Sergei Golubchik
Hi, Kristian! On Apr 18, Kristian Nielsen wrote: For merging MySQL into MariaDB, we need to work out what to do about error code. I think we have these options: 1. Cooperate with MySQL@Oracle, so that whenever we add an error code in MariaDB, the corresponding code is also reserved in

Re: [Maria-developers] A serious merge bug in 5.3.

2011-04-24 Thread Sergei Golubchik
Hi, Igor! On Apr 24, Igor Babaev wrote: When debugging I discovered the following bad code in sql_select.cc of the current 5.3 tree: tmp= table-file-read_time(key, 1, min(tmp,s-worst_seeks)-1); = ! ? tmp*=

Re: [Maria-developers] A serious merge bug in 5.3.

2011-04-24 Thread Sergei Golubchik
Hi, Igor! On Apr 24, Igor Babaev wrote: On 04/24/2011 01:51 AM, Sergei Golubchik wrote: In 5.3, record_count* is moved to a separate line, so it should just be tmp= min(tmp,s-worst_seeks); But it uses table-file-read_time(). Which is defined as virtual double read_time

Re: [Maria-developers] feature documentation

2011-05-11 Thread Sergei Golubchik
Hi, Kurt! On May 11, Kurt von Finck wrote: IMO, the Knowledgbase entry for the virtual columns http://kb.askmonty.org/v/virtual-columns is among the best and most useful entries we have. It describes the feature, suggests use cases and demonstrates functionality in a straightforward

Re: [Maria-developers] [Commits] Rev 2988: Added directories with .dylib files to DYLD_LYBRARY_PATH to allow plugin to use them. in file:///Users/bell/maria/bzr/work-maria-5.3-machandlersocket/

2011-05-13 Thread Sergei Golubchik
Hi, Oleksandr! On May 13, Oleksandr Byelkin wrote: revno: 2988 revision-id: sa...@askmonty.org-20110513150858-ba2sowmbv1l39xxm parent: sa...@askmonty.org-20110512150136-5yzagaev1ssohykp committer: Oleksandr Byelkin sa...@askmonty.org branch nick: work-maria-5.3-machandlersocket timestamp:

Re: [Maria-developers] proposed patches for MWL#113: many clustered keys (not only primary)

2011-05-18 Thread Sergei Golubchik
Hi, Zardosht! On May 18, Zardosht Kasheff wrote: Hello Monty, Thank you for your feedback on the four diffs and for approving them. This makes getting TokuDB to work with MariaDB much simpler. I could not tell from the original email, but is the change Sergei made in

Re: [Maria-developers] [Commits] Rev 2994: Original idea from Zardosht Kasheff to add HA_CLUSTERED_INDEX in lp:maria/5.3

2011-05-19 Thread Sergei Golubchik
Hi, Michael! On May 18, Michael Widenius wrote: === modified file 'sql/handler.h' --- a/sql/handler.h 2011-05-16 11:05:45 + +++ b/sql/handler.h 2011-05-18 16:26:30 + @@ -161,8 +161,11 @@ */ #define HA_KEY_SCAN_NOT_ROR 128 #define HA_DO_INDEX_COND_PUSHDOWN 256 /*

Re: [Maria-developers] Review of microsecond patch

2011-05-19 Thread Sergei Golubchik
Hi, Michael! On Apr 05, Michael Widenius wrote: Here is finally a review of the microsecond patch. Thanks! === modified file 'client/mysqltest.cc' --- client/mysqltest.cc 2010-11-22 09:21:10 + +++ client/mysqltest.cc 2011-02-23 17:26:02 + @@ -7342,7 +7342,8 @@ int

  1   2   3   4   5   6   7   8   9   10   >