[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2700)

2009-06-03 Thread Sergey Petrunia
#At lp:maria based on revid:kniel...@knielsen-hq.org-20090511153130-ww69mb5imjbrjht4 2700 Sergey Petrunia 2009-05-19 Remove unused enum member modified: sql/opt_range.cc === modified file 'sql/opt_range.cc' --- a/sql/opt_range.cc 2009-05-06 12:03:24 + +++ b/sql

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2701)

2009-06-03 Thread Sergey Petrunia
#At lp:maria based on revid:pser...@askmonty.org-20090518201557-e56621ppwmy13pi7 2701 Sergey Petrunia 2009-05-19 Added comments modified: sql/opt_range.h === modified file 'sql/opt_range.h' --- a/sql/opt_range.h 2009-05-06 12:03:24 + +++ b/sql/opt_range.h 2009-05

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2700)

2009-06-03 Thread Sergey Petrunia
#At lp:maria based on revid:kniel...@knielsen-hq.org-20090511153130-ww69mb5imjbrjht4 2700 Sergey Petrunia 2009-05-15 Remove unused enum member modified: sql/opt_range.cc per-file messages: sql/opt_range.cc Remove unused enum member === modified file 'sql/opt_range.cc' --- a/sql

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2706)

2009-06-03 Thread Sergey Petrunia
#At lp:maria based on revid:kniel...@knielsen-hq.org-20090522175325-xpwm83ilnhqoqjz0 2706 Sergey Petrunia 2009-06-03 MWL#17: Table elimination - First code. Elimination works for simple cases, passes the testsuite. - Known issues: = No elimination is done

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2708)

2009-06-03 Thread Sergey Petrunia
#At lp:maria based on revid:kniel...@knielsen-hq.org-20090602110359-n4q9gof38buucrny 2708 Sergey Petrunia 2009-06-03 [merge] Merge MWL#17 with maria/5.1 added: mysql-test/r/table_elim.result mysql-test/t/table_elim.test modified: sql/sql_select.cc

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2709)

2009-06-15 Thread Sergey Petrunia
#At lp:maria based on revid:pser...@askmonty.org-20090603182330-ll3gc91iowhtgb23 2709 Sergey Petrunia 2009-06-07 [merge] Merge MWL#17: Table elimination modified: sql/sql_select.cc === modified file 'sql/sql_select.cc' --- a/sql/sql_select.cc 2009-06-03 13:10:45 +

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2707)

2009-06-15 Thread Sergey Petrunia
#At lp:maria based on revid:pser...@askmonty.org-20090603131045-c8jqhwlanli7eimv 2707 Sergey Petrunia 2009-06-07 MWL#17: Table Elimination - Fix trivial valgrind warning modified: sql/sql_select.cc per-file messages: sql/sql_select.cc MWL#17: Table Elimination

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2714)

2009-06-15 Thread Sergey Petrunia
#At lp:maria based on revid:pser...@askmonty.org-20090614123504-jf4pcb333ojwaxfy 2714 Sergey Petrunia 2009-06-15 MWL#17: Table elimination - Fix print_join() to work both for EXPLAIN EXTENDED (after table elimination) and for CREATE VIEW (after join-prepare() but without

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2712)

2009-06-15 Thread Sergey Petrunia
#At lp:maria based on revid:pser...@askmonty.org-20090609211133-wfau2tgwo2vpgc5d 2712 Sergey Petrunia 2009-06-14 MWL#17: Table elimination - Do not show eliminated tables in the output of EXPLAIN EXTENDED modified: mysql-test/r/table_elim.result mysql-test/t

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2713)

2009-06-15 Thread Sergey Petrunia
#At lp:maria based on revid:pser...@askmonty.org-20090614100110-u7l54gk0b6zbtj50 2713 Sergey Petrunia 2009-06-14 MWL#17: Table elimination - Fix the previous cset: take into account that select_lex may be printed when 1. There is no select_lex-join at all (in that case

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2711)

2009-06-15 Thread Sergey Petrunia
#At lp:maria based on revid:pser...@askmonty.org-20090608135546-ut1yrzbah4gdw6e6 2711 Sergey Petrunia 2009-06-10 MWL#17: Table elimination - Make elimination work with aggregate functions. The problem was that aggregate functions reported all table bits in used_tables

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2715)

2009-06-16 Thread Sergey Petrunia
#At lp:maria based on revid:pser...@askmonty.org-20090614205924-1vnfwbuo4brzyfhp 2715 Sergey Petrunia 2009-06-16 MWL#17: Table elimination - Move eliminate_tables() to before constant table detection. - First code for benchmark added: sql-bench/test-table

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2716)

2009-06-16 Thread Sergey Petrunia
#At lp:maria based on revid:pser...@askmonty.org-20090616195413-rfmi9un20za8gn8g 2716 Sergey Petrunia 2009-06-17 [merge] * Merge * Change valgrind suppression to work on valgrind 3.3.0 modified: mysql-test/valgrind.supp per-file messages: mysql-test/valgrind.supp

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2717)

2009-06-16 Thread Sergey Petrunia
#At lp:maria based on revid:pser...@askmonty.org-20090616204358-yjkyfxczsomrn9yn 2717 Sergey Petrunia 2009-06-17 * Use excessive parentheses to stop compiler warning * Fix test results to account for changes in previous cset modified: mysql-test/r/select.result

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2718)

2009-06-22 Thread Sergey Petrunia
#At lp:maria based on revid:pser...@askmonty.org-20090617052739-37i1r8lip0m4ft9r 2718 Sergey Petrunia 2009-06-22 MWL#17: Table elimination - Make elimination check to be able detect cases like t.primary_key_col1=othertbl.col AND t.primary_key_col2=func(t.primary_key_col1

[Maria-developers] Test 8

2009-07-06 Thread Sergey Petrunia
Test, please ignore ___ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

[Maria-developers] MariaDB config for Akonadi - suggestions?

2014-02-11 Thread Sergey Petrunia
Hi, Daniel Vratil from Akonadi (a PIM manager for KDE) has asked me at FOSDEM about optimal MariaDB configuration for Akonadi. Some specific questions: * innodb_flush_log_at_trx_commit. Currently, Akonadi uses innodb_flush_log_at_trx_commit=2 which as far as I understand can cause up to 1 second

Re: [Maria-developers] GROUP BY with non-grouped column returns NULL in some cases?

2014-02-21 Thread Sergey Petrunia
Hi, On Thu, Feb 20, 2014 at 10:28:52AM -0800, Pavel Ivanov wrote: I've noticed a difference in MariaDB's behavior compared to its documentation and compared to MySQL 5.1 (didn't check with MySQL 5.5 or 5.6 yet), and I wanted to know what's your opinion -- is it a bug or a conscious difference

[Maria-developers] Proposal for: MDEV-5244: Make extended_keys=ON by default in 10.0

2014-02-21 Thread Sergey Petrunia
Hello, I was looking at how to make extended_keys=ON by default in 10.0. There haven't been any bugs in the feature for quite some time, but we still have a question of how to be with the testsuite (do we run it with extended_keys=OFF, the old way, or with extended_keys=ON, the new way? both

Re: [Maria-developers] MySQL Optimizer Trace Questions

2014-02-25 Thread Sergey Petrunia
Hi Christian, On Thu, Feb 20, 2014 at 06:31:45PM -0500, Christian Rober wrote: I work for TokuTek as a Storage Engine developer and I have been using the, relatively, new optimizer trace functionality. I have found the results very helpful when combined with analyzing the source code, but

[Maria-developers] MDEV-4309: Review for 201402181003_sanja_copy_calls_patch.diff

2014-02-25 Thread Sergey Petrunia
Hi Sanja, My input for 201402181003_sanja_copy_calls_patch.diff: * memcpy_field_possible() should have a function comment mentioning that it checks whether memcpy_field_value() can be used. * field_conv_incompatible() should have a function comment mentioning that it is a function that is

[Maria-developers] Engine independent index statistics - infrastructure questions

2014-03-20 Thread Sergey Petrunia
Hello Igor and others, I've been playing around with engine independent statistics, and got a few questions. == mysqldump == mysqldump dumps table' data, but besides that it can dump other related objects, e.g. it will dump triggers that are attached to the table. Should it dump table

[Maria-developers] Engine independent statistics - naming issues?

2014-03-27 Thread Sergey Petrunia
Hello, I was looking at whether column names used by EIS feature are consistent with themselves and with ther parts of the server. == Database / table / column names == There are a few naming conventions arready in use: 1. Old school: mysql.columns_priv, tables_priv Db Table_name

[Maria-developers] valgrind failure in main.statistics

2014-04-29 Thread Sergey Petrunia
Hello Igor, Valgrind build in buildbot currently fails in main.statistics test: http://buildbot.askmonty.org/buildbot/builders/work-amd64-valgrind/builds/5502/steps/test/logs/stdio I have tracked it down: the failure appeared after this push by you: revno: 4157 [merge] committer: Igor Babaev

[Maria-developers] 10.0 - 10.1 merge

2014-05-08 Thread Sergey Petrunia
Hello Igor, As discussed, I've done the 10.0 - 10.1 merge. I didn't get any warnings or new test failures in the 'main' test suite, so I've pushed the merge into 10.1 tree. BR Sergei -- Sergei Petrunia, Software Developer MariaDB | Skype: sergefp | Blog: http://s.petrunia.net/blog

[Maria-developers] KB page on switching from bazaar to git.

2014-05-27 Thread Sergey Petrunia
Hi, I was doing some stuff in git already, and so I have created a git cheatsheet with equivalents of bzr commands that were useful in MariaDB development: https://mariadb.com/kb/en/using-git/ It is not finished, any additions are welcome. Elena has agreed to look at creating a commit trigger

[Maria-developers] [MDEV-4903] Regarding range support for multi-column IN predicates

2014-06-18 Thread Sergey Petrunia
Hi, So, MySQL 5.7 has got support for range optimization for multi-column IN predicates: http://optimize-this.blogspot.ru/2013/12/range-access-now-in-in-predicate-near.html We've also got a user issue about it: https://mariadb.atlassian.net/browse/MDEV-4903. I'm looking at their IN handling. I

Re: [Maria-developers] INET6, data type plugins

2014-07-05 Thread Sergey Petrunia
On Tue, Jul 01, 2014 at 05:07:36PM +0400, Alexander Barkov wrote: 2. In case of pluggable data types we'll need some changes in the client-server protocol, to transfer data type names (and probably some more metadata) to the client side in some textual form. Any ideas on that? I'm

[Maria-developers] Why does name resolution stop in crash stack trace?

2014-07-18 Thread Sergey Petrunia
Hi, Look at today's crash report in maria-discuss@. A question not related to the cause of that crash: why do stack traces that go inside the storage engine cannot be resolved? Is something wrong with our build process? On Fri, Jun 13, 2014 at 08:15:39PM -0700, grantksupp...@operamail.com wrote:

Re: [Maria-developers] How to get all fields in a given index?

2014-09-09 Thread Sergey Petrunia
On Mon, Sep 08, 2014 at 08:54:00PM +0100, Rongrong wrote: I'm trying to implement some feature that requires to get the list of fields for a given index. I'm trying to follow the optimizer code to find some clue but am not successful so far. Can anyone give me some pointers? A TABLE object

[Maria-developers] More upgrades needed for work-amd64-valgrind

2014-09-24 Thread Sergey Petrunia
Hello Jani, Thanks for getting git to work for work-amd64-valgrind host. I am looking at http://buildbot.askmonty.org/buildbot/grid?branch=10.1 and see that git update step succeeds. However, the next step fails:

Re: [Maria-developers] More upgrades needed for work-amd64-valgrind

2014-09-25 Thread Sergey Petrunia
Hi Jani, On Thu, Sep 25, 2014 at 02:22:48PM +0300, Jani Tolonen wrote: Hi Sergey, cmake version was just one minor version too old. I upgraded it and libstdc++ and according to cmake documentation the error should now be gone. Please let me know if there are still problems. It seems like

[Maria-developers] Igor please review: [Commits] Rev 4446: MDEV-6879: Dereference of NULL primary_file-table in DsMrr_impl::get_disk_sweep_mrr_cost()

2014-10-20 Thread Sergey Petrunia
Hello Igor, Could you please review the below: At file:///home/psergey/dev2/10.0-cp2/ revno: 4446 revision-id: psergey at askmonty.org-20141020175620-vodbkx9ugmdhh8c1 parent: psergey at askmonty.org-20141016135713-md92qr4g9fzhitxh

Re: [Maria-developers] [Commits] Rev 4358: MDEV-7113 difference between check_vcol_func_processor and check_partition_func_processor in lp:~maria-captains/maria/5.5

2014-11-19 Thread Sergey Petrunia
Hi Sergei, * what about persistent virtual columns? Do we still support environment-dependent virtual functions for those? * the behavior of current solution is not deterministic: thread1 select @@time_zone; +-+ | @@time_zone | +-+ | SYSTEM | +-+ 1 row

Re: [Maria-developers] [Commits] Rev 4358: MDEV-7113 difference between check_vcol_func_processor and check_partition_func_processor in lp:~maria-captains/maria/5.5

2014-11-20 Thread Sergey Petrunia
: On Nov 19, Sergey Petrunia wrote: * what about persistent virtual columns? Do we still support environment-dependent virtual functions for those? I've explained that in a comment - I was mostly trying to fix crashes, like that one with FROM_UNIXTIME. I'm hesitant to reduce the set

Re: [Maria-developers] MDEV-5719: Wrong result with GROUP BY and LEFT OUTER JOIN

2015-01-29 Thread Sergey Petrunia
On Sun, Jan 25, 2015 at 08:54:11PM +0100, Sergei Golubchik wrote: Hi, Sergey! On Jan 25, Sergey Petrunia wrote: Hi Sergei, == TL;DR == I have debugged that LEFT JOIN problem. The fix is not pretty, but correct. I will now push it into the 10.0 tree. I've spent few hours

Re: [Maria-developers] [Commits] Rev 4577: MDEV-5719: Wrong result with GROUP BY and LEFT OUTER JOIN in lp:~maria-captains/maria/10.0

2015-01-25 Thread Sergey Petrunia
Hi Sergei, == TL;DR == I have debugged that LEFT JOIN problem. The fix is not pretty, but correct. I will now push it into the 10.0 tree. == Details == So, the commit changes -return (table-null_row ? TRUE : -null_ptr ? MY_TEST(null_ptr[row_offset] null_bit) : 0); +return

Re: [Maria-developers] MDEV-6838: Using too big key for internal temp tables

2015-03-03 Thread Sergey Petrunia
Hi Vicențiu, The patch is ok to push. On Sun, Mar 01, 2015 at 12:10:44AM +0200, Vicențiu Ciorbaru wrote: Hi Sergei and Sergey! I've implemented the fix for MDEV-6838. I'd like a review from both of you regarding the patch. There are a couple of changes made. The main issues are outlined

Re: [Maria-developers] [Commits] Rev 4382: MDEV-6892: WHERE does not apply in file:///home/bell/maria/bzr/work-maria-5.5-MDEV-6892/

2015-03-04 Thread Sergey Petrunia
Hi Sanja, Please find my feedback below. We should discuss it. On Fri, Dec 19, 2014 at 01:24:12PM +, sa...@askmonty.org wrote: At file:///home/bell/maria/bzr/work-maria-5.5-MDEV-6892/ revno: 4382 revision-id:

Re: [Maria-developers] [MDEV-7586] Merged derived tables/VIEWs increment created_tmp_tables

2015-02-25 Thread Sergey Petrunia
Hi Vicențiu, On Sun, Feb 22, 2015 at 10:22:39AM +0200, Vicențiu Ciorbaru wrote: diff --git a/sql/opt_subselect.cc b/sql/opt_subselect.cc index d5e3334..2122349 100644 --- a/sql/opt_subselect.cc +++ b/sql/opt_subselect.cc @@ -3890,7 +3890,6 @@ SJ_TMP_TABLE::create_sj_weedout_tmp_table(THD

Re: [Maria-developers] [MDEV-7586] Merged derived tables/VIEWs increment created_tmp_tables

2015-02-25 Thread Sergey Petrunia
On Sun, Feb 22, 2015 at 10:22:39AM +0200, Vicențiu Ciorbaru wrote: Hi Sergey! As discussed on the mdev page, I've implemented the fix for incrementing the created_tmp_tables variable. I've attached the patch for review. The changes in the patch are explained within the mdev page. commit

Re: [Maria-developers] [Commits] fc31f6d: MDEV-7833:ANALYZE FORMAT=JSON and Range checked for each record

2015-04-02 Thread Sergey Petrunia
Hi Sanja, Please find review comments below. On Thu, Apr 02, 2015 at 06:19:41PM +0200, sa...@mariadb.com wrote: revision-id: fc31f6d95720b4b946b8b68c816026d65831f347 parent(s): 01d7da6785284383b2c04f2d4474feccebb0bb6f committer: Oleksandr Byelkin branch nick: server timestamp: 2015-04-02

Re: [Maria-developers] [Commits] 9f8a458: MDEV-7846: Server crashes in Item_subselect::fix_fields or fails with Thread stack overrun

2015-06-08 Thread Sergey Petrunia
Hi Sanja, It is very difficult to understand this patch. What is the exact meaning of left_expr_orig? It is declared but has no comments. It is interesting that convert_subq_to_sj has got new code to handle scalar comparison case ( foo IN (SELECT bar ...)), while there is no handling for

Re: [Maria-developers] [Commits] d1f5dfe: MDEV-8030 - Apc_target::disable() locks mutex twice

2015-06-19 Thread Sergey Petrunia
Hi Sergei, Ok to push. I'm sorry for the delay with this. On Wed, May 20, 2015 at 08:09:36AM +, s...@mariadb.org wrote: revision-id: d1f5dfe67703a22f017eb25dd48b1eb5246a9c54 parent(s): 80333ad847d9f1708fa02fb47a976e96f014bc50 committer: Sergey Vojtovich branch nick: mariadb timestamp:

Re: [Maria-developers] GSoc2015

2015-06-24 Thread Sergey Petrunia
Hi Diwas, On Wed, Jun 24, 2015 at 07:00:48PM +0530, Diwas Joshi wrote: hii, please find a patch for MDEV-8343 https://mariadb.atlassian.net/browse/MDEV-8343 attached to this mail. I have also included a test case in the patch. Please find my comments below. Coding style refers to the

Re: [Maria-developers] GSoc2015

2015-06-24 Thread Sergey Petrunia
On Wed, Jun 24, 2015 at 07:00:48PM +0530, Diwas Joshi wrote: hii, please find a patch for MDEV-8343 https://mariadb.atlassian.net/browse/MDEV-8343 attached to this mail. I have also included a test case in the patch. So the crash that happens on my machine is: Program received signal

Re: [Maria-developers] GSoC2015: facing errors working on udf's for table valued functions.

2015-06-19 Thread Sergey Petrunia
On Fri, Jun 19, 2015 at 05:23:32PM +0530, Diwas Joshi wrote: hii i have been stuck on some shift/reduce conflict since past few days. It is giving the error for the code i have added for select query using the udf. I think the rule that I defined under table_factor is conflicting with the

Re: [Maria-developers] MDEV-8356 analysis and ideas

2015-06-29 Thread Sergey Petrunia
Hi Diwas, Nice analysis. Please find my comments below. On Mon, Jun 29, 2015 at 10:01:56AM +0530, Diwas Joshi wrote: hello sergey, so i was reading further on MDEV-8356 last night. There are two main things here: type of sf and return type of sf. Right now the create function... is giving

[Maria-developers] MDEV-4119 patch comments

2015-07-06 Thread Sergey Petrunia
Hi Monty, Please find my comments on the patch for MDEV-4119 below. Sorry for the delay. diff --git a/sql/item.cc b/sql/item.cc index b4de973..3b1f8b7 100644 --- a/sql/item.cc +++ b/sql/item.cc @@ -1705,69 +1705,98 @@ class Item_aggregate_ref : public Item_ref @param thd

Re: [Maria-developers] MDEV-8389 patch review (part#1)

2015-08-19 Thread Sergey Petrunia
Hi Diwas, Please find part #1 of the review below. I'll provide more soon. diff --git a/sql/sql_parse.cc b/sql/sql_parse.cc index 2998972..a9dc162 100644 --- a/sql/sql_parse.cc +++ b/sql/sql_parse.cc @@ -2466,6 +2466,8 @@ static bool do_execute_sp(THD *thd, sp_head *sp)

Re: [Maria-developers] MDEV-8389 patch review

2015-08-19 Thread Sergey Petrunia
Also, I'm getting a crash when trying to debug a slightly complex example: delimiter | CREATE FUNCTION f10(param1 VARCHAR(11)) RETURNS TABLE return_table(name VARCHAR(11)) deterministic BEGIN insert into return_table values('foo'); END| DELIMITER ; select name from f21('aaa') where name like

Re: [Maria-developers] MDEV-8389 patch review

2015-08-19 Thread Sergey Petrunia
On Wed, Aug 12, 2015 at 01:58:40AM +0530, Diwas Joshi wrote: hello sergei, After I mailed you the last patch, I kept working further. I guess the code has come to a point where it is giving some results. So, I did the following things: Earlier we were storing all the parameters in a select

Re: [Maria-developers] MDEV-8389 patch review

2015-08-19 Thread Sergey Petrunia
Hi Diwas, While playing around, I've found and filed: https://mariadb.atlassian.net/browse/MDEV-8649 https://mariadb.atlassian.net/browse/MDEV-8650 I've filed these separately because I think they are not related to MDEV-8389. BR Sergei -- Sergei Petrunia, Software Developer MariaDB

Re: [Maria-developers] MDEV-8389 patch review

2015-08-02 Thread Sergey Petrunia
Hi Diwas, I've got a crash when trying the first example. The example was: CREATE FUNCTION f1(a INT, b VARCHAR(11)) RETURNS TABLE t1(id INT, name VARCHAR(11)) DETERMINISTIC BEGIN INSERT INTO t1 SELECT id, name FROM t2 WHERE id = a; END|; delimiter ; select f1(1,'aa'); The crash was:

[Maria-developers] [MDEV-8554] Weird behavior of multi-table UPDATE and THD::save_prep_leaf_list

2015-07-30 Thread Sergey Petrunia
Hello Igor, I was debugging https://mariadb.atlassian.net/browse/MDEV-8554 The patch is about save_prep_leaf_list is not being cleaned up by a statement. I committed a patch that makes that bug go away. However, the way that statements work with THD::save_prep_leaf_list look weird to me. Since

Re: [Maria-developers] MDEV-8389 patch review

2015-08-03 Thread Sergey Petrunia
On Sun, Aug 02, 2015 at 08:51:44PM +0530, Diwas Joshi wrote: So what would be the expected result of query select f1(1,'aa'). since it will be a table shouldn't we use select * from f1(1,'aa'). I know it shouldn't crash but what should be the output of that query? My first guess is that since

Re: [Maria-developers] MDEV-8389 patch review (question1)

2015-08-03 Thread Sergey Petrunia
More input on the patch: Let's debug a regular table function: delimiter | create function f10() returns int deterministic begin return 1+3; end | delimiter ; flush tables; select f10(); Let's put a breakpoint on 'parse_sql': Breakpoint 4, parse_sql (thd=0x5ac4aeb0,

Re: [Maria-developers] MDEV-8389 patch review

2015-08-06 Thread Sergey Petrunia
Hi Diwas, On Wed, Aug 05, 2015 at 08:47:28PM +0530, Diwas Joshi wrote: I have removed the errors from previous patch, I only got those errors when i compiled with valgrind. Everything seems to be working fine now. Also I have fixed the test case for select * from mysql.proc. Also added a

Re: [Maria-developers] [Commits] 72bb358: MDEV-7930 Assertion `table_share->tmp_table != NO_TMP_TABLE || m_lock_type != 2' failed in handler::ha_index_read_map

2015-10-27 Thread Sergey Petrunia
Hi Sanja, Please find some cosmetic feedback below. Ok to push after it has been addressed. On Mon, Oct 26, 2015 at 05:00:34PM +0100, sa...@mariadb.com wrote: > revision-id: 72bb358c2ba98e6e0d4a15b92af514a45751fe8d > (mariadb-10.0.21-44-g72bb358) > parent(s):

Re: [Maria-developers] MDEV-8389 patch review (part#1)

2015-08-27 Thread Sergey Petrunia
On Sat, Aug 22, 2015 at 02:10:58AM +0530, Diwas Joshi wrote: Hello Sergei, sorry for late reply, i was busy finishing my office work yesterday. Please find some of my doubts below (I would come on irc to discuss but I am travelling today and will be working overnight in the train, I hope to be

Re: [Maria-developers] [Commits] 59fcd7f: MDEV-9118 ANALYZE TABLE for Engine independent status fetchs blob/text columns without use

2015-12-22 Thread Sergey Petrunia
Hi Sanja, So, the patch produces warnings whenever a column is not collected. I think they should be produced only if the columns were explicitly specified in ANALYZE TABLE ... COLUMNS (col1, ...) syntax. The idea is that we should issue a warning when we're clearly not doing what the user has

[Maria-developers] Parallel replication slave stops with duplicate key errors

2016-06-15 Thread Sergey Petrunia
Hi Kristian, I was trying out parallel replication and got an error that I am not sure what to do with. == Setup == I started a master with binlog_format=row, I ran sysbench there to load the dataset ("prepare" mode, about 10M rows IIRC) then I restarted the master and ran sysbench in "run" mode

[Maria-developers] Binary is built, but does it have Cassandra-v2 (Was: Re: June, 30th meeting: outcome)

2016-06-02 Thread Sergey Petrunia
On Wed, Jun 01, 2016 at 08:46:45PM +0100, Charles Muurmu wrote: > Hi Sergei, > > make now runs to completion and make install as well I'm a bit surprised. I'm looking at https://github.com/charlesmuurmu/server/blob/MDEV-8947/storage/cassandra-v2/CMakeLists.txt And I still see two "IF(...)"

Re: [Maria-developers] JSON libraries

2016-05-31 Thread Sergey Petrunia
On Tue, May 31, 2016 at 03:35:22PM +0400, Alexey Botchkov wrote: .. > That JSON_CHECKER was produced by JSON.org itself, is really fast > and nice. But it's not > a parser - it just checks if the text makes the correct JSON. > Well it took some time, but now ready. Now opening it for review. So

Re: [Maria-developers] [Commits] 773ce40: MDEV-10045: Server crashes in Time_and_counter_tracker::incr_loops

2016-06-24 Thread Sergey Petrunia
Hi Sanja, O the patch fixes the crash. However when I am debugging it, I see the execution to go like this: (gdb) wher #0 JOIN::optimize_inner (this=0x7fff900087d0) at /home/psergey/dev-git/10.1-dbg6/sql/sql_select.cc:1095 #1 0x55a8e5f8 in JOIN::optimize (this=0x7fff900087d0) at

Re: [Maria-developers] [Commits] 841c317: MDEV-7122: Assertion `0' failed in subselect_hash_sj_engine::init

2016-02-09 Thread Sergey Petrunia
Hi Vicentiu, Please find some cosmetic feedback below. Ok to push after it is addressed. On Tue, Feb 09, 2016 at 04:02:58PM +0200, Vicentiu Ciorbaru wrote: > revision-id: 841c317d237453f3e6c253e2a884cad73622b59a > (mariadb-5.5.47-33-g841c317) > parent(s):

[Maria-developers] win.test fails with --ps-protocol

2016-02-27 Thread Sergey Petrunia
Hello Igor, I'm looking at the buildbot http://buildbot.askmonty.org/buildbot/grid?category=main=bb-10.2-mdev9543 and I see that your push https://github.com/MariaDB/server/commit/0c6d753708dfe07607ab6879b4832fe6ec5ddefb causes failures for win.test with --ps-protocol:

[Maria-developers] bb-10.2-mdev9543 is missing item_windowfunc.*

2016-02-12 Thread Sergey Petrunia
Hello Igor, The tree at bb-10.2-mdev9543 is missing item_windowfunc.* files. Could you please add them there and push? BR Sergei -- Sergei Petrunia, Software Developer MariaDB Corporation | Skype: sergefp | Blog: http://s.petrunia.net/blog ___

[Maria-developers] Window functions code, MDEV-9543 and MDEV-8646 are now merged

2016-02-15 Thread Sergey Petrunia
Hello, Following the Thursday discussion, I've managed to re-base 10.2-window_simple branch onto the bb-10.2-mdev9543. The result is now pushed into bb-10.2-mdev9543. https://github.com/MariaDB/server/commits/bb-10.2-mdev9543 Since rebase happened, 10.2-window_simple tree should be abandoned.

Re: [Maria-developers] [Commits] a0c06ba: Preliminary implementation for the aggregate sum function as a window function

2016-03-14 Thread Sergey Petrunia
Hi Vicentiu, I think it add_helper() is a really poor choice of name when the function can do removal. Maybe add_or_remove() name would be better? On Mon, Mar 14, 2016 at 03:44:48PM +0200, Vicentiu Ciorbaru wrote: > revision-id: a0c06ba1edb54c8c4705189c0455137a85658297 >

[Maria-developers] Window functions: why some functions are not in select_lex->window_funcs?

2016-03-23 Thread Sergey Petrunia
Hello Igor, I was trying to move JOIN::process_window_functions() from using join->fields_list to using join->select_lex->window_funcs. And I discovered that join->select_lex->window_funcs does not contain window function items that use window definition. Is this intentional? Example: create

[Maria-developers] Igor please review: b6a2441: Remove all comments starting with 'psergey'

2016-03-02 Thread Sergey Petrunia
Please review the below: - Forwarded message from Sergei Petrunia - Date: Wed, 2 Mar 2016 13:35:11 +0300 (FET) From: Sergei Petrunia To: comm...@mariadb.org, ser...@mariadb.com Subject: b6a2441: Remove all comments starting with 'psergey'

Re: [Maria-developers] [Commits] d40d68f: Convert percent_rank to work with cursors

2016-03-30 Thread Sergey Petrunia
On Mon, Mar 28, 2016 at 10:58:55PM +0300, Vicentiu Ciorbaru wrote: > revision-id: d40d68f23602be9886c1b502fdad9d23bdc9a0fb > (mariadb-10.1.8-187-gd40d68f) > parent(s): bf18dac08fe0ae18975158e786fee097883949d4 > author: Vicențiu Ciorbaru > committer: Vicențiu Ciorbaru > timestamp: 2016-03-28

[Maria-developers] Window functions: compare_window_spec_joined_lists() has a bug

2016-04-04 Thread Sergey Petrunia
Hello Igor, I'm trying this example: create table t1 (a int, b int); insert into t1 values (1,1),(2,2),(3,3); select rank() over (order by a), rank() over (order by b) from t1; I put a breakpoint in order_window_funcs_by_window_specs(), at this call: int cmp=

[Maria-developers] MDEV-9841: Window functions: embedded server fails to start due to error code conflicts

2016-03-31 Thread Sergey Petrunia
Hi Serg, We added a number of new error messages for window functions, and now server error codes have collided with the client. The text in MDEV-9841 has the details. Sanja mentioned that you were aware of the possibility of this and had a solution. Can we discuss it sometime? BR Sergei --

Re: [Maria-developers] Cassandra v2 Project Blog and git setup.

2016-05-11 Thread Sergey Petrunia
Hi Charles, On Sat, May 07, 2016 at 10:52:35AM +0100, Charles Muurmu wrote: > I am not used to blogging but I have created a wordpress blog on which I > will be making posts about my progress on this project with Spetrunia. > Please feel free to criticize and suggest corrections. > > So far I

Re: [Maria-developers] GSoC Student Introduction

2016-05-11 Thread Sergey Petrunia
On Wed, May 11, 2016 at 08:26:49PM +0300, Sergey Petrunia wrote: > On Wed, Apr 27, 2016 at 07:44:11AM +0100, Charles Muurmu wrote: > > I am Charles Muurmu also known as laserlight on IRC and I was selected for > > GSoC 2016 to work on migrating MariaDB Cassandra storage engine from

Re: [Maria-developers] [Commits] b1ddc7d: MDEV-9487: Server crashes in Time_and_counter_tracker::incr_loops with UNION in ALL subquery

2016-05-04 Thread Sergey Petrunia
Hi Sanja, I have one comment: the patch introduces JOIN::in_optimize which can have values of 1) not initialized and 2) false. This is clearly redundant. Ok to push after the above is addressed. On Sun, Feb 21, 2016 at 10:12:25PM +0100, OleksandrByelkin wrote: > revision-id:

Re: [Maria-developers] [Commits] 0f3aaf1: MDEV-10045: Server crashes in Time_and_counter_tracker::incr_loops

2016-07-21 Thread Sergey Petrunia
Hi Sanja, Please find some review feeback below (please also check my reasoning while addressing it). I was unable to find any other issues, ok to push after the feedback is addressed. We should also ask Elena to run testing with correlated/non-correlated subqueries, EXPLAINs and ANALYZE. On

Re: [Maria-developers] [Commits] 787610a: MDEV-10766: Queries which start with WITH clause do not get inserted into query cache

2017-02-03 Thread Sergey Petrunia
Hi Varun, On Fri, Feb 03, 2017 at 08:20:51PM +0530, Varun wrote: > revision-id: 787610a1f5cec04311fd16f6c1de87171e5cfdd4 > (mariadb-10.2.3-159-g787610a) > parent(s): bc12d993d7bc94a9533028a258afc7e4ceb21e92 > author: Varun Gupta > committer: Varun Gupta > timestamp: 2017-02-03 20:17:16 +0530 >

Re: [Maria-developers] Archive Storage Engine

2017-02-08 Thread Sergey Petrunia
Hi Varun, On Tue, Feb 07, 2017 at 10:19:50PM +0100, Sergei Golubchik wrote: > > I almost replied to your email with "it's impossible, Archive did not > have HA_RECORD_MUST_BE_CLEAN_ON_WRITE in the table_flags(), no engine > did. So removal could not have changed anything". > > But then I

Re: [Maria-developers] [Commits] 13ebc9c: MDEV-11645: archive.archive fails in buildbot with valgrind (Use of uninitialised value)

2017-02-20 Thread Sergey Petrunia
Hi Varun, On Mon, Feb 13, 2017 at 03:47:57AM +0530, Varun wrote: > revision-id: 13ebc9c826de080e416071b7881585b45922bef9 > (mariadb-10.2.3-185-g13ebc9c) > parent(s): 3ae038b732ce503fb839e9095355e05f5c6866f9 > author: Varun Gupta > committer: Varun Gupta > timestamp: 2017-02-13 03:45:59 +0530 >

Re: [Maria-developers] [Commits] e0a1e63: MDEV-9619: Assertion `null_ref_table' failed in virtual table_map Item_direct_view_ref::used_tables() const on 2nd execution of PS

2017-02-20 Thread Sergey Petrunia
Hi Sanja, Two questions: 1. Why does the patch define Item_ptr type twice? 2. (The big one) In class Item_in_subselect, I see your comment made in 2015: ... public: Item *left_expr; /* Important for PS/SP: left_expr_orig is the item that left_expr originally pointed at. That item is

[Maria-developers] On constructing ref access from mis-matched charset comparisons

2017-02-23 Thread Sergey Petrunia
Hi Alexander, I've got a question about mis-matched charset comparisons and ref access method. == Short form == I know that VARCHAR comparisons over mis-matching charsets cannot be used for constructing index lookups into the index over the "narrower" character set column. But is this a real

Re: [Maria-developers] [Commits] 15fde78: MDEV-10731: Wrong NULL match results in "Subquery returns more than 1 row" (error code 1242)

2017-02-09 Thread Sergey Petrunia
Hi Varun, On Thu, Feb 09, 2017 at 10:37:17PM +0530, Varun wrote: > revision-id: 15fde78ce812c8db91340936941b986fb28ce1ad > (mariadb-10.1.20-82-g15fde78) > parent(s): 99b2de92c6214ddd73eba35c935f490eedf87a26 > author: Varun Gupta > committer: Varun Gupta > timestamp: 2017-02-09 22:36:03 +0530 >

Re: [Maria-developers] [Commits] 14747e4: MDEV-10731: Wrong NULL match results in "Subquery returns more than 1 row" (error code 1242)

2017-01-17 Thread Sergey Petrunia
Hi Varun, On Tue, Jan 17, 2017 at 03:24:39PM +0530, Varun wrote: > revision-id: 14747e4b84f68ee7e10a6e5a24f4b7ec6f3240f9 > (mariadb-10.1.20-38-g14747e4) > parent(s): b56f726e42e8bc0427a0c33cfffb7e1c5399ea16 > author: Varun Gupta > committer: Varun Gupta > timestamp: 2017-01-17 15:22:22 +0530 >

Re: [Maria-developers] MDEV-10306 Wrong results with combination of CONCAT, SUBSTR and CONVERT in subquery

2017-03-02 Thread Sergey Petrunia
Hello, On Wed, Mar 01, 2017 at 01:56:24PM +0100, Sergei Golubchik wrote: > Hi, Alexander! > > On Feb 28, Alexander Barkov wrote: > > > commit af8887b86ccbaea8782cf54fe445cf53aaef7c06 > > Author: Alexander Barkov > > Date: Tue Feb 28 10:28:09 2017 +0400 > > > >

Re: [Maria-developers] [Commits] c6d172f: MDEV-11078: NULL NOT IN (non-empty subquery) should never return results

2017-02-27 Thread Sergey Petrunia
Hi Varun, Things that look apparently wrong: 1. The patch checks left_expr->null_value without first having made a call that will fill that member. The calling convention is something like this: item->val_XXX() // val_str or val_int() // check item->null_value. If one doesn't need string

Re: [Maria-developers] Missing tests for MDEV-10057 and MDEV-10058

2016-09-07 Thread Sergey Petrunia
On Wed, Sep 07, 2016 at 10:24:09AM +0400, Alexander Barkov wrote: > Hello Sergey and Igor, > > You recently closed MDEV-10057 and MDEV-10058, but forgot to add tests. > > - MDEV-10057 does not have tests at all. > > - MDEV-10058 has only the parser related test, > but does not have this test: >

[Maria-developers] Questions on recent window function code changes

2016-09-14 Thread Sergey Petrunia
Hi Vicențiu, > item_windowfunc.cc|168| peer_tracker = new Group_bound_tracker(thd, > window_spec->order_list); > item_windowfunc.cc|176| peer_tracker = new Group_bound_tracker(thd, > window_spec->order_list); > item_windowfunc.cc|218| peer_tracker = new Group_bound_tracker(thd, >

Re: [Maria-developers] [Commits] 0a86a91: MDEV-10765: Wrong result - query does not retrieve values from default partition on a table partitioned by list columns

2016-09-08 Thread Sergey Petrunia
Hi Sanja, > revision-id: 0a86a915842d268477c5febd8481263f00d6c792 > (mariadb-10.1.8-242-g0a86a91) > parent(s): effb65bc863da0f1115e16ef5f11d11a13cdc7a0 > committer: Oleksandr Byelkin > timestamp: 2016-09-08 19:43:09 +0200 > message: > > MDEV-10765: Wrong result - query does not retrieve values

Re: [Maria-developers] [Commits] a288cb6: MDEV-8320 Allow index usage for DATE(datetime_column) = const.

2016-09-20 Thread Sergey Petrunia
Hi Alexey, The patch doesn't have any testcase. Did you forget to add them? On Tue, Sep 20, 2016 at 01:22:19PM +0400, Alexey Botchkov wrote: > revision-id: a288cb698195b1e57abbb426f1cc9a804d65ff45 > (mariadb-10.1.8-262-ga288cb6) > parent(s): cb575abf76be82553b9c1c12c9112cbc6f53a547 > committer:

Re: [Maria-developers] [Commits] c584f16: MDEV-10017: Get unexpected `Empty Set` for correlated subquery with aggregate functions (part 1)

2016-08-29 Thread Sergey Petrunia
Hi Sanja, On Thu, Jun 23, 2016 at 05:50:08PM +0200, Oleksandr Byelkin wrote: > revision-id: c584f1655ef45dafd2b5d0eb55ca21421de9a266 > (mariadb-10.1.14-25-gc584f16) > parent(s): 773ce408762b5f8256d4053b6d0d418d15657b92 > committer: Oleksandr Byelkin > timestamp: 2016-06-23 17:50:07 +0200 >

Re: [Maria-developers] [Commits] f2aea43: MDEV-10649: Optimizer sometimes use "index" instead of "range" access for UPDATE

2016-09-28 Thread Sergey Petrunia
On Wed, Sep 07, 2016 at 10:36:32AM +0300, Jan Lindström wrote: > On Tue, Sep 6, 2016 at 8:37 PM, Sergei Petrunia > wrote: > > > revision-id: f2aea435df7e92fcf8f09f8f6c160161168c5bed > > parent(s): a14f61ef749ad9f9ab2b0f5badf6754ba7443c9e > > committer: Sergei Petrunia > >

[Maria-developers] Please review: support for --force-restart in MTR

2016-11-06 Thread Sergey Petrunia
Hi Sergei, Elena I'm not sure who maintains mysql-test-run.pl but you two seem to have contributed to it in the past, this is why I'm addressing this to you. I'm going to get "MTR v2" to support --force-restart, just like MTR v1 did;

Re: [Maria-developers] Please review: support for --force-restart in MTR

2016-11-10 Thread Sergey Petrunia
On Mon, Nov 07, 2016 at 06:53:30AM +0100, Sergei Golubchik wrote: > On November 7, 2016 1:34:18 AM GMT+01:00, Sergey Petrunia > <ser...@mariadb.com> wrote: > >Hi Sergei, Elena > > > >I'm not sure who maintains mysql-test-run.pl but you two seem to have &g

Re: [Maria-developers] Rewiew requested.

2016-10-24 Thread Sergey Petrunia
Hi Alexey, I think this change is good. Which version is it going into? (I assume, 10.2?) On Mon, Oct 24, 2016 at 05:54:57PM +0400, Alexey Botchkov wrote: > > I'd like your opinion about this difference in the result of the null.test: > >

[Maria-developers] MDEV-11297: Re why tree_delete doesn't work in Item_func_group_concat code

2016-11-25 Thread Sergey Petrunia
Hi Varun, Part#1 of the followup to our discussion about removing from the TREE object. So I tried to get tree_remove() to work. - I enabled deletion from the tree based on your analysis. - then, I got the tree_remove code to compile by making these changes: diff --git a/sql/item_sum.cc

[Maria-developers] Changing the error message for ER_LOCK_WAIT_TIMEOUT

2016-11-12 Thread Sergey Petrunia
Hi Sergei and everyone, MariaDB defines ER_LOCK_WAIT_TIMEOUT as share/errmsg-utf8.txt:eng "Lock wait timeout exceeded; try restarting transaction" facebook/mysql-5.6 has an enhancement: it also shows what kind of lock is held: share/errmsg-utf8.txt:eng "Lock wait timeout

Re: [Maria-developers] [Commits] 41a12f9: MDEV-8320 Allow index usage for DATE(datetime_column) = const.

2016-11-01 Thread Sergey Petrunia
In-Reply-To: <20160928105123.6D948140DDC@nebo.localdomain> Hi Alexey, Thanks for your patience in waiting for the review. Please find it below. On Wed, Sep 28, 2016 at 02:50:19PM +0400, Alexey Botchkov wrote: > revision-id: 41a12f990519fb68eaa66ecc6860985471e6ba5a >

  1   2   >