Re: [Maria-developers] CREATE USER gotcha

2014-12-18 Thread Vicențiu Ciorbaru
Hi! As I have previously worked on this module, I would like to help with this issue. I can have a look into it tomorrow. Regards, Vicentiu On Thu, 18 Dec 2014 10:24 Oleksandr Byelkin sa...@montyprogram.com wrote: Hi! On 18.12.14 08:52, Alexander Barkov wrote: The same behaviour is

Re: [Maria-developers] [MDEV-7362] ANALYZE TABLES crash with table-independent-statistics gathering

2015-01-15 Thread Vicențiu Ciorbaru
I've implemented a fix for the bug described in MDEV-7362, that also fixes MDEV-7380. The test case also covers MDEV-7380. With the following fix, *there are no longer any crashes within the server.* * Pressed send by mistake. ___ Mailing list:

[Maria-developers] [MDEV-7362] ANALYZE TABLES crash with table-independent-statistics gathering

2015-01-15 Thread Vicențiu Ciorbaru
Hi Sergei! I've implemented a fix for the bug described in MDEV-7362, that also fixes MDEV-7380. The test case also covers MDEV-7380. With the following fix,the I've spent a bit of time trying to figure out the architecture of things there. I am not confident my fix is complete, or if this is

Re: [Maria-developers] [MDEV-7362] ANALYZE TABLES crash with table-independent-statistics gathering

2015-01-16 Thread Vicențiu Ciorbaru
Hi Daniel! The test case should also look at the result of the: select * from mysql.index_stats where index_name='a' and table_name='t1'; Added in the test case. Also, I got the explanation slightly wrong. It's not index_init that causes the problem, it's calling ha_index_first with a

Re: [Maria-developers] Fwd: Contributing in MariaDB Project

2015-02-10 Thread Vicențiu Ciorbaru
Hi Rohit! It's good to know you are interested in contributing to MariaDB. We don't have a lot of beginner friendly bugs running around right now. Fortunately however, I do have a task that might be simple enough to tackle [1]. This is part of a former GSOC project called Roles. The place to

Re: [Maria-developers] Fwd: MDEV-6838 Using too big key for internal temp tables

2015-02-12 Thread Vicențiu Ciorbaru
LIMIT 1; DROP TABLE t1, t2; On Tue, Feb 10, 2015 at 1:41 PM, Vicențiu Ciorbaru vicen...@mariadb.org wrote: + CC maria-developers Hi Sergei! I have attached the diff for MDEV-6838. Let me know your thoughts on it. The test case now fails without the patch and passes with the patch on both

[Maria-developers] Crash during configure without development SSL libraries installed

2015-02-12 Thread Vicențiu Ciorbaru
Hi Sergei! The following error occurs while trying to configure MariaDB 10.0 using the command cmake . without the development SSL libraries installed. I've attached the patch to fix the errors. ERROR LOG: -- CMake Error at cmake/ssl.cmake:162 (FILE): file STRINGS file

Re: [Maria-developers] Fwd: Contributing in MariaDB Project

2015-02-13 Thread Vicențiu Ciorbaru
Hi Rohit, Since we had trouble communicating on IRC, feel free to send your questions via email. It's also good that the community also gets a chance to contribute with answers. Regards, Vicentiu On Thu Feb 12 2015 at 4:18:45 PM Vicențiu Ciorbaru cvicen...@gmail.com wrote: Hi Rohit, Ping me

Re: [Maria-developers] Fwd: Contributing in MariaDB Project

2015-02-12 Thread Vicențiu Ciorbaru
there. -- From: Vicențiu Ciorbaru cvicen...@gmail.com Sent: ‎10-‎02-‎2015 20:51 To: Rohit Kashyap rkgud...@gmail.com; maria-developers@lists.launchpad.net Subject: Re: [Maria-developers] Fwd: Contributing in MariaDB Project Hi Rohit! It's good to know you are interested in contributing

[Maria-developers] Fwd: MDEV-6838 Using too big key for internal temp tables

2015-02-10 Thread Vicențiu Ciorbaru
+ CC maria-developers Hi Sergei! I have attached the diff for MDEV-6838. Let me know your thoughts on it. The test case now fails without the patch and passes with the patch on both 5.5 and 10.0. Sergey Petrunia is alright with the patch. Regards, Vicențiu === added file

[Maria-developers] Question regarding MDEV-7682

2015-03-09 Thread Vicențiu Ciorbaru
Hi Holyfoot! I've made some changes regarding key_length computation to fix MDEV-6838. Changing this seems to have lead to us discovering another issue outlined in MDEV-7682 (that I've just created). It seems that the spatial key returns a key_length of 0. I've spoken to Sergei Petrunia and we

Re: [Maria-developers] MDEV-6877 - binlog_row_image implementation advice

2015-03-30 Thread Vicențiu Ciorbaru
Hi Kristian, Another concern that I have is how to test the implementation. Right now, I run the test, get the binlog file and print it with mysqlbinlog and see if the output is what I expect. Do we have something within mysql-test-run that automates this? There are some MTR tests that

[Maria-developers] MDEV-6877 - binlog_row_image implementation advice

2015-03-27 Thread Vicențiu Ciorbaru
Hi Sergei! This past week I've done quite a bit of reading regarding the replication code and how the binlog is used by both mysqlbinlog and the slaves in order to do replication. I think I now have a good enough understanding of the flow of the code for both MySQL and MariaDB to actually start

[Maria-developers] MDEV-6838: Using too big key for internal temp tables

2015-02-28 Thread Vicențiu Ciorbaru
message -- From: vicen...@mariadb.org Date: 28 February 2015 at 23:58 Subject: 45b6edb: MDEV-6838: Using too big key for internal temp tables To: comm...@mariadb.org revision-id: 45b6edb158f8101d641f550179ee15df363f686f parent(s): fa87fc733d7855e0e5f9b959ca0bddf772ca57e5 committer: Vicențiu

[Maria-developers] [MDEV-7586] Merged derived tables/VIEWs increment created_tmp_tables

2015-02-22 Thread Vicențiu Ciorbaru
Hi Sergey! As discussed on the mdev page, I've implemented the fix for incrementing the created_tmp_tables variable. I've attached the patch for review. The changes in the patch are explained within the mdev page. commit 53d78644b793f7b667e71863ccd0b1ba54c894f3 Author: Vicențiu Ciorbaru cvicen

[Maria-developers] MDEV-7912 review and related concerns

2015-04-24 Thread Vicențiu Ciorbaru
Hi, I'd like to report my findings during the investigation of MDEV-7912, ask for a review on my patch and see your opinion on the status of the related code. The patch and all the issues that I am raising are for the 5.5 branch. With the attached patch, the server crash is eliminated. The

Re: [Maria-developers] TRUE vs true (was: [Commits] ac05f41: postreview fix)

2015-04-23 Thread Vicențiu Ciorbaru
Hi, I would like to point out that it would be a good idea to start writing our own coding style doc, so that we no longer have these sort of unknowns. It also helps the community provide patches that are easier for us to review. I can start working on it myself. Regards, Vicențiu On Thu, 23

Re: [Maria-developers] [Commits] 13ecde8: Fix compiler warnings.

2015-04-30 Thread Vicențiu Ciorbaru
Hi Jan! I have one concern with this patch. See below: On Thu, 30 Apr 2015 at 11:45 Jan Lindström jan.lindst...@mariadb.com wrote: revision-id: 13ecde851f08a7952f774707b19734f351bb6598 parent(s): 5027e0b035f96e2583eff2d1ac71c7c44a093ac8 committer: Jan Lindström branch nick: 10.0-git

[Maria-developers] MDEV-7937: Enforce SSL when --ssl client option is used

2015-05-17 Thread Vicențiu Ciorbaru
Hi Sergei! I've done some work on this issue. I've read MySQL's implementation of this and have looked at our implementation. They have done a bit of refactoring, introducing an enforce_ssl flag, as well as changing the C interface a bit, to allow setting this flag programatically. I've created

Re: [Maria-developers] MDEV-6877 - binlog_row_image implementation advice

2015-04-06 Thread Vicențiu Ciorbaru
info which we don't use (need?). There are a lot of changes made and I've tried my best to not miss anything. I agree that the git history could be better. I will rewrite it when I get the final code variant. Regards, Vicentiu On Mon, 30 Mar 2015 at 17:22 Vicențiu Ciorbaru vicen...@mariadb.org

Re: [Maria-developers] MDEV-6877 - binlog_row_image implementation advice

2015-04-06 Thread Vicențiu Ciorbaru
I've also added a bunch of inline comments to the github commits to further explain my reasoning. Going through the commits in order chronologically might make the most sense. Regards, Vicențiu On Mon, 6 Apr 2015 at 17:39 Vicențiu Ciorbaru vicen...@mariadb.org wrote: Hi Kristian, I've gotten

Re: [Maria-developers] MDEV-6877 - binlog_row_image implementation advice

2015-06-22 Thread Vicențiu Ciorbaru
...@knielsen-hq.org wrote: Vicențiu Ciorbaru vicen...@mariadb.org writes: I've gotten to a sort of stable state with binlog_row_image. It's not 100% complete as I did not add any tests for the new use cases. Also there are a couple of changes that I am not 100% sure if they are complete

[Maria-developers] [MDEV-7122] Questions regarding code history

2015-12-04 Thread Vicențiu Ciorbaru
Hi Sergey! I've been investigating MDEV-7122. I'm still quite a ways to go before I can understand all the underlying bits of logic. I need a little help regarding a change that you've committed a while back. Do you know (remember) why you've placed DBUG_ASSERT(0) in the commit:

Re: [Maria-developers] BUILD ERROR

2015-12-11 Thread Vicențiu Ciorbaru
Hi Laketra, As far as I know, MariaDB tokudb engine does not work on Mac OS. To not compile tokudb you can run during cmake Cmake. -DPLUGIN_TOKUDB=NO Then run make. Make sure to delete cmakecache.txt before running cmake again. Vicentiu On Fri, 11 Dec 2015 at 11:19, Laketra Musa

Re: [Maria-developers] [Commits] 9d8ad0d: Add --persistent option for mysqlcheck

2015-12-15 Thread Vicențiu Ciorbaru
Git log show his name, I think that the commit message generated by the hook is at fault. On Tue, 15 Dec 2015 at 16:20 Vicențiu Ciorbaru <cvicen...@gmail.com> wrote: > Hi Sergey, > > The commit message still has his name on it. > > I've only added some code to it, but I

Re: [Maria-developers] [Commits] 9d8ad0d: Add --persistent option for mysqlcheck

2015-12-15 Thread Vicențiu Ciorbaru
200, Vicentiu Ciorbaru wrote: > > revision-id: 9d8ad0d79e3c3a1a9bf7c8cc6477ee4e69fba633 > (mariadb-10.0.22-63-g9d8ad0d) > > parent(s): e9b4a041af5122dffd59012493c565e6e3db2664 > > committer: Vicențiu Ciorbaru > > timestamp: 2015-12-15 11:11:28 +0200 > > message: >

Re: [Maria-developers] Please review MDEV-8092 Change Create_field::field from "const char *" to LEX_CSTRING

2016-01-07 Thread Vicențiu Ciorbaru
Hi Alexander, Sergei, On Fri, 8 Jan 2016 at 00:10 Alexander Barkov wrote: > Hi Sergei, > > > On 01/07/2016 08:53 PM, Sergei Golubchik wrote: > > Hi, Alexander! > > > > On Nov 27, Alexander Barkov wrote: > >> Hi Serg, > >> > >> Please review a patch for MDEV-8092. > > > > I

Re: [Maria-developers] Use of std::string

2016-01-07 Thread Vicențiu Ciorbaru
On Wed, 6 Jan 2016 at 21:48 Sergei Golubchik <s...@mariadb.org> wrote: > Hi, Vicențiu! > Hi Sergei! > On Jan 05, Vicențiu Ciorbaru wrote: > > > > Sample code where we can avoid ifs: > > > > case SSL_TYPE_SPECIFIED: > > table->fie

[Maria-developers] Use of std::string

2016-01-05 Thread Vicențiu Ciorbaru
Hi Sergei, I was doing some work within sql_acl.cc, having to refactor a bit of logic regarding USER_RESOURCES and SSL related stuff and I'm thinking of making use of std::string instead of const char* to remove the need for checking NULL pointers. I noticed that we generally do not make any use

Re: [Maria-developers] Please review MDEV-8092 Change Create_field::field from "const char *" to LEX_CSTRING

2016-01-08 Thread Vicențiu Ciorbaru
. Vicentiu On Fri, 8 Jan 2016 at 09:36, Alexander Barkov <b...@mariadb.org> wrote: > Hi Vicențiu, > > > On 01/08/2016 02:48 AM, Vicențiu Ciorbaru wrote: > > Hi Alexander, Sergei, > > > > On Fri, 8 Jan 2016 at 00:10 Alexander Barkov <b...@mariadb.o

Re: [Maria-developers] [Commits] 6414959: MDEV-7526: TokuDB doesn't build on OS X

2015-12-20 Thread Vicențiu Ciorbaru
0b45a6b79 > > author: Vicențiu Ciorbaru > > committer: Vicențiu Ciorbaru > > timestamp: 2015-12-19 14:14:10 +0200 > > message: > > > > MDEV-7526: TokuDB doesn't build on OS X > > > > This patch fixes another compilation error caused by s

[Maria-developers] Error Compiling MariaDB with clang on Mac Os X

2015-12-01 Thread Vicențiu Ciorbaru
Hi Sergei, While working on features for 10.2 I've encountered a problem when compiling MariaDB as a Debug build. According to your change on commit 29dd634a4c0b9c3579cf9d318ed64d748d848b1d dbug: correct trace for DBUG_RETURN(func()); This causes a small problem, in two places within the

[Maria-developers] Invalid code in server_audit.c

2016-02-06 Thread Vicențiu Ciorbaru
Hi Alexei, While investigating community contributions from Daniel Black (MDEV-9433), I came across this comment: [image: danblack]Daniel Black added a comment - 2016-01-20 02:54 [plugin/server_audit/server_audit.c:402]:

Re: [Maria-developers] [Commits] a0c06ba: Preliminary implementation for the aggregate sum function as a window function

2016-03-14 Thread Vicențiu Ciorbaru
at 03:44:48PM +0200, Vicentiu Ciorbaru wrote: > > revision-id: a0c06ba1edb54c8c4705189c0455137a85658297 > (mariadb-10.1.8-154-ga0c06ba) > > parent(s): ce8a0d8e19e7bf1486a2c80ff6b7a30ef35bf99f > > author: Vicențiu Ciorbaru > > committer: Vicențiu Ciorbaru > > timest

Re: [Maria-developers] Aggregate Stored Functions

2016-05-19 Thread Vicențiu Ciorbaru
Hi Sanja, Since we have not officially started the coding period, I figured that an exercise in adding a parser syntax would be a good first step. We can do automatic detection by looking at the cursor without to much extra work. Vicentiu On Fri, 20 May 2016 at 08:29, Sanja

Re: [Maria-developers] Aggregate Stored Functions

2016-05-23 Thread Vicențiu Ciorbaru
Hi Varun, Getting the parser to accept the syntax is a good first step. Writing tests is the correct way to go also. Now we need to have a way to pass this extra information to the part of the code that stores / executes this procedure. When we encounter this AGGREGATE_SYM syntax we have to

Re: [Maria-developers] Aggregate Stored Functions

2016-05-24 Thread Vicențiu Ciorbaru
; not. So i created the new flag inside sp_head, so as to make sure it could >> be used for stored procedures too in the future. >> I have committed the changes on GitHub :) >> >> On Mon, May 23, 2016 at 4:21 PM, Vicențiu Ciorbaru <cvicen...@gmail.com> >> wrote: >>

Re: [Maria-developers] [Commits] b1ddc7d: MDEV-9487: Server crashes in Time_and_counter_tracker::incr_loops with UNION in ALL subquery

2016-05-04 Thread Vicențiu Ciorbaru
Hi Sanja, Sergey, I think Sergey might have mean the same thing but it is not clear to me. in_optimize never gets set to true. By mentioning that it is redundant that means that it can be removed from the current code right? Also, I would put the "return true" conditions after the "return false"

Re: [Maria-developers] [Commits] 5486f34: MDEV-10341: InnoDB: Failing assertion: mutex_own(mutex) - mutex_exit_func

2016-08-02 Thread Vicențiu Ciorbaru
ntiu wrote: > > revision-id: 5486f3458859fa4bd161150b9ac0e9c0f633a0e3 > (mariadb-10.2.1-9-g5486f34) > > parent(s): 08683a726773f8cdf16a4a3dfb3920e5f7842481 > > author: Vicențiu Ciorbaru > > committer: Vicențiu Ciorbaru > > timestamp: 2016-08-01 14:43:41 +0300 > >

Re: [Maria-developers] Please review MDEV-11692 Comparison data type aggregation for pluggable data types

2017-01-31 Thread Vicențiu Ciorbaru
Hi Alexander! Comments inline. OK to push otherwise. > diff --git a/sql/item_cmpfunc.cc b/sql/item_cmpfunc.cc > index fc3f81a..6fcfec4 100644 > --- a/sql/item_cmpfunc.cc > +++ b/sql/item_cmpfunc.cc > @@ -118,8 +118,11 @@ static int cmp_row_type(Item* item1, Item* item2) > 0 otherwise > */

Re: [Maria-developers] Please review MDEV-9979 Keywords UNBOUNDED, PRECEDING, FOLLOWING, TIES, OTHERS should be non-reserved

2017-01-31 Thread Vicențiu Ciorbaru
Hi Alexander, OK to push. Please add the version of the standard you used to check these keywords as non-reserved both to the commit message, as well as the keywords themselves. I used 2011 standard draft to check. Vicențiu On Mon, 23 Jan 2017 at 09:28 Alexander Barkov wrote:

[Maria-developers] Fwd: 41f885f64fe: MDEV-10859: Wrong result of aggregate window function in query with HAVING and no ORDER BY

2017-02-14 Thread Vicențiu Ciorbaru
or: Vicențiu Ciorbaru committer: Vicențiu Ciorbaru timestamp: 2017-02-14 14:02:29 +0200 message: MDEV-10859: Wrong result of aggregate window function in query with HAVING and no ORDER BY Window functions need to be computed after applying the HAVING clause. An optimization that we have for regular

Re: [Maria-developers] [Commits] 822aa21672b: MDEV-11170: MariaDB 10.2 cannot start on MySQL 5.7 datadir

2017-02-13 Thread Vicențiu Ciorbaru
rote: > > revision-id: 822aa21672ba6650a31a3ec05ab5c1bce7a80c1e > (mariadb-10.2.3-198-g822aa21672b) > > parent(s): b745ea489f0698c328383d9b8ec20d2f9777b1b8 > > author: Vicențiu Ciorbaru > > committer: Vicențiu Ciorbaru > > timestamp: 2017-02-13 14:44:00 +0200 > > message: > &

Re: [Maria-developers] c56c966: MDEV-10563 Crash during shutdown in Master_info_index::any_slave_sql_running

2016-08-16 Thread Vicențiu Ciorbaru
Hi Kristian, Thanks for the quick and thorough reply. As to the patch, you're basically moving the check for NULL into all the > callers. I'm not sure if the check is even needed for all callers, but > then, > I also do not think it's worth it to try and determine where it is needed > and where

Re: [Maria-developers] Sachin weekly report

2016-08-26 Thread Vicențiu Ciorbaru
k , Sergei? > Regards > sachin > > On Fri, Aug 26, 2016 at 7:26 PM, Vicențiu Ciorbaru <vicen...@mariadb.org> > wrote: > > Hi Sachin, Sergei! > > > > One quick thing I wanted to point out. I did not specifically look at how > > things get called, but, > >

Re: [Maria-developers] Deleting unused branches on github

2016-11-07 Thread Vicențiu Ciorbaru
Hi! I'm wondering if it makes sense to have an automatic cleanup process for branches older than X months? We can potentially add some exceptions for work that needs to stay. Regards, Vicențiu On Mon, 7 Nov 2016 at 18:54 Sergey Vojtovich wrote: > Hi! > > ALL BRANCH OWNERS:

Re: [Maria-developers] [Commits] aa9bd40: MDEV-10824 - Crash in CREATE OR REPLACE TABLE t1 AS SELECT spfunc()

2016-10-24 Thread Vicențiu Ciorbaru
Hi Sergey! I think you commited the AAA.test file by mystake. Regards, Vicentiu On Mon, 24 Oct 2016 at 13:47 Sergey Vojtovich wrote: > revision-id: aa9bd40f8067e1421ad71d2ada367544a6db78ca > (mariadb-10.0.27-8-gaa9bd40) > parent(s): 4dfb6a3f54cfb26535636197cc5fa70fe5bacc2e >

Re: [Maria-developers] Error building mariadb-10.0 with Clang 3.8: Unqualified lookup in templates

2016-10-13 Thread Vicențiu Ciorbaru
Hi Luke! This is a know problem that will be fixed in the upcoming release. https://jira.mariadb.org/browse/MDEV-5944 Regards, Vicențiu On Thu, 13 Oct 2016 at 09:16 Luke Benes wrote: > Building mariadb-10.0 with Clang results in: > > graph_concepts.hpp:93:17: error:

Re: [Maria-developers] [Commits] 27af988: MDEV-11479 Improved wsrep_dirty_reads

2016-12-08 Thread Vicențiu Ciorbaru
Hi Sachin! Comments inline: On Sun, 4 Dec 2016 at 08:36 wrote: > revision-id: 27af98805c27c8e0c41dc8c19bf80aefff4c6d3d > (mariadb-galera-5.5.53-3-g27af988) > parent(s): 72fd15f7c31aa3e3705ae1b005a3247a985c5bb3 > author: SachinSetiya > committer: SachinSetiya > NIT:

Re: [Maria-developers] [Commits] 02e74a5: MDEV-11700: MariaDB 10.2 cannot start on MySQL 5.7 datadir:

2016-12-11 Thread Vicențiu Ciorbaru
Hi Daniel! On Mon, 12 Dec 2016 at 04:08 Daniel Black <daniel.bl...@au1.ibm.com> wrote: > nit - its really MDEV-11170 > Argh, thanks. That's always annoying to get right :) > On 12/12/16 12:57, Vicențiu Ciorbaru wrote: > > Hi Sergei! > > > > Can you please

Re: [Maria-developers] 02e74a5: MDEV-11700: MariaDB 10.2 cannot start on MySQL 5.7 datadir:

2016-12-11 Thread Vicențiu Ciorbaru
8175836221d363ea > author: Vicențiu Ciorbaru > committer: Vicențiu Ciorbaru > timestamp: 2016-12-12 03:42:11 +0200 > message: > > MDEV-11700: MariaDB 10.2 cannot start on MySQL 5.7 datadir: > > Fatal error: mysql.user table is damaged or in unsupported 3.20 format > >

[Maria-developers] Fwd: mixing of user-defined data types with other data types

2016-12-12 Thread Vicențiu Ciorbaru
Hi Alexander! Comments inline. Most are stylistic comments. I think the patch is great. The Item_type_holder is really bugging me though. It feels poorly designed in the current place. > diff --git a/sql/field.cc b/sql/field.cc > index 6f273e6..7876a6f 100644 > --- a/sql/field.cc > +++

Re: [Maria-developers] Please review MDEV-9522 Split sql_select.cc:can_change_cond_ref_to_const into virtual methods in Type_handler

2017-01-12 Thread Vicențiu Ciorbaru
Hi Alexander! Ok to push this one. I really like how this splits the function. Please put a comment that collation does not make sense (and thus is no concern) for numerical type handlers in the function where you compare them by pointer address. Also, Item_get_cache should be on a separate

Re: [Maria-developers] MDEV-11330 Split Item_func_hybrid_field_type::val_xxx() into methods in Type_handler

2016-12-04 Thread Vicențiu Ciorbaru
Hi Alexander! I find this version much cleaner! Looks good to me. What I'd really like to see later is if we can write some unit tests for these conversions. Not mtr linked tests but actual unit tests specifically using these Items. I am up for chipping in and writing some myself. One thing I'd

Re: [Maria-developers] Fwd: mixing of user-defined data types with other data types

2016-12-28 Thread Vicențiu Ciorbaru
Hi Alexander, I've reviewed your second patch. Comments inline. >> +} > >> > >> > >> /* > >> diff --git a/sql/field.h b/sql/field.h > >> index 541da5a..fa84e7d 100644 > >> --- a/sql/field.h > >> +++ b/sql/field.h > >> @@ -835,7 +835,6 @@ class Field: public Value_source > >>virtual

Re: [Maria-developers] Gsoc project

2017-03-26 Thread Vicențiu Ciorbaru
Hi! Yes, Table Functions are at the moment not a GSoC Project. We will need to probably restructure the project (scoping and such), so in order to not have you write proposals for an uncertain one, we have removed the gsoc2017 label from the MDEV. Regards, Vicențiu On Sun, 26 Mar 2017 at 21:24

Re: [Maria-developers] Please review patch for 12017 and 12018.

2017-04-09 Thread Vicențiu Ciorbaru
Hi Sachin! I'll review the patch. If Monty wants to chip in he can do so. 1. Indentation is wrong for the patch, you have an extra step of indentation. 2. I would use only one return true statement, after the if/else statement. 3. For singular subject sentence use does instead of do. So:

Re: [Maria-developers] Errors in building debs

2017-04-01 Thread Vicențiu Ciorbaru
Latest push ought to fix this. Waiting for buildbot to confirm. On Fri, 31 Mar 2017 at 23:05, Sergey Petrunia wrote: Hi Vicențiu, I'm looking at the last build in bb-10.2-mariarocks

Re: [Maria-developers] Refactoring in LEX_STRING and LEX_CSTRING

2017-04-19 Thread Vicențiu Ciorbaru
Hi! I would like to add a few more arguments in favour of using const references and not const pointers. I do not endorse non-const references, that makes the code silly and confusing a lot of the times. When we need output or input-output parameters we should keep using pointers. For strictly

Re: [Maria-developers] GSoC 2016 Student Introduction. [ MDEV-4989 ]

2017-03-12 Thread Vicențiu Ciorbaru
Hi Mike! For debugging on OS X I suggest you use lldb instead of gdb, if you're having troubles with gdb. At the same time you can get gdb to work but sometimes it doesn't work as you expect it to, so lldb might be your best alternative. Using mysql-test-run with lldb will also be somewhat

[Maria-developers] Fwd: ecbad0a07a8: MDEV-13189: Window functions crash when using INTERVAL

2017-06-28 Thread Vicențiu Ciorbaru
using INTERVAL To: <comm...@mariadb.org> revision-id: ecbad0a07a848c1f9f474c4c749c87b6bfe7986c (mariadb-10.2.6-74-gecbad0a07a8) parent(s): 31ba0fa48d27715e82258b1e74401093e0ee17a2 author: Vicențiu Ciorbaru committer: Vicențiu Ciorbaru timestamp: 2017-06-28 21:07:55 +0300 message: MDEV-1

[Maria-developers] Review of PERCENTILE_CONT && PERCENTILE_DISC

2017-07-04 Thread Vicențiu Ciorbaru
Hi Varun, Here's the review for your patch. > diff --git a/mysql-test/t/percentile.test b/mysql-test/t/percentile.test > new file mode 100644 > index 000..0958fc05e7d > --- /dev/null > +++ b/mysql-test/t/percentile.test > @@ -0,0 +1,41 @@ Whenever you are adding a test case, please add

Re: [Maria-developers] cte page

2017-04-27 Thread Vicențiu Ciorbaru
Very good! Congratulations on finishing the paper! Thank you for all the great work. :) Vicențiu On Thu, 27 Apr 2017 at 09:11 Galina Shalygina wrote: > мои артиклы > ___ Mailing list: https://launchpad.net/~maria-developers

Re: [Maria-developers] Cannot push branch to github

2017-05-26 Thread Vicențiu Ciorbaru
> > On Thu, May 25, 2017 at 12:44 PM, Vicențiu Ciorbaru <vicen...@mariadb.org> > wrote: > >> Hi Valentin! >> >> The correct way to do a pull request is to create your own fork of the >> server repository. You don't need any special permissions for that. >&g

Re: [Maria-developers] Cannot push branch to github

2017-05-25 Thread Vicențiu Ciorbaru
Hi Valentin! The correct way to do a pull request is to create your own fork of the server repository. You don't need any special permissions for that. Afterwards, push your changes to your fork. Finally, click on New pull request button in *your* repository. Select the appropriate branch for the

Re: [Maria-developers] cte page

2017-05-04 Thread Vicențiu Ciorbaru
Hi Jocelyn! There have been quite a few requests to benchmark this. Although CTE merging conflicts with reusing, it would be interesting to get some results in. The best person to do this is a third party, as any one from MySQL or MariaDB may be biased in choosing workloads. Nonetheless it is

Re: [Maria-developers] 46b93fc: MDEV-13676: Field "create Procedure" is NULL, even if the the user has role which is the definer. (SHOW CREATE PROCEDURE)

2017-10-11 Thread Vicențiu Ciorbaru
fa198d721813d9b93bbe09d2e36eb3 > (mariadb-10.0.32-50-g46b93fc) > > parent(s): dbeffabc83ed01112e09d7e782d44f044cfcb691 > > author: Vicențiu Ciorbaru > > committer: Vicențiu Ciorbaru > > timestamp: 2017-10-09 13:32:40 +0300 > > message: > > > > MDEV-136

Re: [Maria-developers] [Commits] dccebdf862d: Rdb_io_watchdog doesn't support osx so disabling it

2017-08-30 Thread Vicențiu Ciorbaru
Hi Varun! Please change the CMakeLists.txt to be like so: diff --git a/storage/rocksdb/CMakeLists.txt b/storage/rocksdb/CMakeLists.txt index 5db6d88..6db8211 100644 --- a/storage/rocksdb/CMakeLists.txt +++ b/storage/rocksdb/CMakeLists.txt @@ -146,7 +146,10 @@

[Maria-developers] Review: MDEV-12985: Support percentile and media window functions

2017-08-30 Thread Vicențiu Ciorbaru
Hi Varun! Here is the in-detail review for the percentile functions. Please add a grammar definition for median too and test it. All in all, not many changes, but please address my comments. If you disagree with some of them, let's discuss them. > diff --git

Re: [Maria-developers] Proposal for Negative Grants Project

2018-05-12 Thread Vicențiu Ciorbaru
Hi Sergei! On Fri, 11 May 2018 at 21:10 Sergei Golubchik wrote: > Hi, Rutuja! > > I think it would've be useful to put your main ideas into MDEV-14443, as > a comment. > > For now I've just added a link to your email. > > On May 09, Rutuja Surve wrote: > > Hello, > > Please

Re: [Maria-developers] [Commits] 4861977ce76: MDEV-14695: Assertion `n < m_size' failed in Bounds_checked_array::operator

2018-05-13 Thread Vicențiu Ciorbaru
Hi Varun! I will take a second look at this but a first minor comment is to not save two characters by shortening fields to flds, it makes reading unnatural. Vicentiu On Sat, 12 May 2018 at 21:45 Varun wrote: > revision-id: 4861977ce76761fefb9779a774984b6afa818f2e >

Re: [Maria-developers] unbundle RocksDB

2018-06-10 Thread Vicențiu Ciorbaru
Hi Michal, Just so you know, we've been discussing the possibility of adding compression services to the server, which would allow removing some static libraries from the code. This however is probably a bit far on the horizon as we haven't particularly scheduled it for 10.4 (yet). Vicentiu On

Re: [Maria-developers] [Maria-discuss] MariaDB crashes because of "long semaphore wait" after migrating from 10.1 to 10.3

2018-06-10 Thread Vicențiu Ciorbaru
Hi! I have cc'ed the maria-developers mailing list as this is potentially a dev issue and also the devs responsible for Windows and InnoDB development. There might be some people on vacation right now, but this should get looked into in a week or two at most. Let's find a solution for your

Re: [Maria-developers] With_sum_func_cache

2018-05-31 Thread Vicențiu Ciorbaru
Hi Alexander! I was looking through this patch as I am rather familiar with this code. I didn't take time to test this out, but maybe you can explain if this is a possible concern or not: index 4a95189..7d1532c 100644 --- a/sql/item_sum.cc +++ b/sql/item_sum.cc @@ -404,7 +404,7 @@ bool

Re: [Maria-developers] Proposal for Negative Grants Project

2018-05-31 Thread Vicențiu Ciorbaru
Hi Sergey! On Tue, 29 May 2018 at 17:54 Sergei Golubchik wrote: > Hi, Vicențiu! As you might've guessed from my comments above, I'd rather prefer to use > REVOKE instead of DENY, if we can make it to work (and to explain how it > works afterwards :). > > So here I suggest a semantics how

Re: [Maria-developers] [Commits] 326db1a: Mdev-14853 Grant does not work correctly when table contains...

2018-04-26 Thread Vicențiu Ciorbaru
Hi Sachin! Did you run this test on embedded server? Usually grant related tests require some form of not_embedded.inc include. (check roles suite for examples) Vicentiu On Thu, 26 Apr 2018 at 00:20 sachin wrote: > revision-id:

[Maria-developers] Review of Percentile Window Functions

2017-10-28 Thread Vicențiu Ciorbaru
Hi Varun, Here's the final review for Percentile Functions. Just 2 minor coding style comments. Rebase on top of current 10.3 and push to a bb-* branch to double check nothing breaks. Make sure that no merge commit happens. Regards, Vicențiu > diff --git a/sql/item_windowfunc.h

[Maria-developers] Review Custom Aggregate Functions

2017-10-28 Thread Vicențiu Ciorbaru
Hi Varun! Here's a final review for Custom Aggregate Functions * You haven't run the full test suite, there are a few failing tests. Please update those. rpl.rpl_sp funcs_1.is_columns_mysql funcs_1.storedproc * Push your code to a BB branch and rebase it on top of current 10.3. * Fix commits

Re: [Maria-developers] Please review MDEV-16584 SP with a cursor inside a loop wastes THD memory aggressively

2018-07-30 Thread Vicențiu Ciorbaru
Hi Alexander! Can you double check that this same problem doesn't occur with custom aggregate functions? There is a switch involved with cursors and custom aggregate functions here: /* Only pop cursors when we're done with group aggregate running. */ if (m_chistics.agg_type !=

Re: [Maria-developers] Please review a patch for MDEV-15758 Split Item_bool_func::get_mm_leaf() into virtual methods in Field and Type_handler

2018-07-18 Thread Vicențiu Ciorbaru
Hi Alexander! (I was doing some experimentation with the code and forgot to send the email properly) So the main things we discussed during the review: We discussed alternative of not adding SEL_ARG_XXX classes and instead have separate constructors within SEL_ARG. I tried to do this myself but

Re: [Maria-developers] Regarding bugs (mysqldump)

2018-04-01 Thread Vicențiu Ciorbaru
Hi Rutuja! Great analysis again and lets share this with the maria-developers mailing list as well. I've tested your proposed change and the change for dump_all_tables_in_db seems to not be necessary. If you look at how dump_all_tables_in_db gets called, it's followed by dump_all_views_in_db.

Re: [Maria-developers] [Commits] c9ae1234814: MDEV-14592: Custom Aggregates Usage Status Variable

2018-03-26 Thread Vicențiu Ciorbaru
Hi Varun This generally looks good, 2 comments inline. Vicentiu diff --git a/mysql-test/t/custom_aggregate_functions.test b/mysql-test/t/custom_aggregate_functions.test index 20fcc35f39f..a93ec545f01 100644 --- a/mysql-test/t/custom_aggregate_functions.test +++

Re: [Maria-developers] Observation for CHECK_CONSTRAINTS MDEV 14474

2018-03-31 Thread Vicențiu Ciorbaru
Hi Anel! I've reviewed your patch and generally things look good. You do some good analysis usually and I think we should highlight your work to the broader developer scene. I've thus CC'ed this email to the maria-developers mailing list. This gives us a chance to get feedback from outside,

Re: [Maria-developers] GSoC 2018 - Histograms with equal-width bins

2018-03-22 Thread Vicențiu Ciorbaru
Hi Teodor, In order to get started with the project you need to see how we currently gather statistics from tables. You should first read up on: https://mariadb.com/kb/en/library/engine-independent-table-statistics/ Note we are interested in *engine independent table statistics*, not engine

Re: [Maria-developers] MDEV-12321 authentication plugin: SET PASSWORD support

2018-10-21 Thread Vicențiu Ciorbaru
Hi Sergei! Here are my review comments, inline. Read them from oldest to newest commit, that's how I wrote them. :) On 17/10/2018 23:40, Sergei Golubchik wrote: Hi, Please review commits for MDEV-12321 "authentication plugin: SET PASSWORD support" They're now in the bb-10.4-serg

Re: [Maria-developers] MDEV-12321 authentication plugin: SET PASSWORD support

2018-10-21 Thread Vicențiu Ciorbaru
Hi Sergei! About the syntax problem, inline: On 17/10/2018 23:40, Sergei Golubchik wrote: Hi, Now, the syntax problem. Old MySQL syntax (for the last ~20 years) was (1) GRANT ... TO user IDENTIFIED BY 'plain-text password' (2) GRANT ... TO user IDENTIFIED BY PASSWORD 'password hash' (3)

Re: [Maria-developers] 02587f61f40: MDEV-13095 Implement User Account locking

2019-01-20 Thread Vicențiu Ciorbaru
Hi Sergei! I agree with most review comments except one: > > information. > > > > diff --git a/mysql-test/include/switch_to_mysql_user.inc b/mysql- > > test/include/switch_to_mysql_user.inc > > index f5801db6114..eff1d98c2df 100644 > > --- a/mysql-test/include/switch_to_mysql_user.inc > > +++

[Maria-developers] Extending storage engine API for random-row extraction for histogram collection (and others)

2018-12-10 Thread Vicențiu Ciorbaru
Hi! Here is my proposal on extending the storage engine API to provide a functionality for retrieving random rows from tables (those that have indexes). The storage engines for which I plan to implement this are: MyISAM, Aria, Innodb. Possibly RocksDB, TokuDB. --- a/sql/handler.h +++

Re: [Maria-developers] Extending storage engine API for random-row extraction for histogram collection (and others)

2018-12-11 Thread Vicențiu Ciorbaru
On Tue, 11 Dec 2018 at 12:43 Sergey Petrunia wrote: > > On Tue, Dec 11, 2018 at 12:34:12AM +0200, Vicențiu Ciorbaru wrote: > > Hi! > > > > Here is my proposal on extending the storage engine API to provide a > > functionality for retrieving random rows from table

Re: [Maria-developers] Extending storage engine API for random-row extraction for histogram collection (and others)

2018-12-11 Thread Vicențiu Ciorbaru
Hi Sergei! > For the first iteration, after considering your input, I'd go with > > "init function", "get random row", "end function", without imposing an > > index, but somehow passing a (COND or similar) arg to the init > > function. > > For the first iteration I'd go without a condition. You,

Re: [Maria-developers] Extending storage engine API for random-row extraction for histogram collection (and others)

2018-12-11 Thread Vicențiu Ciorbaru
On Tue, 11 Dec 2018 at 14:33 Sergei Golubchik wrote: > Hi, Vicențiu! > > On Dec 11, Vicențiu Ciorbaru wrote: > > Hi! > > > > Here is my proposal on extending the storage engine API to provide a > > functionality for retrieving random rows from tables (those th

[Maria-developers] Review for ANALYZE TABLE with Sampling

2019-02-10 Thread Vicențiu Ciorbaru
Hi Sergei! Can you review that you are happy with the storage engine API changes? I'veustructured the commit to be as small as possible to achieve the desired outcome. In my tests, we are now twice as fast as MySQL for a 10 mil row table with 13 columns. Vicențiu Forwarded Message

[Maria-developers] Review for follow up fix of MDEV-17323: Backport INFORMATION_SCHEMA.CHECK_CONSTRAINTS to 10.2

2019-01-31 Thread Vicențiu Ciorbaru
Hi Anel! This is not a terribly bad patch, however you have forgotten the following things: You removed the misspelled is_check_constraint.test file, but forgot to remove the is_check_constraint.result file. Now we would be left with a dangling result file. Please be more careful next time.

Re: [Maria-developers] GSoC Introduction

2019-05-26 Thread Vicențiu Ciorbaru
Hi Rucha! Great start. Whenever you have some code ready for the parser part, please share the repository and the branch onto which you are pushing your code. We should discuss implementation details once you have managed to get the grammar to work. Remember to include test cases to show that

[Maria-developers] Welcome to GSoC 2019

2019-05-10 Thread Vicențiu Ciorbaru
Hi! As you may have noticed a few days ago, you have received an email from Google that you have been accepted as part of Google Summer of Code. Congratulations on the effort to learn about the program, get involved and submit succesful proposals. The fun part begins now! If you have not done

[Maria-developers] INSERT ... RETURNING Initial code review

2019-07-07 Thread Vicențiu Ciorbaru
Hi Rucha! Here is the promised review. I have run the main test suite locally and have noticedthat some tests fail if you run with a debug build. The failure is an assertionfailure on the protocol level. This means you forgot to call a my_ok or my_errorat an appropriate time. I suggest you try and

[Maria-developers] Congratulations on a successful GSoC!

2019-09-05 Thread Vicențiu Ciorbaru
to help others! In this sense, I encourage you to keep being active in the community and share what you have learned. :) Thank you for a great summer! Vicențiu Ciorbaru GSoC MariaDB Foundation Admin ___ Mailing list: https://launchpad.net/~maria-developers

[Maria-developers] Coding Style Review INSERT RETURNING

2019-08-07 Thread Vicențiu Ciorbaru
Hi Rucha! This is going to be a very thorough review looking at coding style. I'll nitpick on every line of code where I find something, just be patient and let's clean up everything. You might consider me picking on the coding style a bit pedantic, but it really is important. It is important

[Maria-developers] INSERT ... RETURNING intermediate review

2019-07-20 Thread Vicențiu Ciorbaru
Hi Rucha! I've spent quite a bit of time looking at the implementation. It is working and passes almost all test cases, although you forgot to also commit the insert_parser updated result file. Good job so far. I want to give you something to work on and think about for a bit before we do another

Re: [Maria-developers] MariaDB for CentOS 8

2019-10-04 Thread Vicențiu Ciorbaru
Should be fixed now! Thanks for letting us know about the problem. On 04.10.2019 00:31, Daniel Bartholomew wrote: On Thu, 3 Oct 2019 22:00:16 +0530 Thomas Stephen Lee wrote: Hi, Please release MariaDB 10.4 for CentOS 8. https://downloads.mariadb.org/mariadb/repositories/ does not show

  1   2   >