[Maria-developers] Weekly Report

2019-08-18 Thread Rucha Deodhar
Report for week 12: Hi! This week I merged some test cases in respective files into one so that the tests can be under 80 lines and also improved the documentation. Documentation for INSERT...RETURNING:

[Maria-developers] Weekly Report

2019-08-11 Thread Rucha Deodhar
Report for week 11: Hello! This week I worked on cleaning up the code, commits and test cases. I was a little less familiar with git rebase -i so tried a couple of things on a dummy repo first and then cleaned up the commits on my repo. I also worked on the coding style review and removed all

[Maria-developers] Weekly Report

2019-08-04 Thread Rucha Deodhar
Report for week 10: Hello! Report for Week 10: Hello! This week I worked on adding system variable feature_insert_returning which is useful for feedback plugin. This variable increments each time INSERT...RETURNING or REPLACE...RETURNING is used. Before beginning, I did some reading about

[Maria-developers] Weekly Report

2019-07-28 Thread Rucha Deodhar
Report for week 9: Hello! This week I worked on documentation, added some comments to the code and removed some lines of code from parser as it was still making use of SELECT_LEX::item_list after opt_select_expressions. I was referring DELETE...RETURNING test case and noticed case for using

[Maria-developers] Weekly Report

2019-07-21 Thread Rucha Deodhar
Report for week 8: Hello! This week I worked on the parser. I removed the hack "swapping lists" we had used earlier. Now the grammar uses values from the bison stack. However, I was making the list rule return the SELECT_LEX :: item_list. This was fixed after the intermediate review. I changed

[Maria-developers] Weekly Report

2019-07-14 Thread Rucha Deodhar
Report for week 7: Hello! This week I worked on the initial review for INSERT...RETURNING. I removed some lines from my code, used select_result* instead of using with_returning_list, improved formatting, restored the structure of SQL_I_List by removing *saved_first, moved returning_list to LEX

[Maria-developers] Weekly Report

2019-07-07 Thread Rucha Deodhar
Report for week 6: Hello! This week I was able to make replace...returning work. But before pushing changes for insert...select...returning, I had done a git merge because I didn't know I was supposed to do a git rebase. While undoing the merge I ran into a problem. With help from mentors I was

[Maria-developers] Weekly Report

2019-06-30 Thread Rucha Deodhar
Report for week 5: Hello! This week I was able to make INSERT...SELECT...RETURNING return the listed fields from the INSERT table. From the parsing stage in sql_parse.cc, the context and the first table gets masked , so I stored the previous values in another variable just before they are masked

[Maria-developers] Weekly Report

2019-06-23 Thread Rucha Deodhar
Report for week 4: Hello! This week I was able to make INSERT...RETURNING work. It is working fine for simple insert statement, inserting multiple rows in single statement, INSERT...SET and INSERT...ON DUPLICATE KEY UPDATE. It is returning the listed fields, working for alias and operators as

[Maria-developers] Weekly Report

2019-06-16 Thread Rucha Deodhar
Report for week 3: Hello! This week was more productive than the last one. Zulip messages helped to extend parser for INSERT...SELECT...RETURNING. I created SELECT_LEX :: returning_list and swapped it with SELECT_LEX :: item_list. I have also added test cases and result for the same. Feedback of

[Maria-developers] Weekly Report

2019-06-09 Thread Rucha Deodhar
Report for week 2: Hello! This week I ran the test case for parser written in last week and made changes in the parser according to the suggestions given, tried making insert...select..returning work. I analysed how RETURNING in delete is implemented, how insert is implemented, and how the data

Re: [Maria-developers] Weekly Report

2019-06-03 Thread Sergei Golubchik
Hi, Rucha! On Jun 03, Rucha Deodhar wrote: > Report for week 1: > > Hello! > > I made test cases and extended the parser for: > INSERT...RETURNING * and > INSERT...RETURNING > It is working fine for INSERT...ON DUPLICATE KEY UPDATE, INSERT...IGNORE, > INSERT...SET, and simple insert

[Maria-developers] Weekly Report

2019-06-02 Thread Rucha Deodhar
Report for week 1: Hello! I made test cases and extended the parser for: INSERT...RETURNING * and INSERT...RETURNING It is working fine for INSERT...ON DUPLICATE KEY UPDATE, INSERT...IGNORE, INSERT...SET, and simple insert statements. As I have never coded parser before, it was throwing errors