Re: [Maria-developers] [External] Re: Questions regarding closing partitions in MDEV-11084

2018-04-30 Thread Mattias Jonsson
Hi Jacob, Sorry for the confusion between the partitioning engine and spider. To add to the confusion: There are also different 'share' objects, table share (meaning to share info between different instances of the same table) and also partition share (meaning to share information for different

Re: [Maria-developers] [External] Re: Questions regarding closing partitions in MDEV-11084

2018-04-30 Thread Mattias Jonsson
Hi Holyfoot, Thank you for the fix. Btw should the tests be included as well or did you add them outside the commit? Regards Mattias On Sat, Apr 28, 2018 at 1:50 PM, Alexey Botchkov wrote: > Hello, guys. > > > 2) MDEV-11084 makes explicit partition selection work like

Re: [Maria-developers] [External] Re: Questions regarding closing partitions in MDEV-11084

2018-04-28 Thread Alexey Botchkov
Hello, guys. > 2) MDEV-11084 makes explicit partition selection work like FLUSH TABLE, due to the closing partitions part. After the discussion, I removed that part of the fix, so now the explicit statement won't force the partition close. So now the 'explicit_partition.test' passes. Best

Re: [Maria-developers] [External] Re: Questions regarding closing partitions in MDEV-11084

2018-04-26 Thread Jacob Mathew
Hi Mattias, There is an instance of Spider for each partition in the Spider node, so each instance of Spider handles exactly one partition/shard. So please elaborate on what you mean by Spider opening/closing specific partitions. Note that if we push the partitioning logic into each storage

Re: [Maria-developers] [External] Re: Questions regarding closing partitions in MDEV-11084

2018-04-26 Thread Mattias Jonsson
Hi Holyfoot, Sergei and Jacob, Thank you for looking into this. Jacob there are no Jira ticket (that I am aware of) also I do see it as two different problems with the same source. 1) Spider engine does not handle opening/closing specific partitions (as I understand it currently relies on

Re: [Maria-developers] [External] Re: Questions regarding closing partitions in MDEV-11084

2018-04-25 Thread Jacob Mathew
Hi Mattias and Holyfoot, Is there a Jira bug for this problem? If not I can create a bug for it and assign it to Holyfoot. Thanks, Jacob Jacob B. Mathew Spider and Server Developer MariaDB Corporation +1 408 655 8999 (mobile) jacob.b.mathew(Skype) jacob.mat...@mariadb.com On Tue, Apr

Re: [Maria-developers] [External] Re: Questions regarding closing partitions in MDEV-11084

2018-04-17 Thread Mattias Jonsson
Hi Holyfoot, On Mon, Apr 16, 2018 at 3:38 PM, Alexey Botchkov wrote: > Hi, Mattias, guys! > > While investigating the crash, i'd like to discuss that > >> it seems to close partitions whenever it >> is not used in a statement (i.e. require it to be reopened in the next >>