Re: [Maria-developers] 3f38da9145c: MDEV-20016 Add MariaDB_DATA_TYPE_PLUGIN

2019-09-27 Thread Sergei Golubchik
Hi, Alexander! On Sep 17, Alexander Barkov wrote: > On 9/16/19 10:33 PM, Sergei Golubchik wrote: > > Hi, Alexander! > > > > On Sep 16, Alexander Barkov wrote: > >> revision-id: 3f38da9145c (mariadb-10.4.4-251-g3f38da9145c) > >> parent(s): e6ff3f9d1c8 > >> author: Alexander Barkov > >>

Re: [Maria-developers] 3f38da9145c: MDEV-20016 Add MariaDB_DATA_TYPE_PLUGIN

2019-09-26 Thread Alexander Barkov
Hi Sergei, On 9/17/19 10:59 AM, Alexander Barkov wrote: Hi Sergei, Thank you for your review! I've fixed some of your suggestions. For other suggestions I have questions and comments. See below. A new patch is here:

Re: [Maria-developers] 3f38da9145c: MDEV-20016 Add MariaDB_DATA_TYPE_PLUGIN

2019-09-17 Thread Alexander Barkov
Hi Sergei, Thank you for your review! I've fixed some of your suggestions. For other suggestions I have questions and comments. See below. A new patch is here: https://github.com/MariaDB/server/commit/62d9ca85706bc0c78ca174703ca46e2e82002491 On 9/16/19 10:33 PM, Sergei Golubchik wrote:

Re: [Maria-developers] 3f38da9145c: MDEV-20016 Add MariaDB_DATA_TYPE_PLUGIN

2019-09-16 Thread Sergei Golubchik
Hi, Alexander! On Sep 16, Alexander Barkov wrote: > revision-id: 3f38da9145c (mariadb-10.4.4-251-g3f38da9145c) > parent(s): e6ff3f9d1c8 > author: Alexander Barkov > committer: Alexander Barkov > timestamp: 2019-07-12 07:53:55 +0400 > message: > > MDEV-20016 Add MariaDB_DATA_TYPE_PLUGIN > diff