Sergei, I made it as we agreed, please see the new commit:
9d04b702
--
Yours truly,
Nikita Malyavin
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscribe :
Hi, Nikita,
On Nov 01, Nikita Malyavin wrote:
> On Mon, 31 Oct 2022 at 21:22, Sergei Golubchik wrote:
>
> > > I hope RPL_TABLE_LIST can be preserved between the events. Is it
> > > so?
> >
> > Yes, it appears to be created in Table_map_log_event and removed on
> > commit. That is, it survives
On Mon, 31 Oct 2022 at 21:22, Sergei Golubchik wrote:
> > I hope RPL_TABLE_LIST can be preserved between the events. Is it so?
>
> Yes, it appears to be created in Table_map_log_event and removed on
> commit. That is, it survives multiple row events.
>
> Still, there are only two possibilities:
Hi, Nikita,
On Oct 31, Nikita Malyavin wrote:
> On Mon, 31 Oct 2022 at 14:08, Sergei Golubchik wrote:
> > On Oct 31, Nikita Malyavin wrote:
> > >
> > > > Also, I've looked at your latest branch. What were you
> > > > optimizing with the commit 3afa3288221 (the one with
> > > > usable_keys_data)?
On Mon, 31 Oct 2022 at 14:08, Sergei Golubchik wrote:
> Hi, Nikita,
>
> On Oct 31, Nikita Malyavin wrote:
> >
> > > Also, I've looked at your latest branch. What were you optimizing
> > > with the commit 3afa3288221 (the one with usable_keys_data)?
> > >
> > > It's complex and I don't quite see
Hi, Nikita,
On Oct 31, Nikita Malyavin wrote:
>
> > Also, I've looked at your latest branch. What were you optimizing
> > with the commit 3afa3288221 (the one with usable_keys_data)?
> >
> > It's complex and I don't quite see what's the purpose of it. It
> > looks like all you need to do is to
Hi!
On Sun, 30 Oct 2022 at 18:20, Sergei Golubchik wrote:
> still, you didn't use `f == f->table->next_number_field`
> but we concluded it's safe, didn't we?
>
>
Yes, I just think I only fixed it in the last commit "improve DEFAULT
rules" (13222947)
> Also, I've looked at your latest branch.
Hi, Nikita,
On Oct 18, Nikita Malyavin wrote:
> On Tue, 18 Oct 2022 at 01:01, Sergei Golubchik wrote:
>
> > > > > diff --git a/sql/log_event_server.cc b/sql/log_event_server.cc
> > > > > index 422d496d5c3..25705d13641 100644
> > > > > --- a/sql/log_event_server.cc
> > > > > +++
On Tue, 18 Oct 2022 at 01:01, Sergei Golubchik wrote:
> > > > diff --git a/sql/log_event_server.cc b/sql/log_event_server.cc
> > > > index 422d496d5c3..25705d13641 100644
> > > > --- a/sql/log_event_server.cc
> > > > +++ b/sql/log_event_server.cc
> > > > @@ -6062,7 +6065,7 @@ int
>
Hi, Nikita,
On Oct 17, Nikita Malyavin wrote:
> Hello Sergei!
>
> On Tue, 4 Oct 2022 at 21:02, Sergei Golubchik wrote:
>
> > Hi, Nikita,
> >
> > This review applies to the combined diff e2f8dff^..52f489e
> >
> > On Oct 04, Nikita Malyavin wrote:
> >
> > > diff --git a/sql/log_event.h
Hello Sergei!
On Tue, 4 Oct 2022 at 21:02, Sergei Golubchik wrote:
> Hi, Nikita,
>
> This review applies to the combined diff e2f8dff^..52f489e
>
> On Oct 04, Nikita Malyavin wrote:
>
> > diff --git a/sql/log_event.h b/sql/log_event.h
> > index 91a910f..8452e665c98 100644
> > ---
Hi, Nikita,
This review applies to the combined diff e2f8dff^..52f489e
On Oct 04, Nikita Malyavin wrote:
> diff --git a/sql/log_event.h b/sql/log_event.h
> index 91a910f..8452e665c98 100644
> --- a/sql/log_event.h
> +++ b/sql/log_event.h
> @@ -5275,8 +5278,11 @@ class Rows_log_event :
12 matches
Mail list logo
