Re: [Maria-developers] INSERT ... RETURNING Initial code review

2019-07-10 Thread Rucha Deodhar
Hello! I worked on the review and here is a report for the same. CODE: I fixed indentations and removed with_returning_list. Now I am using only the select_result pointer to know whether returning_list is empty (except in mysql_prepare_insert(). This function is using bool with_returning_list

Re: [Maria-developers] INSERT ... RETURNING Initial code review

2019-07-07 Thread Rucha Deodhar
Hello! Thanks for the review. It will indeed help me write better code and test cases. To begin with, I' ll first get familiar with git bisect. I'll keep you updated about my progress. Regards, Rucha Deodhar On Sun, Jul 7, 2019, 7:16 PM Vicențiu Ciorbaru wrote: > Hi Rucha! > > > Here is the