Hi, Sergey!
Just one comment:
On Oct 18, Sergey Vojtovich wrote:
> > > > > diff --git a/mysql-test/r/lock_tables_lost_commit.result
> > > > > b/mysql-test/r/lock_tables_lost_commit.result
> > > > > index 769e973..394ef0a 100644
> > > > > --- a/mysql-test/r/lock_tables_lost_commit.result
> > > >
Hi Sergei!
On Sat, Oct 15, 2016 at 11:13:24AM +0200, Sergei Golubchik wrote:
> Hi, Sergey!
>
> On Oct 15, Sergey Vojtovich wrote:
> > Hi Sergei,
> >
> > Sorry to say this, but you reviewed outdated commits. There's just one in
> > bb-10.2-mdev7660 now. Since value of those cleanups was rather qu
Hi, Sergey!
On Oct 15, Sergey Vojtovich wrote:
> Hi Sergei,
>
> Sorry to say this, but you reviewed outdated commits. There's just one in
> bb-10.2-mdev7660 now. Since value of those cleanups was rather questionable
> and I got conflicts on rebase I discarded them.
Oh, okay. I know that feeling,
Hi Sergei,
Sorry to say this, but you reviewed outdated commits. There's just one in
bb-10.2-mdev7660 now. Since value of those cleanups was rather questionable
and I got conflicts on rebase I discarded them.
Still some answers inline.
On Fri, Oct 14, 2016 at 08:12:52PM +0200, Sergei Golubchik w
Hi, Sergey!
Here's a review of the last two commits in bb-10.2-mdev7660
(I've quickly looked through other, cleanup, commits, didn't have any
comments, so I've excluded them from the diff to make it smaller)
> diff --git a/mysql-test/t/innodb_mysql_lock.test
> b/mysql-test/t/innodb_mysql_lock.te
Hi Sergei,
On Wed, Jun 01, 2016 at 08:39:36AM +0200, Sergei Golubchik wrote:
> Hi, Sergey!
>
> On Jun 01, Sergey Vojtovich wrote:
> > On Tue, May 31, 2016 at 06:48:31PM +0200, Sergei Golubchik wrote:
> > >
> > > I think it's fine. I had a few questions though, see below:
> > Thanks for positive
Hi, Sergey!
On Jun 01, Sergey Vojtovich wrote:
> On Tue, May 31, 2016 at 06:48:31PM +0200, Sergei Golubchik wrote:
> >
> > I think it's fine. I had a few questions though, see below:
> Thanks for positive feedback. As I mentioned before, I'm less
> optimistic about this patch due to many behavior
Hi Sergei,
On Tue, May 31, 2016 at 06:48:31PM +0200, Sergei Golubchik wrote:
> Hi, Sergey,
>
> I think it's fine. I had a few questions though, see below:
Thanks for positive feedback. As I mentioned before, I'm less optimistic about
this patch due to many behavior changes. I can try to make a li
8 matches
Mail list logo
