Re: [Maria-developers] Rev 4407: MDEV-6916: Upgrade from MySQL to MariaDB breaks already created views

2015-04-24 Thread Sergei Golubchik
Hi, Daniel! Thanks! I've now reviewed the fix as a whole, all patches combined. There weren't many comments, but still there were some. And questions. If you'd like I can apply the latest changes (finishing touches, so to say) myself - it can speed things up. Or you can do that, whatever you

Re: [Maria-developers] Rev 4407: MDEV-6916: Upgrade from MySQL to MariaDB breaks already created views

2015-04-13 Thread Daniel Black
No Phase 0 please, renumber all phases to start from 1. Took opportunity to make adding/changing phases to be lest conflicts in merge https://github.com/openquery/mariadb-server/commit/25872e2802a4ae32d4f18132d569599295c963cd I don't know whether it's a good idea. It means that, for

Re: [Maria-developers] Rev 4407: MDEV-6916: Upgrade from MySQL to MariaDB breaks already created views

2015-04-13 Thread Sergei Golubchik
Hi, Daniel! On Apr 12, Daniel Black wrote: For review: Hi All, list of all changes: https://github.com/openquery/mariadb-server/commits/MDEV-6916-maria-5.5-check_view-r4408 side by side comparision of Sanja/my work against 5.5 head:

Re: [Maria-developers] Rev 4407: MDEV-6916: Upgrade from MySQL to MariaDB breaks already created views

2015-04-12 Thread Daniel Black
For review: Hi All, list of all changes: https://github.com/openquery/mariadb-server/commits/MDEV-6916-maria-5.5-check_view-r4408 side by side comparision of Sanja/my work against 5.5 head:

Re: [Maria-developers] Rev 4407: MDEV-6916: Upgrade from MySQL to MariaDB breaks already created views

2015-04-11 Thread Daniel Black
Hi Sanja! I was trying to continue this piece of work (incorporating Sergei's review below) since it seems abandoned. Bit sad since it looks like you put a lot of effort into this. Unfortunately the binary mysql-test/std_data/mysql_upgrade/event.* files didn't make it to the mailing list

Re: [Maria-developers] Rev 4407: MDEV-6916: Upgrade from MySQL to MariaDB breaks already created views

2015-02-09 Thread Sergei Golubchik
Hi, Sanja! On Feb 09, Oleksandr Byelkin wrote: On 09.02.15 15:19, Sergei Golubchik wrote: On Feb 09, sa...@askmonty.org wrote: At file:///home/bell/maria/bzr/work-maria-5.5-MDEV-6916-check_view/ === modified file 'client/mysqlcheck.c' --- a/client/mysqlcheck.c 2014-02-17 10:00:51

Re: [Maria-developers] Rev 4407: MDEV-6916: Upgrade from MySQL to MariaDB breaks already created views

2015-02-09 Thread Oleksandr Byelkin
On 09.02.15 15:19, Sergei Golubchik wrote: Hi, Sanja! On Feb 09, sa...@askmonty.org wrote: At file:///home/bell/maria/bzr/work-maria-5.5-MDEV-6916-check_view/ revno: 4407 revision-id:

Re: [Maria-developers] Rev 4407: MDEV-6916: Upgrade from MySQL to MariaDB breaks already created views

2015-02-09 Thread Sergei Golubchik
Hi, Sanja! On Feb 09, sa...@askmonty.org wrote: At file:///home/bell/maria/bzr/work-maria-5.5-MDEV-6916-check_view/ revno: 4407 revision-id: sa...@askmonty.org-20150209014828-kx3cr36hgrvjhtrg parent: