Re: [Maria-developers] ed477a6d30c: MDEV-29056 Replica thread reports error on ALTER ONLINE after LOCK WRITE

2022-09-09 Thread Nikita Malyavin
Up to you, I have no straight opinion which way is better. I only think that both ways are manageable. BTW, why we have no such problem with INPLACE? On Sat, 27 Aug 2022 at 18:11, Sergei Golubchik wrote: > Hi, Nikita, > > No, in this case (and commonly for collateral changes) I'd rather prefer

Re: [Maria-developers] ed477a6d30c: MDEV-29056 Replica thread reports error on ALTER ONLINE after LOCK WRITE

2022-08-27 Thread Sergei Golubchik
Hi, Nikita, No, in this case (and commonly for collateral changes) I'd rather prefer to refine the original (878a92e) commit to not cause the MDEV-29056 in the first place. Ignoring LOCK= clause is logically correct and that's what the old code was doing anyway. But perhaps ALTER TABLE still