Re: [Maria-discuss] Which binaries include support for compression zstd and lz4?

2020-06-28 Thread Otto Kekäläinen
Hello Jonas! >> If you are a coder and want to spend development time yourself, then I >> >> suggest you contribute to the PR review instead of spending time >> building sources and maintaining repositories of your own. > > > As a matter of fact I am a coder, however I am not sure if I could be

Re: [Maria-discuss] Which binaries include support for compression zstd and lz4?

2020-06-27 Thread Otto Kekäläinen
> I did remake it, didn't know it was in your PR. > My fix was almost exactly the same as yours, down to missing underscores > in the error message. I've had one change inside Findzstd.cmake, but > that's the only difference. > > In my defense, I've done it in 10.3, where the bug was introduced. >

Re: [Maria-discuss] Which binaries include support for compression zstd and lz4?

2020-06-27 Thread Jonas Krauss
Hi Sergei, I've fixed it, so the next release should have zstd again. > And we're adding tests to make sure this won't happen again. > Sorry for this. > No problem, I am glad this has been taken care of already. Will wait for the next release then. Otto: If you are a coder and want to spend

Re: [Maria-discuss] Which binaries include support for compression zstd and lz4?

2020-06-27 Thread Sergei Golubchik
Hi, Otto! I did remake it, didn't know it was in your PR. My fix was almost exactly the same as yours, down to missing underscores in the error message. I've had one change inside Findzstd.cmake, but that's the only difference. In my defense, I've done it in 10.3, where the bug was introduced.

Re: [Maria-discuss] Which binaries include support for compression zstd and lz4?

2020-06-27 Thread Otto Kekäläinen
The zstd bugfix is the second cimmit in my PR has been open for 20 days. I hope Serg you cherry picked it instead of remaking it https://github.com/MariaDB/server/commit/b4a532b27bf1ab1fd1ff2a5db9638630010b57cc la 27. kesäk. 2020 klo 19.58 Sergei Golubchik kirjoitti: > Hi, Jonas! > > On Jun

Re: [Maria-discuss] Which binaries include support for compression zstd and lz4?

2020-06-27 Thread Sergei Golubchik
Hi, Jonas! On Jun 27, Jonas Krauss wrote: > Hello all, > > I would like to have the most recent MariaDB 10.5.4 with the MyRocks plugin > and support for LZ4 *and* ZSTD compression on a Debian-based Linux distro. > > So far I have found: > >- Ubuntu 18.04, MariaDB 10.2.26 binaries support

Re: [Maria-discuss] Which binaries include support for compression zstd and lz4?

2020-06-27 Thread Otto Kekäläinen
Hello! > Thanks for your answer, Otto. > >> What do you mean by "not final in RocksDB"? > > > I mean the MyRocks option "ZSTDNotFinal" instead of the regular option > "ZSTD". I guess Facebook used ZSTDNotFinal before ZSTD reached 1.0? > >> We have work in progress to upstream this support to the

Re: [Maria-discuss] Which binaries include support for compression zstd and lz4?

2020-06-27 Thread Otto Kekäläinen
Hello! > Ubuntu 18.04, MariaDB 10.2.26 binaries support LZ4 and ZSTD (not final in > rocksdb) What do you mean by "not final in RocksDB"? > Is there any way to tell which compression algos are supported by which > releases on which distros? Not at the moment. The page

[Maria-discuss] Which binaries include support for compression zstd and lz4?

2020-06-27 Thread Jonas Krauss
Hello all, I would like to have the most recent MariaDB 10.5.4 with the MyRocks plugin and support for LZ4 *and* ZSTD compression on a Debian-based Linux distro. So far I have found: - Ubuntu 18.04, MariaDB 10.2.26 binaries support LZ4 and ZSTD (not final in rocksdb) - Debian 10,