Re: [Matlab-emacs-discuss] completion and goto-function in matlab-mode (Doom emacs)

2021-01-17 Thread Eric Ludlam
Hi Karthik, Thanks for the update and explanation. I finally had some time to sit with your code, try it out in a few situations, and teach myself how xref works.  I haven't had much opportunity to learn all the new stuff in eieio that it uses, so that was nice. I created matlab-xref.el on

Re: [Matlab-emacs-discuss] completion and goto-function in matlab-mode (Doom emacs)

2021-01-17 Thread Eric Ludlam
Hi Jonathan, I tried using: M-x matlab-shell RET M-x company-mode RET then @ matlab prompt: >> fo M-x company-matlab-shell RET to simulate what you have in your stack trace below.  I get a yellow popup with completions I expect in it.  I can pick one and it then inserts the completion corr

Re: [Matlab-emacs-discuss] completion and goto-function in matlab-mode (Doom emacs)

2021-01-17 Thread Haik Silm
Dear Jonathan, I am running Doom Emacs and had the same issue. The problem is that the temporary output should be removed, but the lines in the shell-buffer have a special read-only mode. The work-around is to set `inhibit-read-only`. So what solved it: (defadvice! inhibit-real-only-a (old

Re: [Matlab-emacs-discuss] completion and goto-function in matlab-mode (Doom emacs)

2021-01-17 Thread Eric Ludlam
Thanks Haik. That implies a patch like this will fix the issue... ? Do you know what is being set to read-only and why?  A better patch might disable whatever that is since other code may need something similar, and it would be better to fix the source than add little patches like this around

Re: [Matlab-emacs-discuss] completion and goto-function in matlab-mode (Doom emacs)

2021-01-17 Thread Karthik Chikmagalur
Hi Eric, The `matlab-local-xref` backend is quite useful, thank you for taking the time to go through it. I did notice something in this function: (defun matlab-shell-xref-activate () "Function to activate xref backend. Add this function to `xref-backend-functions' for matlab shell to use xref