>>> "EL" == Eric Ludlam writes:
> For prob2, it looks like when 'matlab-fill-code' is nil, it won't fill
> the code (via auto-fill mode), and it throws that error. I pushed a
> change that will not fill code if matlab-fill-code is nil so it won't
> error anymore.
I have set matlab-fill-code to t
>>> "EL" == Eric Ludlam writes:
> Is anyone out there interested in the "code fill" feature?
You mean besides me 😇 I do hope so!
> It was a hairy thing to implement back in the day, and most of the
> feedback I got was "how do I turn this off?" It is likely easier to
> drop the feature than f
Hi Uwe,
I created a fill-fix branch which I hung off master to include the changes.
That branch happens to include an mlint hack for Cygwin, and a toy I wrote a
while ago but never got around to sending a long. The commit log should
explain the changes.
Eric
From: Uwe Brauer
Sent: Tuesday,
The patch was based on the same rev that the previous patch was based on. Ie
– it includes the previous patch, or changes to it.
If that doesn’t fit, I can make and push a branch against main instead. That
might be easier to work with if you have more feedback.
Eric
From: Uwe Brauer
Sent:
For prob2, it looks like when 'matlab-fill-code' is nil, it won't fill the code
(via auto-fill mode), and it throws that error.
I pushed a change that will not fill code if matlab-fill-code is nil so it
won't error anymore.
Ideally, I suppose you might wan to set matlab-fill-code to t round-abo
I saw an error indicated in your readme and tried it out. I pushed a fix that
will improve that particular case.
Eric
From: Uwe Brauer
Sent: Thursday, July 27, 2023 2:59 AM
To: Eric Ludlam
Cc: Uwe Brauer ; Matlab-emacs-discuss
Subject: Re: the filling patch and its problems
>>> "EL" == Eri
Is anyone out there interested in the "code fill" feature? It was a hairy
thing to implement back in the day, and most of the feedback I got was "how do
I turn this off?" It is likely easier to drop the feature than figure out how
to fix it for all cases.
Basically, it isn't hard to create a
Hi Uwe,
Here’s a revised patch that does a better job filling comments, and also fixes
the indent region issue you found.
Hope these work for you.
Eric
From: Uwe Brauer
Sent: Tuesday, July 11, 2023 2:53 AM
To: Eric Ludlam
Cc: Matlab-emacs-discuss
Subject: the filling patch and its problems
Hi Uwe,
If you think it is useful, then feel free to turn that error into a warning.
A problem with the algorithm is it doesn’t plan ahead. It tries to break at
the fill-column, and if that happens to be at the beginning of a string, then
the resultant split adds some syntax to re-assemble the