Re: [matplotlib-devel] Experiments in removing/replacing PyCXX

2012-12-04 Thread Eric Firing
On 2012/12/04 12:07 PM, Damon McDougall wrote: > On Mon, Dec 3, 2012 at 12:12 PM, Chris Barker - NOAA Federal > wrote: >> generated code is ugly and hard to maintain, it is not designed to be >> human-readable, and we wouldn't get the advantages of bug-fixes >> further development in Cython. > > A

Re: [matplotlib-devel] Experiments in removing/replacing PyCXX

2012-12-04 Thread Ryan May
On Tue, Dec 4, 2012 at 4:07 PM, Damon McDougall wrote: > On Mon, Dec 3, 2012 at 12:12 PM, Chris Barker - NOAA Federal > wrote: > > generated code is ugly and hard to maintain, it is not designed to be > > human-readable, and we wouldn't get the advantages of bug-fixes > > further development in C

Re: [matplotlib-devel] Experiments in removing/replacing PyCXX

2012-12-04 Thread Damon McDougall
On Mon, Dec 3, 2012 at 12:12 PM, Chris Barker - NOAA Federal wrote: > generated code is ugly and hard to maintain, it is not designed to be > human-readable, and we wouldn't get the advantages of bug-fixes > further development in Cython. As far as I'm concerned, this is an argument against Cytho

Re: [matplotlib-devel] build failure in v1.2.x branch

2012-12-04 Thread Benjamin Root
On Tue, Dec 4, 2012 at 1:10 PM, Michael Droettboom wrote: > I think I see what's happened. I accidentally committed a #define in > there when I was experimenting last week with removing deprecated Numpy > APIs. It didn't cause things to break for me, but it looks like it could > break things f

Re: [matplotlib-devel] build failure in v1.2.x branch

2012-12-04 Thread Michael Droettboom
I think I see what's happened. I accidentally committed a #define in there when I was experimenting last week with removing deprecated Numpy APIs. It didn't cause things to break for me, but it looks like it could break things for more recent Numpy's. I've just gone ahead and reverted my cha

Re: [matplotlib-devel] build failure in v1.2.x branch

2012-12-04 Thread Benjamin Root
On Tue, Dec 4, 2012 at 10:43 AM, Michael Droettboom wrote: > It looks like we're using the "old" Numpy API there. Did you recently > update Numpy by any chance? I hadn't realised these APIs had been turned > off yet, but maybe they are in git master. In any event, we should update > these to

Re: [matplotlib-devel] build failure in v1.2.x branch

2012-12-04 Thread Michael Droettboom
It looks like we're using the "old" Numpy API there. Did you recently update Numpy by any chance? I hadn't realised these APIs had been turned off yet, but maybe they are in git master. In any event, we should update these to the new APIs (NPY_UBYTE instead of PyArray_UBYTE etc.). Cheers,

[matplotlib-devel] build failure in v1.2.x branch

2012-12-04 Thread Benjamin Root
I can't seem to build v1.2.x branch right now on CentOS6. This has not been a problem before. I get the following error message while trying to build the freetype2 stuff: creating build/temp.linux-x86_64-2.7/CXX gcc -pthread -fno-strict-aliasing -g -O2 -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DPY_AR

Re: [matplotlib-devel] Experiments in removing/replacing PyCXX

2012-12-04 Thread Michael Droettboom
Also -- this feedback is really helpful when writing some comments in the wrappers as to why certain things are the way they are... I'll make sure to include rationales for raw file fast path and the need to open the files on the Python side. Mike On 12/04/2012 08:45 AM, Michael Droettboom wr

Re: [matplotlib-devel] Experiments in removing/replacing PyCXX

2012-12-04 Thread Michael Droettboom
On 12/03/2012 08:01 PM, Chris Barker - NOAA Federal wrote: > On Mon, Dec 3, 2012 at 4:16 PM, Nathaniel Smith wrote: > >> Yeah, this is a general problem with the Python file API, trying to >> hook it up to stdio is not at all an easy thing. A better version of >> this code would skip that altogeth

Re: [matplotlib-devel] Experiments in removing/replacing PyCXX

2012-12-04 Thread Michael Droettboom
On 12/03/2012 07:16 PM, Nathaniel Smith wrote: > On Mon, Dec 3, 2012 at 11:50 PM, Chris Barker - NOAA Federal > wrote: >> On Mon, Dec 3, 2012 at 2:21 PM, Nathaniel Smith wrote: >>> For the file handle, I would just write >>> >>>cdef FILE *fp = fdopen(file_obj.fileno(), "w") >>> >>> and be don

Re: [matplotlib-devel] Experiments in removing/replacing PyCXX

2012-12-04 Thread Michael Droettboom
On 12/03/2012 07:00 PM, Chris Barker - NOAA Federal wrote: > On Mon, Dec 3, 2012 at 12:24 PM, Chris Barker - NOAA Federal > wrote: > > but some of that complexity could be reduced by using Numpy arrays in > place >>> It would at least make this a more fair comparison to have the Cython >>