Re: [matplotlib-devel] MEP13 - python containers

2014-07-31 Thread Todd
I would suggest create a new branch, though. You can create a new branch from the old one, then make your changes there. That way if you mess up something you still have the original to fall back on. On Thu, Jul 31, 2014 at 5:15 PM, Thomas Caswell wrote: > Git lets you re-write history pretty

Re: [matplotlib-devel] MEP13 - python containers

2014-07-31 Thread Thomas Caswell
Git lets you re-write history pretty extensively. If you use a tool on top of git (I use magit in emacs) you can selectively commit hunks one or two at a time. At a minimum split it up by file. You are going to have to do some force-pushing anyway. Making the PRs as small as reasonable makes r

Re: [matplotlib-devel] MEP13 - python containers

2014-07-31 Thread jamesramm
Thomas Caswell wrote > I only took a brief look at that branch, but two comments > > 1) can you clean up your git history, you are adding 20k new lines (of > mostly freetype and random files that should not be tracked) > 2) can you split the propertify work up into chunks that are easier to > revi

Re: [matplotlib-devel] MEP13 - python containers

2014-07-31 Thread Thomas Caswell
I only took a brief look at that branch, but two comments 1) can you clean up your git history, you are adding 20k new lines (of mostly freetype and random files that should not be tracked) 2) can you split the propertify work up into chunks that are easier to review? On Thu, Jul 31, 2014 at 7:

Re: [matplotlib-devel] MEP13 - python containers

2014-07-31 Thread jamesramm
It seens that discussion of properties has died off, but I see it as a very important implementation for 2 reasons: 1. It will help with the implementation of stylsheets and a DOM-type model as proposed in MEP25 and MEP26 2. The act of working through the code to add properties exposes any incons