Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 12, 2011 at 12:56 PM, Eric Firing wrote: > On 01/12/2011 07:20 AM, Benjamin Root wrote: > > On Tue, Jan 11, 2011 at 3:13 PM, John Hunter > > wrote: > > > > On Mon, Jan 10, 2011 at 6:45 PM, Benjamin Root > > wrote: > > >

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 12, 2011 at 1:09 PM, Sandro Tosi wrote: > On Wed, Jan 12, 2011 at 18:20, Benjamin Root wrote: > > I am fine with letting 1.0.1 go out as is (unless we can't live with the > > is already out: look at SF download page to see how many have downloaded > it. > > > documentation typos that

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 12, 2011 at 1:09 PM, Sandro Tosi wrote: > If you're saying you want to publish another tarball with version > 1.0.1 that has different contents of the current one, than with my > distro package maintainer and programmer hats on I say "you should > not". If you have published (and not

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 12, 2011 at 18:20, Benjamin Root wrote: > I am fine with letting 1.0.1 go out as is (unless we can't live with the is already out: look at SF download page to see how many have downloaded it. > documentation typos that has shown up).  I am also hesistant about putting > out yet anoth

Re: [matplotlib-devel] Building documentation and matplotlibrc

On 01/12/2011 07:20 AM, Benjamin Root wrote: > On Tue, Jan 11, 2011 at 3:13 PM, John Hunter > wrote: > > On Mon, Jan 10, 2011 at 6:45 PM, Benjamin Root > wrote: > > John, > > > > Just to clarify, have we officially released

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Tue, Jan 11, 2011 at 3:13 PM, John Hunter wrote: > On Mon, Jan 10, 2011 at 6:45 PM, Benjamin Root wrote: > > John, > > > > Just to clarify, have we officially released 1.0.1, or are we still in > the > > RC phase? If we haven't released yet, what is the deadline for final > > patches for 1.0

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Mon, Jan 10, 2011 at 6:45 PM, Benjamin Root wrote: > John, > > Just to clarify, have we officially released 1.0.1, or are we still in the > RC phase?  If we haven't released yet, what is the deadline for final > patches for 1.0.1? > 1.0.1 is final but I held off on the announcement until Russe

Re: [matplotlib-devel] Building documentation and matplotlibrc

John, Just to clarify, have we officially released 1.0.1, or are we still in the RC phase? If we haven't released yet, what is the deadline for final patches for 1.0.1? Ben Root -- Gaining the trust of online customers i

Re: [matplotlib-devel] Building documentation and matplotlibrc

Hi John, On Thu, Jan 6, 2011 at 20:57, John Hunter wrote: > On Thu, Jan 6, 2011 at 1:24 PM, Benjamin Root wrote: >> Ah, all the more reason to apply abspath() or realpath().  To decide which >> to use, let's consider the case of someone (like a developer) having >> multiple builds of matplotlib

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Jan 6, 2011 at 1:24 PM, Benjamin Root wrote: > Ah, all the more reason to apply abspath() or realpath().  To decide which > to use, let's consider the case of someone (like a developer) having > multiple builds of matplotlib in separate directories, and uses a symlink to > point to whichev

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Jan 6, 2011 at 12:32 PM, John Hunter wrote: > On Thu, Jan 6, 2011 at 12:22 PM, John Hunter wrote: > > > matplotlib_fname() always returns absolute path. I have not used > > realpath, but if you think there is a use for it here, feel free to > > post an amended patch. > > There is an exc

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Jan 6, 2011 at 12:22 PM, John Hunter wrote: > matplotlib_fname() always returns absolute path.  I have not used > realpath, but if you think there is a use for it here, feel free to > post an amended patch. There is an exception to this -- if MATPLOTLIBRC or MPLCONFIGDIR are relative pat

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Jan 6, 2011 at 12:15 PM, Benjamin Root wrote: > A comment on the patch.  Unless matplotlib_fname() is guaranteed to return > an absolute filename, then we need to use realpath() on _basedir so that the > final joined filename will also be absolute.  The reason for using > realpath() inste

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Jan 6, 2011 at 11:50 AM, John Hunter wrote: > On Thu, Jan 6, 2011 at 11:36 AM, Benjamin Root wrote: > > On Thu, Jan 6, 2011 at 11:15 AM, John Hunter wrote: > >> > >> On Thu, Jan 6, 2011 at 10:58 AM, Benjamin Root wrote: > >> > >> > I thought that problem was already addressed in a prev

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Jan 6, 2011 at 11:36 AM, Benjamin Root wrote: > On Thu, Jan 6, 2011 at 11:15 AM, John Hunter wrote: >> >> On Thu, Jan 6, 2011 at 10:58 AM, Benjamin Root wrote: >> >> > I thought that problem was already addressed in a previous patch?  John, >> > could this be another "gremlin"?  Or did I

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Jan 6, 2011 at 11:15 AM, John Hunter wrote: > On Thu, Jan 6, 2011 at 10:58 AM, Benjamin Root wrote: > > > I thought that problem was already addressed in a previous patch? John, > > could this be another "gremlin"? Or did I mis-understand the whole issue > > absolute path problem? > >

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Jan 6, 2011 at 10:58 AM, Benjamin Root wrote: > I thought that problem was already addressed in a previous patch?  John, > could this be another "gremlin"?  Or did I mis-understand the whole issue > absolute path problem? My understanding is that because sphinx switches the current worki

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 10:42 PM, Sandro Tosi wrote: > On Thu, Jan 6, 2011 at 02:31, John Hunter wrote: > > mpl1> grep rc_file lib/matplotlib/sphinxext/plot_directive.py > > > > Surely I have it right now! > > Indeed, and it works fine!!! the only thing to notice is that > examples.directory mus

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Jan 6, 2011 at 02:31, John Hunter wrote: >  mpl1> grep rc_file lib/matplotlib/sphinxext/plot_directive.py > > Surely I have it right now! Indeed, and it works fine!!! the only thing to notice is that examples.directory must be an absolute path, but that set, the doc build process gets fil

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 5:53 PM, Sandro Tosi wrote: > On Wed, Jan 5, 2011 at 23:22, John Hunter wrote: >> OK, I found the problem.  Somehow my edit to sphinxext.plot_directive >> to actually call the new function was not saved and committed.  I just >> fixed this, so the branch *should* work.  The

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, 5 Jan 2011 16:00:40 -0600, John Hunter wrote: > Strange -- I'll try and test tonight with a machine disconnected from > the internet. Out of curiosity, what command/tool are you using to > monitor the internet requests? Ben, are you seeing the same problems? > It took me a long time to f

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 23:22, John Hunter wrote: > OK, I found the problem.  Somehow my edit to sphinxext.plot_directive > to actually call the new function was not saved and committed.  I just > fixed this, so the branch *should* work.  The branch > matlpotlib/sphinxext/plot_directive.py should c

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 3:49 PM, Sandro Tosi wrote: > On Wed, Jan 5, 2011 at 20:31, John Hunter wrote: >> On Wed, Jan 5, 2011 at 1:23 PM, Sandro Tosi wrote: >>> >>> On Wed, Jan 5, 2011 at 19:48, Sandro Tosi wrote: >>> > ehm... no, I'm testing it the rc + your patch, sorry :) I'm updating >>> > m

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 23:07, John Hunter wrote: > On Wed, Jan 5, 2011 at 4:04 PM, Sandro Tosi wrote: > >> it's not exactly monitory, but I disable all the requests to >> matplotlib.svn.sourceforge.net via iptables: >> >> sudo iptables -A OUTPUT -d matplotlib.svn.sourceforge.net -j DROP >> >> and

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 4:04 PM, Sandro Tosi wrote: > it's not exactly monitory, but I disable all the requests to > matplotlib.svn.sourceforge.net via iptables: > > sudo iptables -A OUTPUT -d matplotlib.svn.sourceforge.net -j DROP > > and you're sure nothing passes towards that address :) and in

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 23:00, John Hunter wrote: > On Wed, Jan 5, 2011 at 3:49 PM, Sandro Tosi wrote: > >> I tried with that branch, but I had no luck :( it still tries to >> download stuff from the net, whatever I set as examples.directory in >> matplotlibrc (yes, I'm trying to compile inside do

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 3:49 PM, Sandro Tosi wrote: > I tried with that branch, but I had no luck :( it still tries to > download stuff from the net, whatever I set as examples.directory in > matplotlibrc (yes, I'm trying to compile inside doc/ and I have > 'examples.download : False' set) and/or

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 20:31, John Hunter wrote: > On Wed, Jan 5, 2011 at 1:23 PM, Sandro Tosi wrote: >> >> On Wed, Jan 5, 2011 at 19:48, Sandro Tosi wrote: >> > ehm... no, I'm testing it the rc + your patch, sorry :) I'm updating >> > my local svn copy and try again >> >> Ok, I'm trying with tr

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 1:31 PM, John Hunter wrote: > We're working in the release branch.  Changes have not been made to trunk. > > svn co > https://matplotlib.svn.sourceforge.net/svnroot/matplotlib/branches/v1_0_maint > mpl1 > rc2 tarball is here: http://sourceforge.net/projects/matplotlib/fi

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 1:23 PM, Sandro Tosi wrote: > > On Wed, Jan 5, 2011 at 19:48, Sandro Tosi wrote: > > ehm... no, I'm testing it the rc + your patch, sorry :) I'm updating > > my local svn copy and try again > > Ok, I'm trying with trunk now (or those changes are on another > branch?), and i

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 19:48, Sandro Tosi wrote: > ehm... no, I'm testing it the rc + your patch, sorry :) I'm updating > my local svn copy and try again Ok, I'm trying with trunk now (or those changes are on another branch?), and it stops at reading sources... [ 20%] examples/axes_grid/demo_axe

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 19:45, John Hunter wrote: > On Wed, Jan 5, 2011 at 12:10 PM, John Hunter wrote: >> >> The code in matplotlib.cbook.get_sample_data reads: >> >>     if not matplotlib.rcParams['examples.download']: >>     directory = matplotlib.rcParams['examples.directory'] >>     f

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 12:10 PM, John Hunter wrote: > > The code in matplotlib.cbook.get_sample_data reads: > > if not matplotlib.rcParams['examples.download']: > directory = matplotlib.rcParams['examples.directory'] > f = os.path.join(directory, fname) > if asfileobj:

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 12:05 PM, Sandro Tosi wrote: > > yes, it's the version I'm going to use for the RC, that's because > version 1.0.1~rc1-1 is lower than 1.0.1-1 (debian versions) and so > uploading an RC package will not prevent for the final release to be > uploaded (1.0.1rc1-1 is bigger th

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 18:57, John Hunter wrote: > On Wed, Jan 5, 2011 at 11:48 AM, Sandro Tosi wrote: >> >> So you'll want to patch doc/matplotlibrc to set this param. >> >> ehm that's what I meant with "configuring doc/matplotlibrc" - I did that >> :) >> >> $ tail -n2 doc/matplotlibrc >> exampl

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 11:48 AM, Sandro Tosi wrote: > So you'll want to patch doc/matplotlibrc to set this param. > > ehm that's what I meant with "configuring doc/matplotlibrc" - I did that :) > > $ tail -n2 doc/matplotlibrc > examples.download : False # False to bypass downloading mechanism >

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 18:45, John Hunter wrote: > On Wed, Jan 5, 2011 at 11:41 AM, Sandro Tosi wrote: >> >> > +def rc_file_defaults(): >> > +    """ >> > +    Restore the default rc params from the original matplotlib rc that >> > +    was loaded >> > +    """ >> > +    rcParams.update(rcParamsO

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Wed, Jan 5, 2011 at 11:41 AM, Sandro Tosi wrote: > > +def rc_file_defaults(): > > +""" > > +Restore the default rc params from the original matplotlib rc that > > +was loaded > > +""" > > +rcParams.update(rcParamsOrig) > > + > > _use_error_msg = """ This call to matplotli

Re: [matplotlib-devel] Building documentation and matplotlibrc

Hi John, On Wed, Jan 5, 2011 at 15:04, John Hunter wrote: > I agree the current behavior needs to be improved.  I'm testing a change now > which utilizes two functions, now properly documented, and removing the hack > in the plot_directive since the file defaults will be preserved.  This keeps >

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Tue, Jan 4, 2011 at 4:40 PM, Sandro Tosi wrote: > Hi all, > > On Thu, Dec 9, 2010 at 23:04, Ben Gamari wrote: > > On Thu, 09 Dec 2010 16:44:37 -0500, Ben Gamari > wrote: > >> rcdefaults()'s implementation appears to implement the latter, updating > >> rcParams from rcParamsDefault in rcsetup

Re: [matplotlib-devel] Building documentation and matplotlibrc

Hi all, On Thu, Dec 9, 2010 at 23:04, Ben Gamari wrote: > On Thu, 09 Dec 2010 16:44:37 -0500, Ben Gamari wrote: >> rcdefaults()'s implementation appears to implement the latter, updating >> rcParams from rcParamsDefault in rcsetup.py, which appears to describe >> the factory default values. Perh

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, 09 Dec 2010 23:55:05 +0200, Jouni K. Seppänen wrote: > Ben Gamari writes: > > > It seems that matplotlib's sphinx extension calls > > matplotlib.rcdefaults() after rendering each figure, thus resetting > > examples.download to True (as set in rcsetup.py). > > Right, and it sets figure.f

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, 09 Dec 2010 16:44:37 -0500, Ben Gamari wrote: > rcdefaults()'s implementation appears to implement the latter, updating > rcParams from rcParamsDefault in rcsetup.py, which appears to describe > the factory default values. Perhaps we should > rcParamsDefault.update(rcParams) after loading

Re: [matplotlib-devel] Building documentation and matplotlibrc

Ben Gamari writes: > It seems that matplotlib's sphinx extension calls > matplotlib.rcdefaults() after rendering each figure, thus resetting > examples.download to True (as set in rcsetup.py). Right, and it sets figure.figsize after it. I guess you will want to set examples.download in the same

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, 09 Dec 2010 15:42:18 -0500, Ben Gamari wrote: > To try identifying where this happens I have tried putting some debug > output in RcParams.__setitem__(). Unfortunately this doesn't show anyone > setting examples.download after the initial loading of matplotlibrc. Any > ideas how/where this

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, 9 Dec 2010 14:09:41 -0600, John Hunter wrote: > On Thu, Dec 9, 2010 at 1:52 PM, Ben Gamari wrote: > > > Any idea why my debugging messages are ineffective? Or, even better, any > > idea why setting the examples.download in doc/matplotlibrc isn't being > > reflected in rc_params? I'll exa

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Dec 9, 2010 at 1:52 PM, Ben Gamari wrote: > Any idea why my debugging messages are ineffective? Or, even better, any > idea why setting the examples.download in doc/matplotlibrc isn't being > reflected in rc_params? I'll examine this more closely in about 30 > minutes once I make it to th

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, 9 Dec 2010 13:39:41 -0600, John Hunter wrote: > On Thu, Dec 9, 2010 at 1:12 PM, Ben Gamari wrote: > > > It seems that this may have been broken from the beginning. After > > noticing that my changes were not taking effect, I added some debug > > output and found that sphinx was changing

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Dec 9, 2010 at 1:12 PM, Ben Gamari wrote: > It seems that this may have been broken from the beginning. After > noticing that my changes were not taking effect, I added some debug > output and found that sphinx was changing the current working directory > (every example gets built with it

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, 9 Dec 2010 12:57:49 -0600, John Hunter wrote: > On Thu, Dec 9, 2010 at 12:34 PM, Ben Gamari wrote: > > > Regardless, after making the necessary changes to use absolute paths > > (after painfully realizing that the MATPLOTLIB environment variable > > expects the directory of the desired m

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, Dec 9, 2010 at 12:34 PM, Ben Gamari wrote: > Regardless, after making the necessary changes to use absolute paths > (after painfully realizing that the MATPLOTLIB environment variable > expects the directory of the desired matplotlibrc, not the file path; > documentation would have been n

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, 09 Dec 2010 20:00:39 +0200, Jouni K. Seppänen wrote: > Ben Gamari writes: > > > An absolute path is necesary because the current working directory > > changes for each example. > > Oh, right, the examples are in a lot of different subdirectories. > Precisely, this is the problem. Rega

Re: [matplotlib-devel] Building documentation and matplotlibrc

Ben Gamari writes: > An absolute path is necesary because the current working directory > changes for each example. Oh, right, the examples are in a lot of different subdirectories. > I'm very confused how you found that specifying a relative path in > download.path worked. If the cwd changes a

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Thu, 09 Dec 2010 18:37:34 +0200, Jouni K. Seppänen wrote: > Ben Gamari writes: > > > That being said, I've tracked down the reason for the configuration in > > doc/matplotlibrc not being used. It seems that sphinx runs the examples > > in their current directory (I suppose this is to be expec

Re: [matplotlib-devel] Building documentation and matplotlibrc

Ben Gamari writes: > That being said, I've tracked down the reason for the configuration in > doc/matplotlibrc not being used. It seems that sphinx runs the examples > in their current directory (I suppose this is to be expected). > > It seems that there is a (as far as I can tell undocumented, p

Re: [matplotlib-devel] Building documentation and matplotlibrc

Sorry to the Benjamin Drung, Scott Kitterman, and Sandro Tosi for not including you in this thread earlier. I am trying to bring the matplotlib 1.0.1 packaging into compliance with the debian packaging requirements. Unfortunately, matplotlib now includes out-of-tree sample data which is downloade

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Sun, 05 Dec 2010 23:03:02 +0200, Jouni K. Seppänen wrote: > Ben Gamari > writes: > > > In practice, however, I have run into a few issues. First, the comment > > regarding examples.directory indicates that this path must be > > absolute. Is this really true? > > The comment is wrong: a rela

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Sun, Dec 5, 2010 at 3:14 PM, Ben Gamari wrote: >> I am not intimately familiar with the doc build system, but the way that >> the "html" function in make.py copies matplotlibrc from mpl-data to >> _static, I suspect that it is trying to ensure that that particular file >> is used. >> > Anyone

Re: [matplotlib-devel] Building documentation and matplotlibrc

On Sun, 05 Dec 2010 23:03:02 +0200, Jouni K. Seppänen wrote: > Ben Gamari > writes: > > > In practice, however, I have run into a few issues. First, the comment > > regarding examples.directory indicates that this path must be > > absolute. Is this really true? > > The comment is wrong: a rela

Re: [matplotlib-devel] Building documentation and matplotlibrc

Ben Gamari writes: > In practice, however, I have run into a few issues. First, the comment > regarding examples.directory indicates that this path must be > absolute. Is this really true? The comment is wrong: a relative path will work (I just tried this). > Secondly, it seems that the doc/ma

[matplotlib-devel] Building documentation and matplotlibrc

This weekend I put a bit of time into bringing the Debian packaging[1] for the matplotlib 1.0 series up to date. In the tree it seems there is a matplotlibrc in the /doc directory. Judging from the documentation, it looks like matplotlib will first use a matplotlibrc in the current directory. This