Re: [matplotlib-devel] Code Review Request

2014-04-18 Thread Benjamin Root
A great quote from a GitHub presentation at SciPy 2012: "We consider Pull Requests to be the *start* of a conversation". Go ahead and make the pull request. We can then review it, and you can make revisions to your branch (the PR gets updated automatically as you push revisions up to it). Cheers!

[matplotlib-devel] Code Review Request

2014-04-18 Thread Benjamin Reedlunn
tcaswell suggested (https://github.com/matplotlib/matplotlib/issues/2972) I put together this example when I realized the difference between interpolation = 'none' and interpolation = 'nearest' in imshow(). The docstring for imshow() mentions this difference, but pictures are worth a thousand w

Re: [matplotlib-devel] Code review request: minor modifications to axes.boxplot

2011-12-09 Thread Paul Hobson
Ben, Thanks for the reply. I definitely like your idea. Seems like we could include some logic in axes.errorbar to look at the shapes of xerr and yerr in a similar fashion to what I propose for axes.boxplots, allowing the user to have custom lower and upper errors for each data point (in a time se

Re: [matplotlib-devel] Code review request: minor modifications to axes.boxplot

2011-12-09 Thread Benjamin Root
On Thu, Dec 8, 2011 at 10:45 AM, Paul Hobson wrote: > Matplotlib gurus: > > I took at stab at the git work flow and incorporated my personal > modifications to the boxplot function. Github's diff can be found > here: > https://github.com/phobson/matplotlib/compare/master...manual_boxplots > > In

[matplotlib-devel] Code review request: minor modifications to axes.boxplot

2011-12-08 Thread Paul Hobson
Matplotlib gurus: I took at stab at the git work flow and incorporated my personal modifications to the boxplot function. Github's diff can be found here: https://github.com/phobson/matplotlib/compare/master...manual_boxplots In summary, if your data is MxN, you can manually specify medians and t