Re: [matplotlib-devel] Patch/fix for two legend oddities/bugs

2010-08-25 Thread Jae-Joon Lee
Hmm, it seems that somehow I only applied the patch to the trunk. http://matplotlib.svn.sourceforge.net/viewvc/matplotlib?view=revisionrevision=8418 But I think the patch also need to be applied to the maint. version. I'll see what I can do. Regards, -JJ On Wed, Aug 25, 2010 at 3:42 AM, Erik

Re: [matplotlib-devel] Patch/fix for two legend oddities/bugs

2010-08-24 Thread Erik Tollerud
Did this fix ever get applied? I was looking at some other svn changes and it still says none of this part of legend.py has been altered... On Thu, Jun 10, 2010 at 8:50 AM, Jae-Joon Lee lee.j.j...@gmail.com wrote: On Wed, Jun 9, 2010 at 7:15 PM, Erik Tollerud erik.tolle...@gmail.com wrote:

Re: [matplotlib-devel] Patch/fix for two legend oddities/bugs

2010-06-10 Thread Jae-Joon Lee
On Wed, Jun 9, 2010 at 7:15 PM, Erik Tollerud erik.tolle...@gmail.com wrote: Jae-Joon, your patch looks to be effectively the same except for slightly different behavior when more than 3 points are present... but that was what was originally intended - the numpoints- scatterpoints was a good

Re: [matplotlib-devel] Patch/fix for two legend oddities/bugs

2010-06-09 Thread Jae-Joon Lee
Thanks for reporting these. I took a look at your patch and slight revised it (see the attached). While I believe that my patch is compatible to yours, it'll be great if you check my patch to see if I missed anything. I'll commit the change soon. Regards, -JJ On Tue, Jun 8, 2010 at 3:16 PM,

Re: [matplotlib-devel] Patch/fix for two legend oddities/bugs

2010-06-09 Thread Benjamin Root
I was trying the patch and I realized a possible use-case that might not have been thought of before. Consider the situation where a user does a scatter plot with markers of two different sizes. Then, it isn't that far-fetched that the user might also want to control the markerscale for each

Re: [matplotlib-devel] Patch/fix for two legend oddities/bugs

2010-06-09 Thread Jae-Joon Lee
I'm not very kin to implement every possible options for every possible cases. If you need customization beyond what the current legend class provide, I recommend you to use proxy artists. http://matplotlib.sourceforge.net/users/legend_guide.html#using-proxy-artist I personally think that the

Re: [matplotlib-devel] Patch/fix for two legend oddities/bugs

2010-06-09 Thread Erik Tollerud
Jae-Joon, your patch looks to be effectively the same except for slightly different behavior when more than 3 points are present... but that was what was originally intended - the numpoints- scatterpoints was a good catch! As for allowing an array markerscale, I agree with Jae-Joon... I think the

[matplotlib-devel] Patch/fix for two legend oddities/bugs

2010-06-08 Thread Erik Tollerud
I noticed some odd behavior in the legend and managed to track down the source of the problem and make a fix (a diff against the current svn is attached). Specifically, two things were fixed: *The markerscale argument for the legend seems to do nothing... The attached diff properly applies the

Re: [matplotlib-devel] Patch/fix for two legend oddities/bugs

2010-06-08 Thread Benjamin Root
Erik, Thanks for addressing this. I actually ran into this problem once a while back, but just figured that I was doing something wrong. I will check out your patch to see how well it works. Ben Root On Tue, Jun 8, 2010 at 2:16 PM, Erik Tollerud erik.tolle...@gmail.comwrote: I noticed some