Re: [matplotlib-devel] Patches for CTPUG / matplotlib-py3

2011-03-11 Thread Michael Droettboom
Thanks for doing all this work. I've put your first patch up as a pull request here, so we can comment on it: https://github.com/matplotlib/matplotlib-py3/pull/7 The examples patch I will combine with my own work to get the print_function stuff consistent, and then put up a pull request for al

Re: [matplotlib-devel] Patches for CTPUG / matplotlib-py3

2011-03-11 Thread Christoph Gohlke
On 3/11/2011 10:54 AM, Michael Droettboom wrote: > In examples/widgets/menu.py in your patch, you have the line: > > print(x,y,w,h) > > which prints "(1, 2, 3, 4)" on Python 2.x and "1 2 3 4" on Python 3.x. I missed that one. Christoph > > On further thought, we should probably put "from _

Re: [matplotlib-devel] Patches for CTPUG / matplotlib-py3

2011-03-11 Thread Michael Droettboom
In examples/widgets/menu.py in your patch, you have the line: print(x,y,w,h) which prints "(1, 2, 3, 4)" on Python 2.x and "1 2 3 4" on Python 3.x. On further thought, we should probably put "from __future__ import print_function" in all .py files whether they have print functions or not, j

Re: [matplotlib-devel] Patches for CTPUG / matplotlib-py3

2011-03-11 Thread Christoph Gohlke
On 3/11/2011 8:54 AM, Michael Droettboom wrote: > I think the examples with print functions need a: > > "from __future__ import print_function" > > otherwise, it prints tuples rather than treating the (...) as function > arguments. > > Cheers, > Mike I changed all print statements to `print("a s

Re: [matplotlib-devel] Patches for CTPUG / matplotlib-py3

2011-03-11 Thread Michael Droettboom
I think the examples with print functions need a: "from __future__ import print_function" otherwise, it prints tuples rather than treating the (...) as function arguments. Cheers, Mike On 03/10/2011 02:18 PM, Christoph Gohlke wrote: On 3/9/2011 12:01 PM, Benjamin Root wrote: On Wed, Ma

Re: [matplotlib-devel] Patches for CTPUG / matplotlib-py3

2011-03-10 Thread Christoph Gohlke
On 3/9/2011 12:01 PM, Benjamin Root wrote: On Wed, Mar 9, 2011 at 5:23 AM, Christoph Gohlke mailto:cgoh...@uci.edu>> wrote: Hello, please consider the attached patch for the matplotlib-py3 CTPUG fork on github. The patch fixes several build and runtime issues/crashes. Tested

Re: [matplotlib-devel] Patches for CTPUG / matplotlib-py3

2011-03-09 Thread Benjamin Root
On Wed, Mar 9, 2011 at 5:23 AM, Christoph Gohlke wrote: > Hello, > > please consider the attached patch for the matplotlib-py3 CTPUG fork on > github. The patch fixes several build and runtime issues/crashes. Tested on > win-amd64-py3.2. > > Christoph > > Christoph, A quick point of style lookin

[matplotlib-devel] Patches for CTPUG / matplotlib-py3

2011-03-09 Thread Christoph Gohlke
Hello, please consider the attached patch for the matplotlib-py3 CTPUG fork on github. The patch fixes several build and runtime issues/crashes. Tested on win-amd64-py3.2. Christoph diff --git a/lib/matplotlib/backend_bases.py b/lib/matplotlib/backend_bases.py index b3d4403..64848c2 100644 --