Re: [matplotlib-devel] Problem adding a new test

2009-10-14 Thread Michael Droettboom
Andrew Straw wrote: > Michael Droettboom wrote: > >> A couple more comments about the test framework -- which has already >> paid for itself ten times over. In Numpy (and a number of local >> Python projects), I can 'cd' to the tests directory and do something >> like: >> >>nosetests test_s

Re: [matplotlib-devel] Problem adding a new test

2009-10-12 Thread Jouni K . Seppänen
Andrew Straw writes: > I just noticed the test_axes/hexbin_extent.svg baseline image is more > than 5 MB. I wonder if we can somehow simplify the svg generated to > reduce the file size or if we should perhaps just not do the svg > extension on this test? How about keeping them gzipped? If yo

Re: [matplotlib-devel] Problem adding a new test

2009-10-12 Thread Michael Droettboom
I suspect for that one we can just do without it. It isn't really testing anything SVG-specific. Mike Andrew Straw wrote: > Michael Droettboom wrote: >> I've committed support for comparing SVG files using Inkscape and >> verifying them against the official SVG DTD using xmllint. > I just not

Re: [matplotlib-devel] Problem adding a new test

2009-10-12 Thread Andrew Straw
Michael Droettboom wrote: > I've committed support for comparing SVG files using Inkscape and > verifying them against the official SVG DTD using xmllint. I just noticed the test_axes/hexbin_extent.svg baseline image is more than 5 MB. I wonder if we can somehow simplify the svg generated to re

Re: [matplotlib-devel] Problem adding a new test

2009-10-12 Thread Andrew Straw
Michael Droettboom wrote: > I've committed support for comparing SVG files using Inkscape and > verifying them against the official SVG DTD using xmllint. > Man, are we standards compliant around here or what? :) Cool. > Michael Droettboom wrote: > >> Andrew Straw wrote: >> >> >>> D

Re: [matplotlib-devel] Problem adding a new test

2009-10-12 Thread Michael Droettboom
I've committed support for comparing SVG files using Inkscape and verifying them against the official SVG DTD using xmllint. Michael Droettboom wrote: > Andrew Straw wrote: > >> Done in r7863. To make use of it, do something like the following patch >> (and don't forget to delete the baseline

Re: [matplotlib-devel] Problem adding a new test

2009-10-09 Thread Michael Droettboom
Andrew Straw wrote: >>> As far as the test data -- I agree this is an issue. One point in favor >>> of the status quo is that it's really nice to have the test data >>> included with the source code so there are no configuration hassles. I'm >>> not sure how well the buildbot infrastructure would c

Re: [matplotlib-devel] Problem adding a new test

2009-10-09 Thread Andrew Straw
Michael Droettboom wrote: >> "inkscape input.svg --export-png=output.png" works very well as an svg >> renderer. >> > I'd also like to run SVG through xmllint against the SVG schema as > another sanity check. I may get to this if I can find the time. That'd be great. I just installed inkscap

Re: [matplotlib-devel] Problem adding a new test

2009-10-09 Thread Michael Droettboom
Andrew Straw wrote: > Jouni K. Seppänen wrote: > >> Jouni K. Seppänen writes: >> >> When we add new formats (comparing postscript files could easily be done >> using the same ghostscript command as used for pdf files, and some svg >> renderer could also be added) >> > > "inkscape inpu

Re: [matplotlib-devel] Problem adding a new test

2009-10-09 Thread Andrew Straw
Jouni K. Seppänen wrote: > Jouni K. Seppänen writes: > > >> Oh, right. My fault: when I implemented the pdf comparison, I made it >> run the test for only those formats for which a baseline image exists, >> > > I committed a change to make it run both png and pdf tests all the time. >

Re: [matplotlib-devel] Problem adding a new test

2009-10-09 Thread Jouni K . Seppänen
Jouni K. Seppänen writes: > Oh, right. My fault: when I implemented the pdf comparison, I made it > run the test for only those formats for which a baseline image exists, I committed a change to make it run both png and pdf tests all the time. When we add new formats (comparing postscript files

Re: [matplotlib-devel] Problem adding a new test

2009-10-09 Thread Jouni K . Seppänen
Michael Droettboom writes: > Unfortunately, it doesn't seem to be running the new test at all. If I > put "assert False" at the top of the test, and even that doesn't fail. > If I remove the "image_comparison" decorator, however, the test will > fail. Maybe this is because the baseline imag

[matplotlib-devel] Problem adding a new test

2009-10-09 Thread Michael Droettboom
I went to create a new image comparison test related to the hatching bug reported this morning. I added my test to the bottom of test_simplification.py, and ran all the tests as follows: python -c "import matplotlib; matplotlib.test()" Unfortunately, it doesn't seem to be running the new te