Re: [matplotlib-devel] Pull request

2013-10-25 Thread Todd
On Fri, Oct 25, 2013 at 2:34 PM, Pierre Haessig wrote: > Hi, > > Le 22/10/2013 19:14, Todd a écrit : > > Thanks for the feedback. I agree that your documentation does make clear >> the distinction between "phase" and "angle" and that it has a consistency. >> I just feel that this distinction doe

Re: [matplotlib-devel] Pull request

2013-10-25 Thread Todd
On Fri, Oct 25, 2013 at 2:57 PM, Pierre Haessig wrote: > Hello, > > > Now that that PR #2522 is merged, I don't know how much futher commenting > is useful, but I think there are two API details that I feel could be > better : > > 1) API dissymetry > > The new pyplot/axes API is now: > > * 1 fun

Re: [matplotlib-devel] Pull request

2013-10-25 Thread Todd
On Fri, Oct 25, 2013 at 3:06 PM, Pierre Haessig wrote: > Hi, > > Le 21/10/2013 15:58, Todd a écrit : > > 2) Should there be two separate functions for these two, or just one >> >> function, with a switch argument `unwrap` ? (I guess it would be True by >> default) >> > > I originally was going

Re: [matplotlib-devel] Pull request

2013-10-25 Thread Pierre Haessig
Le 25/10/2013 14:57, Pierre Haessig a écrit : > 2) default NFFT value being hidden from views > > used to be def specgram(x, NFFT=256, Fs=2, ... > now is def specgram(x, NFFT=None, Fs=None > > I think that NFFT is an important parameter of the spectrum > computation. It should not be /hidden f

Re: [matplotlib-devel] Pull request

2013-10-25 Thread Pierre Haessig
Hi, Le 21/10/2013 15:58, Todd a écrit : > > 2) Should there be two separate functions for these two, or just one > function, with a switch argument `unwrap` ? (I guess it would be > True by > default) > > > I originally was going to do that, but decided against it. The > problem i

Re: [matplotlib-devel] Pull request

2013-10-25 Thread Pierre Haessig
Hello, Now that that PR #2522 is merged, I don't know how much futher commenting is useful, but I think there are two API details that I feel could be better : 1) API dissymetry The new pyplot/axes API is now: * 1 function *spectgram* now uses a mode argument to tune this behavior : *mode*:

Re: [matplotlib-devel] Pull request

2013-10-25 Thread Pierre Haessig
Hi, Le 22/10/2013 19:14, Todd a écrit : > > Thanks for the feedback. I agree that your documentation does make > clear the distinction between "phase" and "angle" and that it has > a consistency. I just feel that this distinction does not exist > "outside" ... > > But beyond th

Re: [matplotlib-devel] Pull request

2013-10-22 Thread Todd
On Tue, Oct 22, 2013 at 6:06 PM, Pierre Haessig wrote: > Hi, > > Le 21/10/2013 15:58, Todd a écrit : > > On Mon, Oct 21, 2013 at 3:13 PM, Pierre Haessig > wrote: > >1) is the terminology "phase" vs. "angle" spectrum standardized ? I >> must >> say I've never heard of one meaning "wrapped" a

Re: [matplotlib-devel] Pull request

2013-10-22 Thread Todd
On Tue, Oct 22, 2013 at 5:41 PM, Pierre Haessig wrote: > Hi, > > Le 22/10/2013 12:31, Todd a écrit : > > Currently, both axes.psd and axes.csd return the same thing as > > mlab.psd and mlab.csd, namely the spectrum and frequency points. They > > do NOT return the line object that was plotted. Th

Re: [matplotlib-devel] Pull request

2013-10-22 Thread Pierre Haessig
Hi, Le 21/10/2013 15:58, Todd a écrit : > On Mon, Oct 21, 2013 at 3:13 PM, Pierre Haessig > mailto:pierre.haes...@crans.org>> wrote: > > 1) is the terminology "phase" vs. "angle" spectrum standardized ? > I must > say I've never heard of one meaning "wrapped" and the other > "unwra

Re: [matplotlib-devel] Pull request

2013-10-22 Thread Pierre Haessig
Hi, Le 22/10/2013 12:31, Todd a écrit : > Currently, both axes.psd and axes.csd return the same thing as > mlab.psd and mlab.csd, namely the spectrum and frequency points. They > do NOT return the line object that was plotted. This is different > than specgram, which returns the AxesImage object

Re: [matplotlib-devel] Pull request

2013-10-22 Thread Todd
On Sun, Oct 20, 2013 at 9:45 AM, Todd wrote: > Hello, > > I submitted a pull request #2522 [1]. It includes support for more basic > spectrum plots like magnitude and phase spectrums. These are extremely > commonly used in signal processing, acoustics, and many other fields, but > are also very

Re: [matplotlib-devel] Pull request

2013-10-21 Thread Todd
On Mon, Oct 21, 2013 at 3:13 PM, Pierre Haessig wrote: > Hi, > > Le 20/10/2013 09:45, Todd a écrit : > > I submitted a pull request #2522 [1]. It includes support for more > > basic spectrum plots like magnitude and phase spectrums. These are > > extremely commonly used in signal processing, aco

Re: [matplotlib-devel] Pull request

2013-10-21 Thread Pierre Haessig
Hi, Le 20/10/2013 09:45, Todd a écrit : > I submitted a pull request #2522 [1]. It includes support for more > basic spectrum plots like magnitude and phase spectrums. These are > extremely commonly used in signal processing, acoustics, and many > other fields, but are also very important for ed