Re: [matplotlib-devel] build error in ttutil.cpp on win32

2007-10-16 Thread Charlie Moad
WIN32 worked for the last matplotlib release build I did, but I agree this patch is harmless. Thanks for looking into it this much. - Charlie On 10/16/07, Michael Droettboom <[EMAIL PROTECTED]> wrote: > Thanks. Sorry about the syntax errors -- I don't use the preprocessor > much either. > > I t

Re: [matplotlib-devel] build error in ttutil.cpp on win32

2007-10-16 Thread Michael Droettboom
Thanks. Sorry about the syntax errors -- I don't use the preprocessor much either. I think this patch seems reasonable (or at least reasonably harmless), so I'll go ahead and commit it. Cheers, Mike Martin Spacek wrote: > Michael Droettboom wrote: >> Hmmm... Well, I think we've reached the l

Re: [matplotlib-devel] build error in ttutil.cpp on win32

2007-10-16 Thread Martin Spacek
Michael Droettboom wrote: Hmmm... Well, I think we've reached the limit of my MSVC knowledge (which doesn't go very far.) I presume that for your local copy, you can just hard code it to : #ifdef 1 || WIN32 || _MSC_VER Actually, I just tried that, and it didn't work. Again, I don't rea

Re: [matplotlib-devel] build error in ttutil.cpp on win32

2007-10-15 Thread Michael Droettboom
Hmmm... Well, I think we've reached the limit of my MSVC knowledge (which doesn't go very far.) I presume that for your local copy, you can just hard code it to : #ifdef 1 || WIN32 || _MSC_VER and at least get it working for yourself. But I think someone with more MSVC experience on

Re: [matplotlib-devel] build error in ttutil.cpp on win32

2007-10-12 Thread Martin Spacek
Sorry for the delay. I gave that a try, but it didn't help. Seems that _MSC_VER is undefined as well... Martin Michael Droettboom wrote: > Martin Spacek wrote: >> It's been a few months since I've updated and compiled from svn. I got >> this error today from rev 3926 (in winxp using msvc71): >> >

Re: [matplotlib-devel] build error in ttutil.cpp on win32

2007-10-08 Thread Michael Droettboom
Martin Spacek wrote: > It's been a few months since I've updated and compiled from svn. I got > this error today from rev 3926 (in winxp using msvc71): > >> python setup.py build_ext --inplace --force > > > BUILDING MATP

Re: [matplotlib-devel] build error in ttutil.cpp on win32

2007-10-07 Thread Charlie Moad
Hmm, that fix was specifically for visual studio. The "#ifdef WIN32" worked for my build, but possible that is the wrong constant to check for in visual studio? I'll take a look again. - Charlie On 10/5/07, Martin Spacek <[EMAIL PROTECTED]> wrote: > It's been a few months since I've updated and