Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-16 Thread Phil Elson
In the meantime, PEP8 PRs can be completed on master, after which feature enhancements can proceed on master. I think it would be helpful to hold fire on the PEP8 changes until we have our rc3 and have merged it back onto master for (hopefully) the last time. That way, we wont have to deal with

[matplotlib-devel] request for code review: updates to Sankey class

2012-10-16 Thread Kevin Davies
Hello, I made a few minor changes to the Sankey class. They are listed at: https://github.com/kdavies4/matplotlib/compare/master...sankey5 Please review this and let me know if I can submit a pull request. Thanks. Kevin

Re: [matplotlib-devel] request for code review: updates to Sankey class

2012-10-16 Thread Damon McDougall
On Tue, Oct 16, 2012 at 2:55 PM, Kevin Davies kdavi...@gmail.com wrote: Hello, I made a few minor changes to the Sankey class. They are listed at: https://github.com/kdavies4/matplotlib/compare/master...sankey5 Please review this and let me know if I can submit a pull request. Thanks.

[matplotlib-devel] Color Parsing Bug

2012-10-16 Thread T J
There seems to be an issue with how arguments are parsed when it comes to determining the color of a line. Generally, it seems that 'c' takes precedence over 'color'. However, this precedence seems to change with the number of passed kwargs. - import matplotlib.pyplot as plt import

Re: [matplotlib-devel] request for code review: updates to Sankey class

2012-10-16 Thread Kevin Davies
Thanks for your comments! see below... On 10/16/2012 10:14 AM, Damon McDougall wrote: On Tue, Oct 16, 2012 at 2:55 PM, Kevin Davies kdavi...@gmail.com wrote: Hello, I made a few minor changes to the Sankey class. They are listed at: