Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-16 Thread Phil Elson
In the meantime, PEP8 PRs can be completed on master, after which feature enhancements can proceed on master. I think it would be helpful to hold fire on the PEP8 changes until we have our rc3 and have merged it back onto master for (hopefully) the last time. That way, we wont have to deal with

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-15 Thread Nelle Varoquaux
On 15 October 2012 06:10, Eric Firing efir...@hawaii.edu wrote: On 2012/10/14 12:44 PM, Damon McDougall wrote: On Sun, Oct 14, 2012 at 9:22 PM, Eric Firing efir...@hawaii.edu wrote: All, I think we are in a messy situation, and we need to reach some agreement as to how to proceed.

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-15 Thread Nelle Varoquaux
On 15 October 2012 04:49, Jae-Joon Lee lee.j.j...@gmail.com wrote: I'd agree with Eric on most of his points. On Mon, Oct 15, 2012 at 5:22 AM, Eric Firing efir...@hawaii.edu wrote: If some of the PEP8 commits include genuine bug-fixes that need to be in v1.2.x, then these fixes should be

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-15 Thread Damon McDougall
On Mon, Oct 15, 2012 at 8:59 AM, Nelle Varoquaux nelle.varoqu...@gmail.com wrote: On 15 October 2012 06:10, Eric Firing efir...@hawaii.edu wrote: On 2012/10/14 12:44 PM, Damon McDougall wrote: On Sun, Oct 14, 2012 at 9:22 PM, Eric Firing efir...@hawaii.edu wrote: All, I think we are

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-15 Thread Benjamin Root
On Monday, October 15, 2012, Nelle Varoquaux wrote: On 15 October 2012 04:49, Jae-Joon Lee lee.j.j...@gmail.comjavascript:_e({}, 'cvml', 'lee.j.j...@gmail.com'); wrote: I'd agree with Eric on most of his points. On Mon, Oct 15, 2012 at 5:22 AM, Eric Firing

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-15 Thread Phil Elson
Firstly, I think you are right to bring this up Eric, we should all agree what the best course is to take, and then all work together to get us there with the least amount of disruption possible. if we leave PEP8 out of v1.2.x, and decide that once it is released, v1.2.x will be changed only if

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-15 Thread Michael Droettboom
On 10/15/2012 08:11 AM, Phil Elson wrote: Firstly, I think you are right to bring this up Eric, we should all agree what the best course is to take, and then all work together to get us there with the least amount of disruption possible. if we leave PEP8 out of v1.2.x, and decide that once

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-15 Thread Eric Firing
On 2012/10/15 5:50 AM, Michael Droettboom wrote: Sorry to be jumping in on this late -- I didn't have a chance to catch up with this over the weekend. I think I generally side with Eric here -- the rc candidate cycle is intended to be quite conservative. Nelle's pull requests are very

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-15 Thread Michael Droettboom
On 10/15/2012 12:52 PM, Eric Firing wrote: On 2012/10/15 5:50 AM, Michael Droettboom wrote: Sorry to be jumping in on this late -- I didn't have a chance to catch up with this over the weekend. I think I generally side with Eric here -- the rc candidate cycle is intended to be quite

[matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Eric Firing
All, I think we are in a messy situation, and we need to reach some agreement as to how to proceed. This has been discussed a bit in this thread: http://sourceforge.net/mailarchive/forum.php?thread_name=507AFDC6.8000801%40hawaii.eduforum_name=matplotlib-devel The name of that thread did not

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Damon McDougall
On Sun, Oct 14, 2012 at 9:22 PM, Eric Firing efir...@hawaii.edu wrote: All, I think we are in a messy situation, and we need to reach some agreement as to how to proceed. This has been discussed a bit in this thread:

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Eric Firing
On 2012/10/14 12:44 PM, Damon McDougall wrote: On Sun, Oct 14, 2012 at 9:22 PM, Eric Firing efir...@hawaii.edu wrote: All, I think we are in a messy situation, and we need to reach some agreement as to how to proceed. This has been discussed a bit in this thread:

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Thomas Kluyver
On 14 October 2012 21:22, Eric Firing efir...@hawaii.edu wrote: 3) The potential disagreement is over whether the PEP8 changes should be cherry-picked into v1.2.x, or simply left in master. I favor the latter course. I'm not familiar with matplotlib's merge strategy, but I'd agree with you

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Jae-Joon Lee
I'd agree with Eric on most of his points. On Mon, Oct 15, 2012 at 5:22 AM, Eric Firing efir...@hawaii.edu wrote: If some of the PEP8 commits include genuine bug-fixes that need to be in v1.2.x, then these fixes should be made via PRs directly against v1.2.x. I think it is not a good idea to

Re: [matplotlib-devel] strategy for 1.2.x, master, PEP8 changes

2012-10-14 Thread Eric Firing
On 2012/10/14 4:49 PM, Jae-Joon Lee wrote: I'd agree with Eric on most of his points. On Mon, Oct 15, 2012 at 5:22 AM, Eric Firing efir...@hawaii.edu wrote: If some of the PEP8 commits include genuine bug-fixes that need to be in v1.2.x, then these fixes should be made via PRs directly