Re: [PATCH] space on prompt bugfix

2005-06-03 Thread Leonard den Ottolander
Hello Oswald, Andy, and Jindrich, This email was in my drafts as I wanted to look into this a bit more before sending it to the list. Sending it anyway as the tab issue is a bit more complicated as you seem to think: On Wed, 2005-05-25 at 18:13, Oswald Buddenhagen wrote: On Wed, May 25, 2005

Re: [PATCH] space on prompt bugfix

2005-06-01 Thread Jindrich Novy
Hello Andy, Oswald, On Wed, 2005-05-25 at 18:13 +0200, Oswald Buddenhagen wrote: On Wed, May 25, 2005 at 06:31:15PM +0300, Andy Shevchenko wrote: - why do you not drop tabspaces? hmm, indeed, if i go into troubles to press ctrl-q tab, the same issue comes up. I'm attaching the new patch

Re: [PATCH] space on prompt bugfix

2005-06-01 Thread Oswald Buddenhagen
On Wed, Jun 01, 2005 at 11:10:16AM +0200, Jindrich Novy wrote: I'm attaching the new patch given that the other patch was finally applied, an incremental patch would be more helpful. anyway, i think the change can be commited without further comment ... -- Hi! I'm a .signature virus! Copy me

Re: [PATCH] space on prompt bugfix

2005-06-01 Thread Jindrich Novy
On Wed, 2005-06-01 at 13:32 +0200, Oswald Buddenhagen wrote: On Wed, Jun 01, 2005 at 11:10:16AM +0200, Jindrich Novy wrote: I'm attaching the new patch given that the other patch was finally applied, an incremental patch would be more helpful. I haven't noticed any post confirming the

Re: [PATCH] space on prompt bugfix

2005-05-25 Thread Andy Shevchenko
Oswald Buddenhagen: I see two issues with this patch: - why do you not drop tabspaces? - the beheviour of space...smth should be accorded to shell (no put the command to the history), isn't it? -- With best regards, Andy Shevchenko. mailto: [EMAIL PROTECTED]

Re: [PATCH] space on prompt bugfix

2005-05-25 Thread Oswald Buddenhagen
On Wed, May 25, 2005 at 06:31:15PM +0300, Andy Shevchenko wrote: - why do you not drop tabspaces? hmm, indeed, if i go into troubles to press ctrl-q tab, the same issue comes up. - the beheviour of space...smth should be accorded to shell (no put the command to the history), isn't it? this

Re: [PATCH] space on prompt bugfix

2005-05-25 Thread Andy Shevchenko
Oswald Buddenhagen: I see two issues with this patch: - why do you not drop tabspaces? - the beheviour of space...smth should be accorded to shell (no put the command to the history), isn't it? -- With best regards, Andy Shevchenko. mailto: [EMAIL PROTECTED]

Re: [PATCH] space on prompt bugfix

2005-05-24 Thread Jindrich Novy
Hello Oswald, Leonard, On Tue, 2005-05-24 at 07:52 +0200, Oswald Buddenhagen wrote: On Mon, May 23, 2005 at 11:12:21PM +0200, Leonard den Ottolander wrote: On Mon, 2005-05-23 at 22:56, Oswald Buddenhagen wrote: this paranoid checking policy doesn't get us anywhere but to the current

Re: [PATCH] space on prompt bugfix

2005-05-23 Thread Leonard den Ottolander
Hi Oswald, On Sat, 2005-05-21 at 20:07, Oswald Buddenhagen wrote: On Wed, Apr 27, 2005 at 11:24:06PM +0200, Leonard den Ottolander wrote: Any objections against me committing this patch? The real command line argument seems bogus, as a real command line would accept a command existing of

Re: [PATCH] space on prompt bugfix

2005-05-23 Thread Oswald Buddenhagen
On Mon, May 23, 2005 at 10:44:01PM +0200, Leonard den Ottolander wrote: On Sat, 2005-05-21 at 20:07, Oswald Buddenhagen wrote: On Wed, Apr 27, 2005 at 11:24:06PM +0200, Leonard den Ottolander wrote: So can I commit this? I'll verify that it works first ;) , but the patch seems straight

Re: [PATCH] space on prompt bugfix

2005-05-23 Thread Leonard den Ottolander
Hi Oswald, On Mon, 2005-05-23 at 22:56, Oswald Buddenhagen wrote: of course not. i had a look and have not found something fundamentally broken about it. if a real mc developer would do the same, it should be totally sufficient. I'm not sure if I would qualify. this paranoid checking policy

Re: [PATCH] space on prompt bugfix

2005-05-23 Thread Oswald Buddenhagen
On Mon, May 23, 2005 at 11:12:21PM +0200, Leonard den Ottolander wrote: On Mon, 2005-05-23 at 22:56, Oswald Buddenhagen wrote: this paranoid checking policy doesn't get us anywhere but to the current state of stagnation. Bollocks. [how reviewing is good, etc.] i was talking about the

Re: [PATCH] space on prompt bugfix

2005-05-21 Thread Oswald Buddenhagen
On Mon, Mar 21, 2005 at 09:19:34AM +0100, Jindrich Novy wrote: Hi mc-devel! There's a bug I've been annoyed with for some time so I finally decided to fix it. To reproduce: 1. start mc 2. go to some directory where you see some further subdirectories 3. press space once or for more

Re: [PATCH] space on prompt bugfix

2005-04-27 Thread Leonard den Ottolander
Hi, On Mon, 2005-03-21 at 18:25, Jindrich Novy wrote: On Mon, 2005-03-21 at 17:42 +0100, [EMAIL PROTECTED] wrote: Not a good idea, since I think if you prepend a space to any command, the command is not saved in bash history - a feature. Sometimes it may be thus desirable to be able to

Re: [PATCH] space on prompt bugfix

2005-03-21 Thread buc
Jindrich Novy wrote: I did two patches to fix it so that you can decide which one is better commit candidate. Patch1: Allows an user to type leading spaces on the command prompt, but when enter is pressed, it tests whether the user typed at least something except spaces. In case it finds only

Re: [PATCH] space on prompt bugfix

2005-03-21 Thread buc
Jindrich Novy wrote: IMHO, patch1 is better way. Else end user can decide the space key is not working ... Yes, the spacebar won't be working for leading spaces. However, typing the leading spaces in the command prompt IMHO doesn't make too much sense to me so maybe after patch2 is applied

Re: [PATCH] space on prompt bugfix

2005-03-21 Thread tux
Patch2: Doesn't let the user to type leading spaces if he didn't write a non- space letter already. Not a good idea, since I think if you prepend a space to any command, the command is not saved in bash history - a feature. Sometimes it may be thus desirable to be able to type leading space

Re: [PATCH] space on prompt bugfix

2005-03-21 Thread Jindrich Novy
Hello Martin, On Mon, 2005-03-21 at 17:42 +0100, [EMAIL PROTECTED] wrote: Patch2: Doesn't let the user to type leading spaces if he didn't write a non- space letter already. Not a good idea, since I think if you prepend a space to any command, the command is not saved in bash history -

Re: [PATCH] space on prompt bugfix

2005-03-21 Thread Leonard den Ottolander
Hi Jindrich, On Mon, 2005-03-21 at 18:25, Jindrich Novy wrote: On Mon, 2005-03-21 at 17:42 +0100, [EMAIL PROTECTED] wrote: Not a good idea, since I think if you prepend a space to any command, the command is not saved in bash history - a feature. Sometimes it may be thus desirable to be

Re[2]: [PATCH] space on prompt bugfix

2005-03-21 Thread Pavel Shirshov (pchel)
Hello buc, Monday, March 21, 2005, 7:44:46 PM, you wrote: b Intuitively, the MC can be perceived as a screen extension to shell b (which became possible due to ncurses/slang lib and Ctr/Fn/Alt/Meta b keyboard features). Therefore, MC`s cmdline should be closer to a shell b command line, rather