view.c erroneously assumes it can easily malloc a file if mmap failed and
passes view-s.st_size to g_malloc. But if largefile support has been enabled,
view-s.st_size is a 64 bit value and thus possibly exceeds the limit of
gulong which g_malloc takes for size. This patch fixes it.
2003-02-26
Adam Byrtek / alpha wrote:
Hi, I'm attaching MC patchfs update. Could you please review and test
this patch, and if everything is ok - apply it?
Regards
. . .
Index: ChangeLog
===
RCS file: /cvs/gnome/mc/vfs/ChangeLog,v
retrieving
On Wed, Feb 26, 2003 at 05:12:59PM +0200, Andrew V. Samoilov wrote:
+2003-02-24 Adam Byrtek [EMAIL PROTECTED]
+
+* extfs/patchfs.in: rm and proper copyin support, more
+functions to make code more clear
+
Good job! Applied, thanks.
I've sent this patch to Andrew privately for
On Wed, Feb 26, 2003 at 04:21:21PM +0100, Adam Byrtek / alpha wrote:
I've sent this patch to Andrew privately for review, it is the feature
Arpi asked for. As is has been accepted I'm sending the patch to the
list - could you please test it?
Forgotten to attach the patch...
--
_.|._ |_
hi, there!
Attached patch implements cons.handler.c for FreeBSD console.
Tested on both FreeBSD 4.x and 5.x.
/fjoe
--- src/cons.handler.c.orig Mon Sep 23 13:43:23 2002
+++ src/cons.handler.c Wed Feb 26 22:09:57 2003
@@ -186,9 +186,8 @@
}
}
-#endif /* #ifdef linux */
+#elif
Hello, Philipp!
view.c erroneously assumes it can easily malloc a file if mmap failed and
passes view-s.st_size to g_malloc. But if largefile support has been enabled,
view-s.st_size is a 64 bit value and thus possibly exceeds the limit of
gulong which g_malloc takes for size. This patch
* Pavel Roskin ([EMAIL PROTECTED]) [20030226 19:08]:
I've applied a much simple patch for this:
/* Make sure view-s.st_size is not truncated when passed to g_malloc */
if ((gulong) view-s.st_size == view-s.st_size)
view-data = (unsigned char *) g_malloc ((gulong) view-s.st_size);
Yes
Hello, Max!
Attached patch implements cons.handler.c for FreeBSD console.
Tested on both FreeBSD 4.x and 5.x.
Applied. Thank you!
--
Regards,
Pavel Roskin
___
Mc-devel mailing list
[EMAIL PROTECTED]
http://mail.gnome.org/mailman/listinfo/mc-devel
Yes, this sure is much simpler :) Just don't forget to view-data=NULL in
the else branch as otherwise you'll get a segfault here:
if (view-data != NULL)
g_free (view-data);
Thanks! Fixed.
--
Regards,
Pavel Roskin
___
Mc-devel
On Wed, Feb 26, 2003 at 01:08:34PM -0500, Pavel Roskin wrote:
Hello, Philipp!
view.c erroneously assumes it can easily malloc a file if mmap failed and
passes view-s.st_size to g_malloc. But if largefile support has been enabled,
view-s.st_size is a 64 bit value and thus possibly exceeds
hi, there!
On Wed, Feb 26, 2003 at 02:16:14PM -0500, Pavel Roskin wrote:
Attached patch implements cons.handler.c for FreeBSD console.
Tested on both FreeBSD 4.x and 5.x.
Applied. Thank you!
If you have the list of contributors please mention
Alexander Serkov [EMAIL PROTECTED]. He did
11 matches
Mail list logo