Re: segfault viewing tar with symlinks

2005-11-12 Thread Leonard den Ottolander
Hello Bernhard,

On Sat, 2005-11-12 at 04:06 +0100, Bernhard Kuemel wrote:
 My mc segfaults when entering a tar archive with symlinks: 

It would be nice if you'd upgrade to a more recent version before
reporting bugs. We've seen the release of 4.6.1 months ago.

By the way, don't bother for this particular case. The issue you report
has been long fixed.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: make distcheck warnings

2005-11-12 Thread Leonard den Ottolander
Hello Pavel,

On Thu, 2005-11-10 at 20:55 -0500, Pavel Roskin wrote:
 I chose version 0.14.3 was chosen because Fedora Core 4 supplies it.  It
 should be old enough for the core developers to have it, and new enough
 to have most bugs fixed.

I'm not so sure it's such a good idea to have the build depend on such a
recent version of gettext. You might fix a few bugs, but you break
compatibility with a lot of legacy systems. What exactly is it we need
version 0.14.3 for?

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Internal slang updated to 2.0.5

2005-11-12 Thread Leonard den Ottolander
Hi,

As the idea to introduce a second version of an internal slang was not
met with much enthusiasm and I don't think we should drop the internal
slang (yet?) I've upgraded the internal version to 2.0.5.

It's quite possible a few patches that were added to our internal
version of slang our now missing but still required. If you run into
such issues please report them here, so I can make an effort to get them
included upstream. Or report them upstream yourself.

As long as we feature an internal version of slang I hope to do regular
updates.

Leonard.
-- 
mount -t life -o ro /dev/dna /genetic/research


___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: utf8 patch for mc, slang 2 version

2005-11-12 Thread Leonard den Ottolander
Hi Bart, list,

On Tue, 2005-09-20 at 08:14 +1200, Bart Oldeman wrote:
 Basically you'd need to apply Fedora's patch, and then (sorry no proper 
 patch here but it's not a big deal)

Attached you'll find a proper patch. I've moved the hunk from global.h
to myslang.h (and dropped the inclusion of slang.h as it is redundant).

Jindrich, please merge this patch with the UTF8 patch. You might even
consider to build the next mc for FC --with-screen=mcslang, as I see the
FC development tree does not yet feature slang-2.

Leonard.

-- 
mount -t life -o ro /dev/dna /genetic/research

diff -pruN mc-4.6.1a/src/help.c mc-4.6.1a_utf8_slang2/src/help.c
--- mc-4.6.1a/src/help.c	2005-11-12 17:46:32.0 +0100
+++ mc-4.6.1a_utf8_slang2/src/help.c	2005-11-12 17:52:11.0 +0100
@@ -449,7 +449,7 @@ static void help_show (Dlg_head *h, cons
 #ifndef HAVE_SLANG
 			addch (acs_map [c]);
 #else
-#ifdef UTF8
+#if defined(UTF8)  SLANG_VERSION  2
 			SLsmg_draw_object (h-y + line + 2, h-x + col + 2, acs_map [c]);
 #else
 			SLsmg_draw_object (h-y + line + 2, h-x + col + 2, c);
diff -pruN mc-4.6.1a/src/myslang.h mc-4.6.1a_utf8_slang2/src/myslang.h
--- mc-4.6.1a/src/myslang.h	2005-11-12 17:46:32.0 +0100
+++ mc-4.6.1a_utf8_slang2/src/myslang.h	2005-11-12 18:09:27.0 +0100
@@ -11,6 +11,12 @@
 #endif	/* HAVE_SLANG_SLANG_H */
 #endif
 
+#if SLANG_VERSION = 2
+#define UTF8 1
+#define SLsmg_Is_Unicode SLsmg_is_utf8_mode()
+void SLsmg_write_nwchars(wchar_t *s, size_t n);
+#endif
+
 #ifdef UTF8
 #include wchar.h
 #endif
diff -pruN mc-4.6.1a/src/slint.c mc-4.6.1a_utf8_slang2/src/slint.c
--- mc-4.6.1a/src/slint.c	2005-09-05 04:14:29.0 +0200
+++ mc-4.6.1a_utf8_slang2/src/slint.c	2005-11-12 17:49:21.0 +0100
@@ -141,7 +141,9 @@ void
 slang_init (void)
 {
 SLtt_get_terminfo ();
-
+#if SLANG_VERSION = 2
+SLutf8_enable (-1);
+#endif
/*
 * If the terminal in not in terminfo but begins with a well-known
 * string such as linux or xterm S-Lang will go on, but the
diff -pruN mc-4.6.1a/src/util.c mc-4.6.1a_utf8_slang2/src/util.c
--- mc-4.6.1a/src/util.c	2005-11-12 17:46:32.0 +0100
+++ mc-4.6.1a_utf8_slang2/src/util.c	2005-11-12 17:55:17.0 +0100
@@ -56,6 +56,14 @@
 static const char app_text [] = Midnight-Commander;
 int easy_patterns = 1;
 
+#if SLANG_VERSION = 2
+void SLsmg_write_nwchars(wchar_t *s, size_t n)
+{
+while(n--)
+	SLsmg_write_char(*s++);
+}
+#endif
+
 extern void str_replace(char *s, char from, char to)
 {
 for (; *s != '\0'; s++) {
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel


Re: make distcheck warnings

2005-11-12 Thread Pavel Roskin
Quoting Leonard den Ottolander [EMAIL PROTECTED]:

 Hello Pavel,

 On Thu, 2005-11-10 at 20:55 -0500, Pavel Roskin wrote:
  I chose version 0.14.3 was chosen because Fedora Core 4 supplies it.  It
  should be old enough for the core developers to have it, and new enough
  to have most bugs fixed.

 I'm not so sure it's such a good idea to have the build depend on such a
 recent version of gettext. You might fix a few bugs, but you break
 compatibility with a lot of legacy systems.

What kind of breakage do you see or expect to see?  Could you please provide
more details?  I actually think newer versions of gettext should work better
with legacy systems, since the fixes are incorporated into gettext runtime over
time.

 What exactly is it we need
 version 0.14.3 for?

Darwin support without that ugly kludge in configure.ac.  Less warnings (there
are still plenty of them in the gettext code if you run my mctest, but neither
of them seems to indicate a real problem).

Actually, the CVS version of gettext supports message contexts, so it would be
nice to switch to it soon after it's released.

--
Regards,
Pavel Roskin
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel